Skip to content

Remove confirmation from builder exit#9286

Merged
AustinMroz merged 1 commit intopysssss/appmode-exit-updatesfrom
austin/remove-builder-exit-confirm
Feb 27, 2026
Merged

Remove confirmation from builder exit#9286
AustinMroz merged 1 commit intopysssss/appmode-exit-updatesfrom
austin/remove-builder-exit-confirm

Conversation

@AustinMroz
Copy link
Collaborator

@AustinMroz AustinMroz commented Feb 27, 2026

With the move to always storing builder selection changes, the confirmation dialogue on builder exit is no longer needed

┆Issue is synchronized with this Notion page by Unito

@AustinMroz AustinMroz marked this pull request as ready for review February 27, 2026 19:30
@AustinMroz AustinMroz requested a review from a team as a code owner February 27, 2026 19:30
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Feb 27, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 27, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch austin/remove-builder-exit-confirm

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Feb 27, 2026

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 02/27/2026, 07:31:23 PM UTC

Links

@github-actions
Copy link

github-actions bot commented Feb 27, 2026

🎭 Playwright: ✅ 545 passed, 0 failed · 6 flaky

📊 Browser Reports
  • chromium: View Report (✅ 532 / ❌ 0 / ⚠️ 6 / ⏭️ 10)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 10 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

@AustinMroz
Copy link
Collaborator Author

This is a PR directly into #9218

@github-actions
Copy link

⚡ Performance Report

No baseline found — showing absolute values.

Metric Value
canvas-idle: style recalcs 121
canvas-idle: layouts 0
canvas-idle: task duration 400ms
canvas-idle: heap delta -3.6 MB
canvas-mouse-sweep: style recalcs 179
canvas-mouse-sweep: layouts 12
canvas-mouse-sweep: task duration 911ms
canvas-mouse-sweep: heap delta -2.2 MB
dom-widget-clipping: style recalcs 43
dom-widget-clipping: layouts 0
dom-widget-clipping: task duration 359ms
dom-widget-clipping: heap delta 6.6 MB
Raw data
{
  "timestamp": "2026-02-27T19:33:26.566Z",
  "gitSha": "3f05a2dd0b8ad5ad57c75b12233389ffe78af204",
  "branch": "austin/remove-builder-exit-confirm",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 1994.7679999999934,
      "styleRecalcs": 121,
      "styleRecalcDurationMs": 21.204,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 400.127,
      "heapDeltaBytes": -3783112
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1957.3000000000036,
      "styleRecalcs": 179,
      "styleRecalcDurationMs": 57.21999999999999,
      "layouts": 12,
      "layoutDurationMs": 4.024,
      "taskDurationMs": 910.6550000000001,
      "heapDeltaBytes": -2350848
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 579.5359999999903,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 13.982000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 358.78,
      "heapDeltaBytes": 6947716
    }
  ]
}

@AustinMroz AustinMroz merged commit c02bbdf into pysssss/appmode-exit-updates Feb 27, 2026
34 checks passed
@AustinMroz AustinMroz deleted the austin/remove-builder-exit-confirm branch February 27, 2026 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants