test to validate subrouting #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmonkey4eva
added
New Browser Test Expectations
mcmonkey4eva
added
New Browser Test Expectations
huchenlei
approved these changes
Sep 23, 2024
huchenlei
added a commit
that referenced
this pull request
Sep 23, 2024
This reverts commit 6a3dbe0.
huchenlei
added a commit
that referenced
this pull request
Sep 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test to validate subrouted comfy instances, ie instances that are not accessed at the
/webrootExamples of this case "in the real world" include SwarmUI, as well as users of nginx/apache2 configs that put their instance not-at-root, and likely a wide variety of other professional/enterprise deployments in particular.
This adds a frontend dev mode proxy route from
/testsubrouteindexto the root to simulate having some form of external proxy involved, connect to http://localhost:5173/testsubrouteindex/ to try it.I included the
history: createWebHistory(window.location.pathname),change to temporarily patch subrouting to work, pending @dmx974 adding a more proper solution that fits his goals with more complex routing.The playwright test itself is the main goal of this PR, to ensure breakage does not happen in the future.
However from my local tests it is not able to generate, which I'm not sure if that's just local playwright always being unreliable, or if it's an indication that the playwright copy does not apply the dev proxy, and a playwright-specific patch is needed to test the proxy.yeah local issues, works as intended on the github action server