Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TS types / merge ComfyLGraphNode #902

Merged
merged 6 commits into from
Sep 21, 2024
Merged

Add TS types / merge ComfyLGraphNode #902

merged 6 commits into from
Sep 21, 2024

Conversation

webfiltered
Copy link
Collaborator

  • Adds several LiteGraph augmentation declarations
  • Merges ComfyLGraphNode into the other declarations
  • Clears as type assertions
  • Clears a few TS errors

@webfiltered
Copy link
Collaborator Author

@huchenlei not sure if you wanted ComfyLGraphNode to stay (planning to use it later?) - but I thought the interface override would be better.

Happy to change this, but would still suggest keeping my constructor declaration (removes need to always narrow ctor type from Function).

huchenlei
huchenlei approved these changes Sep 21, 2024
View reviewed changes
Copy link
Member

@huchenlei huchenlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huchenlei huchenlei merged commit c7f1237 into Comfy-Org:main Sep 21, 2024
9 checks passed
@webfiltered webfiltered deleted the many-ts-types branch September 21, 2024 10:02
@huchenlei huchenlei mentioned this pull request Oct 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huchenlei huchenlei huchenlei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@webfiltered @huchenlei