Skip to content

[backport cloud/1.38] feat(persistence): add workspace-scoped storage keys and types#8982

Closed
comfy-pr-bot wants to merge 1 commit intocloud/1.38from
backport-8517-to-cloud-1.38
Closed

[backport cloud/1.38] feat(persistence): add workspace-scoped storage keys and types#8982
comfy-pr-bot wants to merge 1 commit intocloud/1.38from
backport-8517-to-cloud-1.38

Conversation

@comfy-pr-bot
Copy link
Member

@comfy-pr-bot comfy-pr-bot commented Feb 19, 2026

Backport of #8517 to cloud/1.38

Automatically created by backport workflow.

┆Issue is synchronized with this Notion page by Unito

## Summary

Adds the foundational types and key generation utilities for
workspace-scoped workflow draft persistence. This enables storing drafts
per-workspace to prevent data leakage between different ComfyUI
instances.

[Screencast from 2026-02-08
18-17-45.webm](https://github.com/user-attachments/assets/f16226e9-c1db-469d-a0b7-aa6af725db53)

## Changes

- **What**: Type definitions for draft storage (`DraftIndexV2`,
`DraftPayloadV2`, session pointers) and key generation utilities with
workspace/client scoping
- **Why**: The current persistence system stores all drafts globally,
causing cross-workspace data leakage when users work with multiple
ComfyUI instances

---------

Co-authored-by: Amp <amp@ampcode.com>
@comfy-pr-bot comfy-pr-bot requested a review from a team as a code owner February 19, 2026 03:31
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Feb 19, 2026
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Feb 19, 2026
@github-actions
Copy link

github-actions bot commented Feb 19, 2026

🎨 Storybook Build Status

Build completed successfully!

⏰ Completed at: 02/19/2026, 03:33:16 AM UTC

🔗 Links


🎉 Your Storybook is ready for review!

@github-actions
Copy link

github-actions bot commented Feb 19, 2026

🎭 Playwright Tests: 🕵🏻 No test results

📊 Browser Reports
  • chromium: ❌ Deployment failed
  • chromium-2x: ❌ Deployment failed
  • chromium-0.5x: ❌ Deployment failed
  • mobile-chrome: ❌ Deployment failed

@christian-byrne
Copy link
Contributor

I don't think we need to backport this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants