test: mark failing Vue Nodes Image Preview browser tests as fixme#8980
Merged
test: mark failing Vue Nodes Image Preview browser tests as fixme#8980
Conversation
dosubot
bot
added
the
size:XS
Contributor
📝 WalkthroughWalkthroughTwo test cases in the Vue Nodes image preview test suite are marked as fixme, deferring their execution while retaining their original test bodies and assertions. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 02/19/2026, 02:42:07 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
|
Playwright: ✅ 512 passed, 0 failed · 7 flaky 📊 Browser Reports
|
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 21.7 kB (baseline 21.7 kB) • ⚪ 0 BMain entry bundles and manifests
Graph Workspace — 914 kB (baseline 914 kB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Views & Navigation — 69 kB (baseline 69 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Panels & Settings — 427 kB (baseline 427 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
User & Accounts — 16.1 kB (baseline 16.1 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Editors & Dialogs — 785 B (baseline 785 B) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
UI Components — 42.5 kB (baseline 42.5 kB) • ⚪ 0 BReusable component library chunks
Data & Services — 2.17 MB (baseline 2.17 MB) • ⚪ 0 BStores, services, APIs, and repositories
Utilities & Hooks — 237 kB (baseline 237 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Vendor & Third-Party — 8.69 MB (baseline 8.69 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 7.42 MB (baseline 7.42 MB) • ⚪ 0 BBundles that do not match a named category
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
browser_tests/tests/vueNodes/interactions/node/imagePreview.spec.ts (1)
32-32: Consider adding a comment linking to the tracking issue.Using
test.fixmeis the correct Playwright idiom for known-failing tests. To help future maintainers understand why these tests are disabled and when they can be re-enabled, consider adding a brief comment referencing the related issue.💡 Optional: Add tracking context
+ // TODO(`#8143`): Re-enable after image context menu sync is fixed test.fixme('opens mask editor from image preview button', async ({ comfyPage }) => {+ // TODO(`#8143`): Re-enable after image context menu sync is fixed test.fixme('shows image context menu options', async ({ comfyPage }) => {Also applies to: 41-41
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@browser_tests/tests/vueNodes/interactions/node/imagePreview.spec.ts` at line 32, Add a brief comment above the test.fixme calls (e.g., the test named 'opens mask editor from image preview button' and the other fixme at the same block) that references the tracking issue or PR number explaining why the test is disabled and any conditions for re-enabling it; place the comment immediately above the test.fixme(...) invocation and include the issue URL or number and a short one-line status note.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@browser_tests/tests/vueNodes/interactions/node/imagePreview.spec.ts`:
- Line 32: Add a brief comment above the test.fixme calls (e.g., the test named
'opens mask editor from image preview button' and the other fixme at the same
block) that references the tracking issue or PR number explaining why the test
is disabled and any conditions for re-enabling it; place the comment immediately
above the test.fixme(...) invocation and include the issue URL or number and a
short one-line status note.
DrJKL
previously approved these changes
Feb 19, 2026
DrJKL
approved these changes
Feb 19, 2026
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (2)
browser_tests/tests/vueNodes/interactions/node/imagePreview.spec.ts (2)
32-41: Add a traceable reason to the fixme title.
Consider appending the issue ID (or brief reason) to the test title so reports show why it’s disabled.💡 Minimal update
- test.fixme('opens mask editor from image preview button', async ({ + test.fixme('opens mask editor from image preview button (`#8143`)', async ({🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@browser_tests/tests/vueNodes/interactions/node/imagePreview.spec.ts` around lines 32 - 41, Update the test.fixme title to include a traceable reason or issue ID so disabled test reports are informative: locate the test declaration using test.fixme('opens mask editor from image preview button', ...) (and related helper loadImageOnNode/comfyPage) and modify the title string to append a short reason or ticket number (e.g. "opens mask editor from image preview button — ISSUE-1234" or "… — flaky on CI") so the test runner output clearly shows why the test is skipped.
43-56: Add a traceable reason to the fixme title.
Same idea here—include the issue ID or a short reason in the title for quick auditability.💡 Minimal update
- test.fixme('shows image context menu options', async ({ comfyPage }) => { + test.fixme('shows image context menu options (`#8143`)', async ({ + comfyPage + }) => {🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@browser_tests/tests/vueNodes/interactions/node/imagePreview.spec.ts` around lines 43 - 56, Update the test.fixme title to include a traceable reason or issue ID so reviewers can audit why it’s skipped; locate the test invocation test.fixme('shows image context menu options', ...) and change the first argument to include a short tag (e.g. "[ISSUE-123]" or "[flaky]") or a brief reason like "[flaky - context menu timing]" so the skip is self-documenting.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@browser_tests/tests/vueNodes/interactions/node/imagePreview.spec.ts`:
- Around line 32-41: Update the test.fixme title to include a traceable reason
or issue ID so disabled test reports are informative: locate the test
declaration using test.fixme('opens mask editor from image preview button', ...)
(and related helper loadImageOnNode/comfyPage) and modify the title string to
append a short reason or ticket number (e.g. "opens mask editor from image
preview button — ISSUE-1234" or "… — flaky on CI") so the test runner output
clearly shows why the test is skipped.
- Around line 43-56: Update the test.fixme title to include a traceable reason
or issue ID so reviewers can audit why it’s skipped; locate the test invocation
test.fixme('shows image context menu options', ...) and change the first
argument to include a short tag (e.g. "[ISSUE-123]" or "[flaky]") or a brief
reason like "[flaky - context menu timing]" so the skip is self-documenting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mark the two browser tests added in #8143 as
test.fixme— they are failing on main.opens mask editor from image preview buttonshows image context menu optionsFixes fix: sync node.imgs for legacy context menu in Vue Nodes mode #8143 (browser test failures)
┆Issue is synchronized with this Notion page by Unito