[backport cloud/1.39] fix: sync node.imgs for legacy context menu in Vue Nodes mode#8970
Closed
comfy-pr-bot wants to merge 2 commits intocloud/1.39from
Closed
[backport cloud/1.39] fix: sync node.imgs for legacy context menu in Vue Nodes mode#8970comfy-pr-bot wants to merge 2 commits intocloud/1.39from
comfy-pr-bot wants to merge 2 commits intocloud/1.39from
Conversation
## Summary Fixes missing "Copy Image", "Open Image", "Save Image", and "Open in Mask Editor" context menu options on SaveImage nodes when Vue Nodes mode is enabled. ## Changes - Add `syncLegacyNodeImgs` store method to sync loaded image elements to `node.imgs` - Call sync on image load in ImagePreview component - Simplify mask editor handling to call composable directly ## Technical Details - Only runs when `vueNodesMode` is enabled (no impact on legacy mode) - Reuses already-loaded `<img>` element from Vue (no duplicate network requests) - Store owns the sync logic, component just hands off the element Supersedes #7416 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-8143-fix-sync-node-imgs-for-legacy-context-menu-in-Vue-Nodes-mode-2ec6d73d365081c59d42cd1722779b61) by [Unito](https://www.unito.io) --------- Co-authored-by: Amp <amp@ampcode.com>
dosubot
bot
added
the
size:L
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 02/19/2026, 03:32:33 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
|
Playwright: ❌ 519 passed, 2 failed · 3 flaky ❌ Failed Tests📊 Browser Reports
|
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- Remove stale @ts-expect-error in imagePreviewStore.test.ts (createMockNode now accepts Record<string, unknown> so animatedImages is valid) - Add waitFor + nextFrame in interaction.spec.ts beforeEach to let canvas settle after UseNewMenu layout shift Amp-Thread-ID: https://ampcode.com/threads/T-019c7313-f15a-707b-94a5-33f473a8dad5
Contributor
|
Too late to go on 1.39 anyway so not worth backporting the test fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #8143 to
cloud/1.39Automatically created by backport workflow.
┆Issue is synchronized with this Notion page by Unito