Skip to content

Comments

[backport core/1.39] fix: sync node.imgs for legacy context menu in Vue Nodes mode#8969

Closed
comfy-pr-bot wants to merge 2 commits intocore/1.39from
backport-8143-to-core-1.39
Closed

[backport core/1.39] fix: sync node.imgs for legacy context menu in Vue Nodes mode#8969
comfy-pr-bot wants to merge 2 commits intocore/1.39from
backport-8143-to-core-1.39

Conversation

@comfy-pr-bot
Copy link
Member

@comfy-pr-bot comfy-pr-bot commented Feb 19, 2026 •
edited by sync-by-unito bot
Loading

Backport of #8143 to core/1.39

Automatically created by backport workflow.

┆Issue is synchronized with this Notion page by Unito

@christian-byrne @ampcode-com @github-actions
fix: sync node.imgs for legacy context menu in Vue Nodes mode (#8143)
d40e33f 
## Summary

Fixes missing "Copy Image", "Open Image", "Save Image", and "Open in
Mask Editor" context menu options on SaveImage nodes when Vue Nodes mode
is enabled.

## Changes

- Add `syncLegacyNodeImgs` store method to sync loaded image elements to
`node.imgs`
- Call sync on image load in ImagePreview component
- Simplify mask editor handling to call composable directly

## Technical Details

- Only runs when `vueNodesMode` is enabled (no impact on legacy mode)
- Reuses already-loaded `<img>` element from Vue (no duplicate network
requests)
- Store owns the sync logic, component just hands off the element

Supersedes #7416

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8143-fix-sync-node-imgs-for-legacy-context-menu-in-Vue-Nodes-mode-2ec6d73d365081c59d42cd1722779b61)
by [Unito](https://www.unito.io)

---------

Co-authored-by: Amp <amp@ampcode.com>
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Feb 19, 2026
@comfy-pr-bot comfy-pr-bot requested a review from a team as a code owner February 19, 2026 00:35
@comfy-pr-bot comfy-pr-bot mentioned this pull request Feb 19, 2026
Merged
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Feb 19, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 19, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch backport-8143-to-core-1.39

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Feb 19, 2026 •
edited
Loading

🎨 Storybook Build Status

✅ Build completed successfully!

⏰ Completed at: 02/19/2026, 03:32:09 AM UTC

🔗 Links

🎉 Your Storybook is ready for review!

@github-actions
Copy link

github-actions bot commented Feb 19, 2026 •
edited
Loading

Playwright: ❌ 521 passed, 2 failed · 2 flaky

❌ Failed Tests

📊 Browser Reports
  • chromium: View Report (✅ 509 / ❌ 2 / ⚠️ 2 / ⏭️ 8)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 9 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

@christian-byrne
fix: remove unused ts-expect-error and fix flaky drag test
2e8cb23 
- Remove stale @ts-expect-error in imagePreviewStore.test.ts (createMockNode
  now accepts Record<string, unknown> so animatedImages is valid)
- Add waitFor + nextFrame in interaction.spec.ts beforeEach to let canvas
  settle after UseNewMenu layout shift

Amp-Thread-ID: https://ampcode.com/threads/T-019c7313-f15a-707b-94a5-33f473a8dad5
@christian-byrne
Copy link
Contributor

christian-byrne commented Feb 22, 2026

Too late to go on 1.39 anyway so not worth backporting the test fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport Backporting a PR onto a release candidate size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@comfy-pr-bot @christian-byrne