Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
95 commits
Select commit Hold shift + click to select a range
f7924e7
feat: synthetic widgets getter for SubgraphNode (proxy-widget-v2 phas…
DrJKL Feb 13, 2026
8a4df6d
refactor: simplify _setWidget — replace stub creation with promotion …
DrJKL Feb 13, 2026
9d44b26
refactor: simplify registration and cleanup (proxy-widget-v2 phase 4)
DrJKL Feb 13, 2026
026f2cd
refactor: Phase 5 — removeWidget override and serialize verification
DrJKL Feb 13, 2026
01021ca
test: Phase 6 — add promotedWidgetView and widgets getter tests
DrJKL Feb 13, 2026
7065f74
fix: preserve custom widgets getter in extractVueNodeData (Phase 7)
DrJKL Feb 13, 2026
6bdaa9e
feat: DOM widget promotion for subgraph nodes
DrJKL Feb 14, 2026
bab4589
fix: unexport unused PositionOverride interface
DrJKL Feb 14, 2026
03f369c
fix: use graph reference equality for subgraph widget override
DrJKL Feb 14, 2026
b5ad47c
fix: unpromote widget when connected to SubgraphInput
DrJKL Feb 14, 2026
335da2a
fix: use input._widget directly in input-disconnected to avoid ambigu…
DrJKL Feb 14, 2026
75ea83a
fix: navigateIntoSubgraph clicks title button instead of dblclick on …
DrJKL Feb 14, 2026
e3c04a8
fix: cache promoted widget views, use standard prototype, revert nav …
DrJKL Feb 14, 2026
b7eda37
feat: add usePromotionStore as reactive source of truth for widget pr…
DrJKL Feb 14, 2026
31d1ead
refactor: address review findings from promotionStore migration
DrJKL Feb 14, 2026
db18663
fix: add dev warning for SubgraphNode widgets setter no-op
DrJKL Feb 14, 2026
3be951e
fix: add Pinia setup to Subgraph GC tests
DrJKL Feb 14, 2026
98ef63a
refactor: remove widget.promoted, query promotionStore directly
DrJKL Feb 14, 2026
445287a
refactor: delete proxyWidget.ts, move listener to canvasStore
DrJKL Feb 14, 2026
ffd65c6
fix: promoted DOM widget selection and value sync in subgraphs
DrJKL Feb 14, 2026
6786160
fix: only show promoted widget border on original node
DrJKL Feb 14, 2026
3ada330
[automated] Update test expectations
invalid-email-address Feb 14, 2026
3eab106
fix: reduce complexity in subgraph promotion system
DrJKL Feb 14, 2026
e91251a
fix: use importOriginal in litegraph mock for useSelectedLiteGraphIte…
DrJKL Feb 14, 2026
0b6abca
test: Try just using the button before double clicking to enter subgr…
DrJKL Feb 14, 2026
294f09a
Merge remote-tracking branch 'origin/main' into drjkl/subgraphs-are-t…
DrJKL Feb 14, 2026
f0a8779
refactor: extract isPromotedWidgetView type guard to promotedWidgetVi…
DrJKL Feb 14, 2026
147852c
fix: extract PromotedWidgetView type guard to leaf module to break ci…
DrJKL Feb 14, 2026
1a614cb
[automated] Apply ESLint and Oxfmt fixes
actions-user Feb 14, 2026
9412e41
fix: make promotion store reactive and remove mutable widget state
DrJKL Feb 15, 2026
2bc240f
feat: promoted widget interaction, preview rendering, and image uploa…
DrJKL Feb 16, 2026
507b50c
test: refactor usePromotedPreviews tests
DrJKL Feb 16, 2026
e86075a
[automated] Apply ESLint and Oxfmt fixes
actions-user Feb 16, 2026
0c0c2b0
feat: audio preview support and generalized preview widget detection
DrJKL Feb 16, 2026
d380e10
WIP: Promotion Playwright tests
DrJKL Feb 16, 2026
e7f0567
[automated] Apply ESLint and Oxfmt fixes
actions-user Feb 16, 2026
6b7ed99
feat: add subgraph promoted widget support to WidgetLegacy
DrJKL Feb 17, 2026
480634f
fix: rebind legacy widget on graph and mode transitions
DrJKL Feb 17, 2026
43f9e97
fix: ensure SaveImage node is on-screen before context menu click
DrJKL Feb 17, 2026
9291a6f
fix: improve subgraph promotion reliability and test selectors
DrJKL Feb 17, 2026
fbf552a
fix: resolve test init error in usePromotedPreviews
DrJKL Feb 17, 2026
1b72c9d
fix: fix Manual Promote/Demote e2e tests
DrJKL Feb 17, 2026
7776091
fix: improve flex layout for media preview components
DrJKL Feb 17, 2026
0df58d6
fix: forward suppressPromotedOutline in widget drawWidget methods
DrJKL Feb 17, 2026
fbd36bc
fix: defaulting to the first value. Was handled both here and in the …
DrJKL Feb 18, 2026
c059477
Merge remote-tracking branch 'origin/main' into drjkl/subgraphs-are-t…
DrJKL Feb 18, 2026
01110bf
[automated] Update test expectations
invalid-email-address Feb 19, 2026
d1576ea
Merge remote-tracking branch 'origin/main' into drjkl/subgraphs-are-t…
DrJKL Feb 19, 2026
5010df9
merge: resolve conflicts with origin/main
DrJKL Feb 20, 2026
c878c2d
Merge branch 'main' into drjkl/subgraphs-are-the-best
DrJKL Feb 21, 2026
5ff428b
fix: address subgraph promotion review findings
DrJKL Feb 21, 2026
72e11b4
Merge remote-tracking branch 'origin/main' into drjkl/subgraphs-are-t…
DrJKL Feb 21, 2026
077c8f9
fix: review cleanup for proxy-widget-v2
DrJKL Feb 21, 2026
a6ceaa4
Revert node dragged
DrJKL Feb 21, 2026
3fe786f
test: Explicit tests around legacy data
DrJKL Feb 21, 2026
b417abd
fix: assign graph before widget node binding
DrJKL Feb 21, 2026
8a6e291
feat: scope widget value state by root graph id
DrJKL Feb 21, 2026
899c4de
feat: scope promotion state by root graph id
DrJKL Feb 21, 2026
1c3803c
fix: clear graph-scoped stores during root graph reset
DrJKL Feb 21, 2026
a37f835
fix: preserve subgraph widget promotions when pasting
DrJKL Feb 21, 2026
3eec4d5
fix: preserve promoted seed control augmentation
DrJKL Feb 21, 2026
2ddf232
fix: address remaining pr8856 review follow-ups
DrJKL Feb 21, 2026
c9d6ec9
test: enable image preview specs and fix browser typings
DrJKL Feb 21, 2026
8e4a7dd
ci: run browser typecheck for browser_tests changes
DrJKL Feb 21, 2026
ecdfdf7
fix: stabilize playwright regressions in image and flaky flows
DrJKL Feb 22, 2026
db4e8eb
fix: stabilize subgraph promoted preview widget behavior
DrJKL Feb 22, 2026
3d98c16
Merge remote-tracking branch 'origin/main' into drjkl/subgraphs-are-t…
DrJKL Feb 22, 2026
76965b9
[automated] Apply ESLint and Oxfmt fixes
actions-user Feb 22, 2026
8160a34
fix: preserve promoted widget behavior and dom widget ordering
DrJKL Feb 22, 2026
bb5901a
test: add subgraph promoted preview coverage
DrJKL Feb 22, 2026
a1c611f
test: consolidate proxyWidgets tuple guards
DrJKL Feb 22, 2026
134337b
[automated] Update test expectations
invalid-email-address Feb 22, 2026
e9ddacc
refactor: simplify promoted widget view implementation
DrJKL Feb 22, 2026
e311b4b
refactor: apply tdd simplification slices for subgraph widgets
DrJKL Feb 22, 2026
ce0661c
fix: keep promoted widget resolver types internal
DrJKL Feb 22, 2026
c23f68e
test: format promoted image preview browser spec
DrJKL Feb 22, 2026
5cb11f7
[automated] Apply ESLint and Oxfmt fixes
actions-user Feb 22, 2026
3d78e2e
[automated] Update test expectations
invalid-email-address Feb 22, 2026
1261ea4
refactor: rename proxy widget browser helpers to promoted widget naming
DrJKL Feb 22, 2026
302f5f1
fix: remove unsafe type-checker evasions in promoted widget flow
DrJKL Feb 22, 2026
3c768c5
fix: centralize node root graph id resolution
DrJKL Feb 22, 2026
4597ce5
test: reference production types in test files to prevent structural …
DrJKL Feb 22, 2026
bae652b
refactor: centralize promoted widget source resolution
DrJKL Feb 22, 2026
3325070
refactor: remove casts from promoted widget resolution
DrJKL Feb 22, 2026
1bb1b0a
fix: keep promoted widget source type internal
DrJKL Feb 22, 2026
f26478d
fix: use getNodeCount() to avoid CDP serialization failure
DrJKL Feb 22, 2026
efce3a9
refactor: rename proxy widget files to promoted widget naming
DrJKL Feb 23, 2026
d6fe2de
chore: dedupe pnpm-lock.yaml
DrJKL Feb 23, 2026
79f65d4
fix: remove redundant cache check and harden E2E serialization test
DrJKL Feb 23, 2026
9fe2c05
fix: build SimplifiedWidget explicitly in RSP WidgetItem
DrJKL Feb 23, 2026
ad3f671
Merge branch 'main' into drjkl/subgraphs-are-the-best
DrJKL Feb 23, 2026
cbb7fcc
Merge branch 'main' of ssh://github.com/Comfy-Org/ComfyUI_frontend in…
DrJKL Feb 23, 2026
24d609e
[automated] Update test expectations
invalid-email-address Feb 23, 2026
b1f0ccb
fix: align getPromotedWidgetCount with its name and use test-id selec…
DrJKL Feb 23, 2026
3a1f242
Merge branch 'main' into drjkl/subgraphs-are-the-best
DrJKL Feb 23, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/workflows/ci-lint-format.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,14 @@ jobs:
- name: Setup frontend
uses: ./.github/actions/setup-frontend

- name: Detect browser_tests changes
id: changed-paths
uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
with:
filters: |
browser_tests:
- 'browser_tests/**'

- name: Run ESLint with auto-fix
run: pnpm lint:fix

Expand Down Expand Up @@ -60,6 +68,10 @@ jobs:
pnpm format:check
pnpm knip

- name: Typecheck browser tests
if: steps.changed-paths.outputs.browser_tests == 'true'
run: pnpm typecheck:browser

- name: Comment on PR about auto-fix
if: steps.verify-changed-files.outputs.changed == 'true' && github.event.pull_request.head.repo.full_name == github.repository
continue-on-error: true
Expand Down
4 changes: 4 additions & 0 deletions AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,10 @@ See @docs/guidance/\*.md for file-type-specific conventions (auto-loaded by glob

The project uses **Nx** for build orchestration and task management

## Package Manager

This project uses **pnpm**. Always prefer scripts defined in `package.json` (e.g., `pnpm test:unit`, `pnpm lint`). To run arbitrary packages not in scripts, use `pnpx` or `pnpm dlx` — never `npx`.

## Build, Test, and Development Commands

- `pnpm dev`: Start Vite dev server.
Expand Down
Loading
Loading