Skip to content

feat: add clear pending tasks button in actionbar2#8806

Open
henrikvilhelmberglund wants to merge 1 commit intoComfy-Org:mainfrom
henrikvilhelmberglund:feat-clear-pending-tasks-button-in-actionbar2
Open

feat: add clear pending tasks button in actionbar2#8806
henrikvilhelmberglund wants to merge 1 commit intoComfy-Org:mainfrom
henrikvilhelmberglund:feat-clear-pending-tasks-button-in-actionbar2

Conversation

@henrikvilhelmberglund
Copy link

@henrikvilhelmberglund henrikvilhelmberglund commented Feb 11, 2026

I was told to resend the PR (I think? message was a bit cryptic...) so here it is.

Original PR: #7617

Summary

This PR brings back the Clear Pending Tasks button in the actionbar. (Setting in Queue, defaults to false)

Changes

  • What: Clear Pending Tasks button added in the actionbar.

Review Focus

Fixes #7319 #7282 #7133

Screenshots (if applicable)

image

┆Issue is synchronized with this Notion page by Unito

commit 3338692
Author: henrikvilhelmberglund <henrikvilhelmberglund@gmail.com>
Date:   Wed Feb 11 16:07:34 2026 +0100

    fix: move setting from menu to queue

commit 22092aa
Merge: 614bd45 28b1711
Author: henrikvilhelmberglund <henrikvilhelmberglund@gmail.com>
Date:   Wed Feb 11 15:41:43 2026 +0100

    Merge branch 'feat-clear-pending-tasks-button-in-actionbar' of https://github.com/henrikvilhelmberglund/ComfyUI_frontend; branch 'main' of https://github.com/Comfy-Org/ComfyUI_frontend into feat-clear-pending-tasks-button-in-actionbar

commit 614bd45
Merge: 8aa74b2 ed7ec2a
Author: Benjamin Lu <benjaminlu1107@gmail.com>
Date:   Fri Dec 19 07:11:47 2025 -0800

    Merge remote-tracking branch 'origin/main' into feat-clear-pending-tasks-button-in-actionbar

commit 8aa74b2
Author: Benjamin Lu <benjaminlu1107@gmail.com>
Date:   Thu Dec 18 18:07:38 2025 -0800

    Gate with setting and rely on hasPendingTasks

commit 20ec7f5
Author: Benjamin Lu <benjaminlu1107@gmail.com>
Date:   Thu Dec 18 17:53:07 2025 -0800

    Remove unneeded comment

commit 639bc19
Author: Benjamin Lu <benjaminlu1107@gmail.com>
Date:   Thu Dec 18 17:51:26 2025 -0800

    Format

commit 3d2bc51
Merge: 2402b63 9a35fa9
Author: Benjamin Lu <benjaminlu1107@gmail.com>
Date:   Thu Dec 18 17:50:30 2025 -0800

    Merge remote-tracking branch 'origin/main' into feat-clear-pending-tasks-button-in-actionbar

commit 2402b63
Merge: e826b40 7e011da
Author: Henrik Berglund <110549389+henrikvilhelmberglund@users.noreply.github.com>
Date:   Thu Dec 18 23:01:55 2025 +0100

    Merge branch 'main' into feat-clear-pending-tasks-button-in-actionbar

commit e826b40
Author: henrikvilhelmberglund <henrikvilhelmberglund@gmail.com>
Date:   Thu Dec 18 16:59:51 2025 +0100

    fix: remove text attribute

commit b7165e0
Author: henrikvilhelmberglund <henrikvilhelmberglund@gmail.com>
Date:   Thu Dec 18 16:30:46 2025 +0100

    fix: remove redundant check

commit 06dec0c
Author: henrikvilhelmberglund <henrikvilhelmberglund@gmail.com>
Date:   Thu Dec 18 16:08:41 2025 +0100

    feat: add clear pending tasks button in actionbar
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Feb 11, 2026
@github-actions
Copy link

🎨 Storybook Build Status

loading Build is starting...

⏰ Started at: 02/11/2026, 03:25:52 PM UTC

🚀 Building Storybook

  • 📦 Installing dependencies...
  • 🔧 Building Storybook components...
  • 🌐 Preparing deployment to Cloudflare Pages...

⏱️ Please wait while the Storybook build is in progress...

@github-actions
Copy link

🎭 Playwright Tests: ⏳ Running...

Tests started at 02/11/2026, 03:25:53 PM UTC

📊 Browser Tests
  • chromium: Running...
  • chromium-0.5x: Running...
  • chromium-2x: Running...
  • mobile-chrome: Running...

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 11, 2026

📝 Walkthrough

Walkthrough

This PR introduces a new configurable "Clear Pending Tasks" button to the action bar. The feature adds a setting to toggle button visibility, integrates the queue store to track pending task state, provides localization strings, and extends the settings schema for type safety.

Changes

Cohort / File(s) Summary
Component Implementation
src/components/actionbar/ComfyActionbar.vue
Adds Clear Pending Tasks action button integrated with queue store. Button displays when setting enabled and pending tasks exist, executing the Comfy.ClearPendingTasks command on click with custom tooltip configuration.
Settings Configuration
src/platform/settings/constants/coreSettings.ts
Introduces new boolean core setting Comfy.Queue.ShowClearPendingTasksButton with id, category, default value (false), name, and tooltip for controlling button visibility.
Localization & Schema
src/locales/en/settings.json, src/schemas/apiSchema.ts
Adds English translation entry and Zod schema validation for the new ShowClearPendingTasksButton setting.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A button returns with a pending task's might,
To clear the queue with a click so right,
Settings in place, both hidden and shown,
The action bar shines with features well-known! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: adding a Clear Pending Tasks button to the actionbar.
Linked Issues check ✅ Passed The PR successfully restores the Clear Pending Tasks button functionality requested in issue #7319, implementing it as a configurable Queue setting that defaults to false.
Out of Scope Changes check ✅ Passed All changes are focused on implementing the Clear Pending Tasks button feature. No unrelated modifications were detected in the component, localization, settings schema, or API schema.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The PR description follows the required template structure with Summary, Changes, and Review Focus sections. References to issues and a screenshot are included as applicable.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clear All Queue button missing after updating to v0.4.0 — was this intentional? Need this feature back

2 participants