fix: address review nits in load3d #8779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
Contributor
📝 WalkthroughWalkthroughReplaces forced-type handling in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 02/10/2026, 08:58:47 PM UTC 🔗 Links🎉 Your Storybook is ready for review! |
|
Playwright: ✅ 523 passed, 0 failed · 2 flaky 📊 Browser Reports
|
DrJKL
reviewed
Feb 10, 2026
src/composables/useLoad3d.ts
Outdated
Comment on lines
227
to
231
| const type = hasOutputSuffix | ||
| ? 'output' | ||
| : isPreview.value | ||
| ? 'output' | ||
| : 'input' |
Contributor
There was a problem hiding this comment.
Suggested change
| const type = hasOutputSuffix | |
| ? 'output' | |
| : isPreview.value | |
| ? 'output' | |
| : 'input' | |
| const type = hasOutputSuffix || isPreview.value | |
| ? 'output' | |
| : 'input' |
DrJKL
reviewed
Feb 10, 2026
src/composables/useLoad3d.ts
Outdated
| const trimmed = modelPath.trim() | ||
| const hasOutputSuffix = trimmed.endsWith('[output]') | ||
| const cleanPath = hasOutputSuffix | ||
| ? trimmed.replace(/\s*\[output\]$/, '').trim() |
Contributor
There was a problem hiding this comment.
I think the \s* should handle the trimming for you.
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 22.2 kB (baseline 22.2 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 855 kB (baseline 855 kB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 68.8 kB (baseline 68.8 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed Panels & Settings — 451 kB (baseline 451 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed User & Accounts — 16 kB (baseline 16 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 5 added / 5 removed Editors & Dialogs — 751 B (baseline 751 B) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 1 added / 1 removed UI Components — 36.6 kB (baseline 36.6 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed Data & Services — 2.12 MB (baseline 2.12 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 12 added / 12 removed Utilities & Hooks — 237 kB (baseline 237 kB) • 🔴 +14 BHelpers, composables, and utility bundles
Status: 14 added / 14 removed Vendor & Third-Party — 8.77 MB (baseline 8.77 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 7.21 MB (baseline 7.21 MB) • 🔴 +40 BBundles that do not match a named category
Status: 60 added / 60 removed |
DrJKL
reviewed
Feb 10, 2026
| forcedType ?? (isPreview.value ? 'output' : 'input') | ||
| ) | ||
| ) | ||
| return api.apiURL(Load3dUtils.getResourceURL(subfolder, filename, type)) |
jtydhr88
force-pushed
the
fix/load3d-review-nits
branch
from
b0949f6 to
203c674
Compare
DrJKL
approved these changes
Feb 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
improve for #8765
┆Issue is synchronized with this Notion page by Unito