fix(vueNodes): decrease default size of reroute nodes#8734
Draft
christian-byrne wants to merge 1 commit intomainfrom
Draft
fix(vueNodes): decrease default size of reroute nodes#8734christian-byrne wants to merge 1 commit intomainfrom
christian-byrne wants to merge 1 commit intomainfrom
Conversation
Remove the 225px minimum width constraint from reroute nodes so they render at their intended ~75×26px size from computeSize(). - Add isRerouteNode computed to conditionally bypass min-w-[225px] - Set resizable: false on RerouteNode to hide resize handle - Remove bottom padding for compact reroute layout - Add unit and E2E tests for reroute sizing Fixes #4704 Amp-Thread-ID: https://ampcode.com/threads/T-019c3b35-927e-720b-9a24-0eb509300bfb
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 02/08/2026, 03:11:54 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
🎭 Playwright Tests:
|
Contributor
📝 WalkthroughWalkthroughThe pull request reduces reroute node size by making them non-resizable, removing default minimum width constraints for reroute-type nodes, and preventing resize handle rendering. Supporting tests validate sizing behavior. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 22.2 kB (baseline 22.2 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 854 kB (baseline 854 kB) • 🔴 +127 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 69 kB (baseline 69 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed Panels & Settings — 409 kB (baseline 409 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed User & Accounts — 16.1 kB (baseline 16.1 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 5 added / 5 removed Editors & Dialogs — 781 B (baseline 781 B) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 1 added / 1 removed UI Components — 36.6 kB (baseline 36.6 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed Data & Services — 2.11 MB (baseline 2.11 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 12 added / 12 removed Utilities & Hooks — 237 kB (baseline 237 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 12 added / 12 removed Vendor & Third-Party — 8.77 MB (baseline 8.77 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 7.15 MB (baseline 7.15 MB) • 🔴 +28 BBundles that do not match a named category
Status: 54 added / 54 removed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the 225px minimum width constraint from reroute nodes so they render at their intended ~75×26px size.
Changes
min-w-[225px]CSS constraint and bottom padding applied to regular nodes.resizable: falseis set on the RerouteNode constructor to hide the resize handle. AnisRerouteNodecomputed inLGraphNode.vuegates these behaviors by checkingnodeData.type === "Reroute".Review Focus
type === "Reroute"(explicit) rather thantitleMode === NO_TITLE(semantic but too broad). See PR fix(vue-nodes): hide slot labels for reroute nodes with empty names #8574 as prior art for reroute-specific conditionals.LGraphNode.tspos/size setters but does not touchLGraphNode.vuetemplate or resize callback — no conflict expected.Fixes #4704
Screenshots (if applicable)
Reroute nodes now render at ~75px wide instead of being forced to 225px minimum.
┆Issue is synchronized with this Notion page by Unito