Conversation
dosubot
bot
added
the
size:XS
🎭 Playwright Tests:
|
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 02/07/2026, 07:01:58 PM UTC 🔗 Links🎉 Your Storybook is ready for review! |
Contributor
📝 WalkthroughWalkthroughA single file was modified to set Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 22.2 kB (baseline 22.2 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 854 kB (baseline 854 kB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 69 kB (baseline 69 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed Panels & Settings — 409 kB (baseline 409 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed User & Accounts — 16.1 kB (baseline 16.1 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 5 added / 5 removed Editors & Dialogs — 781 B (baseline 781 B) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 1 added / 1 removed UI Components — 36.7 kB (baseline 36.7 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed Data & Services — 2.11 MB (baseline 2.11 MB) • 🔴 +53 BStores, services, APIs, and repositories
Status: 12 added / 12 removed Utilities & Hooks — 237 kB (baseline 237 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 12 added / 12 removed Vendor & Third-Party — 8.77 MB (baseline 8.77 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 7.15 MB (baseline 7.15 MB) • ⚪ 0 BBundles that do not match a named category
Status: 54 added / 54 removed |
jtydhr88
force-pushed
the
fix/image-compare-exclude-urls-from-workflow
branch
from
db0d57b to
ad5c5c0
Compare
Collaborator
Author
|
I don't think the failure test caused by my changes |
christian-byrne
approved these changes
Feb 7, 2026
DrJKL
reviewed
Feb 7, 2026
Comment on lines
+18
to
+19
| // widget.serialize controls workflow persistence; widget.options.serialize | ||
| // controls prompt (API) serialization — only disable the former. |
Contributor
There was a problem hiding this comment.
Nit: I don't know that we need the comment, but this is something I'll keep in mind in the WidgetStore work. We shouldn't have options like this at different levels.
Suggested change
| // widget.serialize controls workflow persistence; widget.options.serialize | |
| // controls prompt (API) serialization — only disable the former. |
DrJKL
approved these changes
Feb 7, 2026
christian-byrne
added a commit
that referenced
this pull request
Mar 26, 2026
Coverage for 10 bug gaps identified during deep persistence audit: CRITICAL: - PR #9531: Workflow data corruption from checkState during graph loading (pythongosssss fix — had ZERO tests, now covered with 2 tests) - PR #9533: Desynced workflow/graph state during rapid tab switching MEDIUM: - PR #9380: Node output previews lost on tab switch - 44bb6f1: Canvas not cleared before loading new workflow - PR #7648: Widget values lost on graph change - PR #9694: API format workflows fail with missing nodes - PR #8259: Middle-click paste duplicates workflow - PR #8715: Transient blob: URLs in serialization LOW: - PR #8963: Locale change breaks workflows - Splitter panel size drift All tests use Vue nodes with new menu enabled. Each test documents which PR/commit it regresses and reproduces the exact user scenario. Part of: Test Coverage Q2 Overhaul (REG-01)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Image URLs set by onExecuted are execution results that don't exist on other machines. Disable workflow persistence (widget.serialize) while keeping prompt serialization (widget.options.serialize) so compare_view is still sent to the backend.
┆Issue is synchronized with this Notion page by Unito