-
Notifications
You must be signed in to change notification settings - Fork 491
fix: increase active node border weight from 2 to 3 #8654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Increase stroke/outline weight for active node states (running, execution error) to improve visibility during workflow execution. - Vue Nodes: outline-2 → outline-3 - LiteGraph: running stroke lineWidth 1 → 3, executionError 2 → 3 - Update test assertion to match new outline class Amp-Thread-ID: https://ampcode.com/threads/T-019c2f8f-c201-72fb-9a86-20949487e95e
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 02/06/2026, 12:25:46 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
📝 WalkthroughWalkthroughNode visualization styling updates across components and service layer. Hover outline thickness increases from outline-2 to outline-3 in Tailwind CSS, and stroke line widths become explicit in the running and error states (width 3), with corresponding test updates. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
🎭 Playwright Tests:
|
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 22.5 kB (baseline 22.5 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 840 kB (baseline 840 kB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 69 kB (baseline 69 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed Panels & Settings — 410 kB (baseline 410 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 12 added / 12 removed User & Accounts — 16 kB (baseline 16 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 5 added / 5 removed Editors & Dialogs — 3.47 kB (baseline 3.47 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 2 added / 2 removed UI Components — 37.8 kB (baseline 37.8 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed Data & Services — 2.1 MB (baseline 2.1 MB) • 🔴 +25 BStores, services, APIs, and repositories
Status: 11 added / 11 removed Utilities & Hooks — 234 kB (baseline 234 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 12 added / 12 removed Vendor & Third-Party — 9.37 MB (baseline 9.37 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 7.08 MB (baseline 7.08 MB) • ⚪ 0 BBundles that do not match a named category
Status: 49 added / 49 removed |
|
Updating Playwright Expectations |
Summary
Increase stroke/outline weight for active node states to improve visibility during workflow execution (COM-7770).
Changes
outline-2→outline-3inLGraphNode.vuelineWidth: 3forrunningstroke (was default 1) andexecutionErrorstroke (was 2) inlitegraphService.tsReview Focus
Minimal visual change. The
executionErrorlineWidth was also bumped from 2 → 3 so error states remain at least as prominent as running states.