Skip to content

fix: use distribution flags for desktop detection #8627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
benceruleanlu wants to merge 2 commits into from
Closed

fix: use distribution flags for desktop detection #8627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e38875c
fix: use distribution flags for desktop detection
benceruleanlu Feb 5, 2026
72c94e9
Fix linting
benceruleanlu Feb 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"collect-i18n": "pnpm exec playwright test --config=playwright.i18n.config.ts",
"dev:cloud": "cross-env DEV_SERVER_COMFYUI_URL='https://testcloud.comfy.org/' nx serve",
"dev:desktop": "nx dev @comfyorg/desktop-ui",
"dev:electron": "nx serve --config vite.electron.config.mts",
"dev:electron": "cross-env DISTRIBUTION=desktop nx serve --config vite.electron.config.mts",
"dev:no-vue": "cross-env DISABLE_VUE_PLUGINS=true nx serve",
"dev": "nx serve",
"devtools:pycheck": "python3 -m compileall -q tools/devtools",
Expand Down
4 changes: 1 addition & 3 deletions src/platform/cloud/subscription/components/PricingTableWorkspace.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,6 @@ import { useI18n } from 'vue-i18n'

import Button from '@/components/ui/button/Button.vue'
import { useBillingContext } from '@/composables/billing/useBillingContext'
import { t } from '@/i18n'
import {
TIER_PRICING,
TIER_TO_KEY
Expand Down Expand Up @@ -315,6 +314,7 @@ const emit = defineEmits<{
subscribe: [payload: { tierKey: CheckoutTierKey; billingCycle: BillingCycle }]
resubscribe: []
}>()
const { t, n } = useI18n()

interface BillingCycleOption {
label: string
Expand Down Expand Up @@ -369,8 +369,6 @@ const tiers: PricingTierConfig[] = [
isPopular: false
}
]

const { n } = useI18n()
const {
plans: apiPlans,
currentPlanSlug,
Expand Down
4 changes: 1 addition & 3 deletions src/platform/distribution/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import { isElectron } from '@/utils/envUtil'

/**
* Distribution types and compile-time constants for managing
* multi-distribution builds (Desktop, Localhost, Cloud)
Expand All @@ -16,7 +14,7 @@ declare global {
const DISTRIBUTION: Distribution = __DISTRIBUTION__

/** Distribution type checks */
export const isDesktop = DISTRIBUTION === 'desktop' || isElectron() // TODO: replace with build var
export const isDesktop = DISTRIBUTION === 'desktop'
export const isCloud = DISTRIBUTION === 'cloud'
// export const isLocalhost = DISTRIBUTION === 'localhost' || (!isDesktop && !isCloud)

Expand Down