Revert delay of layout initialization - #8619
Merged
Merged
Conversation
dosubot
Bot
added
the
size:XS
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 02/05/2026, 07:01:08 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
🎭 Playwright Tests:
|
Contributor
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (6)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the
📝 WalkthroughWalkthroughA timing optimization in node layout initialization removes deferred scheduling via Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 22.5 kB (baseline 22.5 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 840 kB (baseline 840 kB) • 🟢 -21 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 69 kB (baseline 69 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Panels & Settings — 410 kB (baseline 410 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
User & Accounts — 16 kB (baseline 16 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Editors & Dialogs — 3.47 kB (baseline 3.47 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
UI Components — 37.8 kB (baseline 37.8 kB) • ⚪ 0 BReusable component library chunks
Data & Services — 2.1 MB (baseline 2.1 MB) • ⚪ 0 BStores, services, APIs, and repositories
Utilities & Hooks — 234 kB (baseline 234 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Vendor & Third-Party — 9.37 MB (baseline 9.37 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 7.08 MB (baseline 7.08 MB) • ⚪ 0 BBundles that do not match a named category
|
DrJKL
added
New Browser Test Expectations
|
Updating Playwright Expectations |
github-actions
Bot
removed
the
New Browser Test Expectations
DrJKL
approved these changes
Feb 5, 2026
snomiao
pushed a commit
that referenced
this pull request
Feb 6, 2026
#7591 added a one tick delay to layout initialization in an attempt to resolve some layouting discrepancies. However, it appears to have reintroduced node scaling issues and introduced a new bug that prevents cloning nodes with alt+drag in vue. Alternatives methods of resolving the original issue are being investigated, but this change was causing more harm than good. The prior PR included other changes (like a testing fix). Those changes remain beneficial and do not need to be reverted. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-8619-Revert-delay-of-layout-initialization-2fe6d73d365081fc9111c9457ea9752d) by [Unito](https://www.unito.io) --------- Co-authored-by: github-actions <github-actions@github.com>
DrJKL
added
needs-backport
|
|
|
|
zeekay
pushed a commit
to hanzoui/frontend
that referenced
this pull request
Jul 26, 2026
Comfy-Org#7591 added a one tick delay to layout initialization in an attempt to resolve some layouting discrepancies. However, it appears to have reintroduced node scaling issues and introduced a new bug that prevents cloning nodes with alt+drag in vue. Alternatives methods of resolving the original issue are being investigated, but this change was causing more harm than good. The prior PR included other changes (like a testing fix). Those changes remain beneficial and do not need to be reverted. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-8619-Revert-delay-of-layout-initialization-2fe6d73d365081fc9111c9457ea9752d) by [Unito](https://www.unito.io) --------- Co-authored-by: github-actions <github-actions@github.com>
dante01yoon
pushed a commit
that referenced
this pull request
Jul 27, 2026
#7591 added a one tick delay to layout initialization in an attempt to resolve some layouting discrepancies. However, it appears to have reintroduced node scaling issues and introduced a new bug that prevents cloning nodes with alt+drag in vue. Alternatives methods of resolving the original issue are being investigated, but this change was causing more harm than good. The prior PR included other changes (like a testing fix). Those changes remain beneficial and do not need to be reverted. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-8619-Revert-delay-of-layout-initialization-2fe6d73d365081fc9111c9457ea9752d) by [Unito](https://www.unito.io) --------- Co-authored-by: github-actions <github-actions@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#7591 added a one tick delay to layout initialization in an attempt to resolve some layouting discrepancies. However, it appears to have reintroduced node scaling issues and introduced a new bug that prevents cloning nodes with alt+drag in vue.
Alternatives methods of resolving the original issue are being investigated, but this change was causing more harm than good.
The prior PR included other changes (like a testing fix). Those changes remain beneficial and do not need to be reverted.
┆Issue is synchronized with this Notion page by Unito