-
Notifications
You must be signed in to change notification settings - Fork 491
fix: display active jobs in oldest-first order in media assets panel #8561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Active jobs (pending/running) in the media assets panel now display in FIFO order - oldest jobs first, matching queue processing order. This reverts the display order for active jobs while keeping completed/history jobs in newest-first order. Fixes COM-14151 Amp-Thread-ID: https://ampcode.com/threads/T-019c2127-44b5-70bc-b01e-8f59f48b8939
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 02/03/2026, 01:46:27 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
🎭 Playwright Tests:
|
📝 WalkthroughWalkthroughChanges reverse the order of active job items in the assets sidebar components to display them in oldest-first (FIFO) order, with comprehensive unit tests verifying the ordering and job state filtering behavior. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 26.1 kB (baseline 26.1 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 978 kB (baseline 978 kB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 80.7 kB (baseline 80.7 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed Panels & Settings — 496 kB (baseline 496 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 13 added / 13 removed User & Accounts — 3.94 kB (baseline 3.94 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 3 added / 3 removed Editors & Dialogs — 2.92 kB (baseline 2.92 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 2 added / 2 removed UI Components — 33.7 kB (baseline 33.7 kB) • ⚪ 0 BReusable component library chunks
Status: 4 added / 4 removed Data & Services — 2.72 MB (baseline 2.72 MB) • 🔴 +26 BStores, services, APIs, and repositories
Status: 8 added / 8 removed Utilities & Hooks — 25.5 kB (baseline 25.5 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 7 added / 7 removed Vendor & Third-Party — 10.7 MB (baseline 10.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 7.2 MB (baseline 7.2 MB) • ⚪ 0 BBundles that do not match a named category
Status: 36 added / 36 removed |
Summary
Active jobs (pending/running) in the media assets panel now display in FIFO order - oldest jobs first (first to be processed at top). This matches the queue processing order and the old queue panel behavior.
Changes
.toReversed()toactiveJobItemscomputed to reverse job order for displayRoot Cause
PR #8225 changed sorting from
queueIndextocreateTimedescending inuseJobList.ts, which placed newest jobs first. For active jobs, users expect oldest first (FIFO - first to be processed appears at top).Solution
Rather than modifying the shared
useJobListcomposable (which serves both the assets panel and queue overlay), the fix applies.toReversed()at the view layer for the active jobs section only. This:Testing
useJobListtests passFixes COM-14151
Summary by CodeRabbit
Bug Fixes
Tests
┆Issue is synchronized with this Notion page by Unito