fix: localize node definition filter names and descriptions#8540
Merged
christian-byrne merged 1 commit intomainfrom Feb 2, 2026
Merged
fix: localize node definition filter names and descriptions#8540christian-byrne merged 1 commit intomainfrom
christian-byrne merged 1 commit intomainfrom
Conversation
Replace hardcoded English strings in registerCoreNodeDefFilters() with vue-i18n t() function calls. Add corresponding translation keys to src/locales/en/main.json under the nodeFilters namespace. Fixes #8390 Amp-Thread-ID: https://ampcode.com/threads/T-019c1d07-a51f-749b-bab9-07abd9ed63c4
dosubot
bot
added
the
size:S
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 02/02/2026, 06:58:09 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
🎭 Playwright Tests:
|
Contributor
📝 WalkthroughWalkthroughThis PR adds internationalization support to node definition filters by introducing localization entries in the English locale file and updating the node definition store to use translation keys instead of hardcoded English strings for filter names and descriptions. Changes
Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 26 kB (baseline 26 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 978 kB (baseline 978 kB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 80.7 kB (baseline 80.7 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed Panels & Settings — 471 kB (baseline 471 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 12 added / 12 removed User & Accounts — 3.94 kB (baseline 3.94 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 3 added / 3 removed Editors & Dialogs — 2.89 kB (baseline 2.89 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 2 added / 2 removed UI Components — 33.7 kB (baseline 33.7 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed Data & Services — 2.71 MB (baseline 2.71 MB) • 🟢 -34 BStores, services, APIs, and repositories
Status: 8 added / 8 removed Utilities & Hooks — 25.3 kB (baseline 25.3 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 7 added / 7 removed Vendor & Third-Party — 10.7 MB (baseline 10.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 7.17 MB (baseline 7.17 MB) • 🔴 +596 BBundles that do not match a named category
Status: 38 added / 38 removed |
Myestery
approved these changes
Feb 2, 2026
AustinMroz
added
needs-backport
|
|
|
|
AustinMroz
pushed a commit
that referenced
this pull request
Feb 3, 2026
Localizes node definition filter names and descriptions using vue-i18n, following the project's coding guidelines. - Updated `registerCoreNodeDefFilters()` in `src/stores/nodeDefStore.ts` to use `t()` function calls - Added translation keys under `nodeFilters` namespace in `src/locales/en/main.json` | Filter ID | Name | |-----------|------| | `core.deprecated` | Hide Deprecated Nodes | | `core.experimental` | Hide Experimental Nodes | | `core.dev_only` | Hide Dev-Only Nodes | | `core.subgraph` | Hide Subgraph Nodes | Fixes #8390 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-8540-fix-localize-node-definition-filter-names-and-descriptions-2fb6d73d365081f29506ed804c233b5a) by [Unito](https://www.unito.io)
AustinMroz
pushed a commit
that referenced
this pull request
Feb 3, 2026
Localizes node definition filter names and descriptions using vue-i18n, following the project's coding guidelines. - Updated `registerCoreNodeDefFilters()` in `src/stores/nodeDefStore.ts` to use `t()` function calls - Added translation keys under `nodeFilters` namespace in `src/locales/en/main.json` | Filter ID | Name | |-----------|------| | `core.deprecated` | Hide Deprecated Nodes | | `core.experimental` | Hide Experimental Nodes | | `core.dev_only` | Hide Dev-Only Nodes | | `core.subgraph` | Hide Subgraph Nodes | Fixes #8390 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-8540-fix-localize-node-definition-filter-names-and-descriptions-2fb6d73d365081f29506ed804c233b5a) by [Unito](https://www.unito.io)
AustinMroz
added a commit
that referenced
this pull request
Feb 3, 2026
…descriptions (#8563) Backport of #8540 to cloud/1.38 Does not include dev-node changes since that has not been backported. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-8563-backport-cloud-1-38-fix-localize-node-definition-filter-names-and-descriptions-2fc6d73d36508171b11cfa01d522438b) by [Unito](https://www.unito.io) Co-authored-by: Christian Byrne <cbyrne@comfy.org>
AustinMroz
added a commit
that referenced
this pull request
Feb 3, 2026
…escriptions (#8564) Backport of #8540 to core/1.38 Does not include dev-node changes since that has not been backported. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-8564-backport-core-1-38-fix-localize-node-definition-filter-names-and-descriptions-2fc6d73d365081f1855ef5d1e0700329) by [Unito](https://www.unito.io) Co-authored-by: Christian Byrne <cbyrne@comfy.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Localizes node definition filter names and descriptions using vue-i18n, following the project's coding guidelines.
Changes
registerCoreNodeDefFilters()insrc/stores/nodeDefStore.tsto uset()function callsnodeFiltersnamespace insrc/locales/en/main.jsonAffected Filters
core.deprecatedcore.experimentalcore.dev_onlycore.subgraphFixes #8390
┆Issue is synchronized with this Notion page by Unito