Merged
Conversation
AustinMroz
added
needs-backport
dosubot
bot
added
the
size:M
🎭 Playwright Tests:
|
Contributor
📝 WalkthroughWalkthroughThe PR enhances control widget flexibility by exporting the Changes
Possibly related PRs
Suggested reviewers
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 01/31/2026, 05:26:10 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
coderabbitai
bot
requested review from
KarryCharon,
Yorha4D and
christian-byrne
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 26 kB (baseline 26 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 974 kB (baseline 974 kB) • 🟢 -267 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 80.7 kB (baseline 80.7 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed Panels & Settings — 471 kB (baseline 471 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 12 added / 12 removed User & Accounts — 3.94 kB (baseline 3.94 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 3 added / 3 removed Editors & Dialogs — 2.89 kB (baseline 2.89 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 2 added / 2 removed UI Components — 33.7 kB (baseline 33.7 kB) • ⚪ 0 BReusable component library chunks
Status: 4 added / 4 removed Data & Services — 2.71 MB (baseline 2.71 MB) • 🔴 +853 BStores, services, APIs, and repositories
Status: 8 added / 8 removed Utilities & Hooks — 25.3 kB (baseline 25.3 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 7 added / 7 removed Vendor & Third-Party — 10.7 MB (baseline 10.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 7.12 MB (baseline 7.12 MB) • ⚪ 0 BBundles that do not match a named category
Status: 36 added / 36 removed |
christian-byrne
approved these changes
Jan 31, 2026
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@src/renderer/extensions/vueNodes/widgets/composables/useComboWidget.ts`:
- Around line 77-85: The code currently accepts any string from
inputSpec.control_after_generate and passes it as defaultType into
addValueControlWidgets, which can produce invalid selections; clamp/validate
inputSpec.control_after_generate against the allowed options (e.g., 'fixed' and
the other valid control types used by addValueControlWidgets) before assigning
defaultType and fall back to 'fixed' for unknown values. Update the three blocks
that set defaultType (the one around the shown lines and the blocks at lines
~216-224 and ~295-303) to validate/control the string, then pass the validated
value into addValueControlWidgets (referencing inputSpec.control_after_generate,
defaultType, addValueControlWidgets, widget.linkedWidgets, node, widget).
In `@src/renderer/extensions/vueNodes/widgets/composables/useIntWidget.ts`:
- Around line 75-82: The current defaultType derived from
inputSpec.control_after_generate may be an unsupported string; before calling
addValueControlWidget, clamp/validate defaultType against the allowed control
options array (the same set used by addValueControlWidget) and if it is not in
that allowedOptions list, fallback to 'randomize'; update the code around
inputSpec.control_after_generate / defaultType to perform this membership check
so addValueControlWidget always receives a supported option.
github-actions bot
pushed a commit
that referenced
this pull request
Jan 31, 2026
Updates `control_after_generate` in the schema to support specifying the default control value as a string See Comfy-Org/ComfyUI#12187 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-8505-Update-control_after_generate-schema-2f96d73d365081f9bf73c804072bb415) by [Unito](https://www.unito.io)
github-actions bot
pushed a commit
that referenced
this pull request
Jan 31, 2026
Updates `control_after_generate` in the schema to support specifying the default control value as a string See Comfy-Org/ComfyUI#12187 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-8505-Update-control_after_generate-schema-2f96d73d365081f9bf73c804072bb415) by [Unito](https://www.unito.io)
Member
|
@AustinMroz Successfully backported to #8506 |
Member
|
@AustinMroz Successfully backported to #8507 |
github-actions
bot
removed
the
needs-backport
AustinMroz
added a commit
that referenced
this pull request
Jan 31, 2026
Backport of #8505 to `cloud/1.38` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-8507-backport-cloud-1-38-Update-control_after_generate-schema-2f96d73d365081d399f3f459a843709e) by [Unito](https://www.unito.io) Co-authored-by: AustinMroz <austin@comfy.org>
AustinMroz
added a commit
that referenced
this pull request
Jan 31, 2026
Backport of #8505 to `core/1.38` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-8506-backport-core-1-38-Update-control_after_generate-schema-2f96d73d36508106b677fafb3fe302fe) by [Unito](https://www.unito.io) Co-authored-by: AustinMroz <austin@comfy.org>
DrJKL
pushed a commit
that referenced
this pull request
Jan 31, 2026
Updates `control_after_generate` in the schema to support specifying the default control value as a string See Comfy-Org/ComfyUI#12187 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-8505-Update-control_after_generate-schema-2f96d73d365081f9bf73c804072bb415) by [Unito](https://www.unito.io)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
control_after_generatein the schema to support specifying the default control value as a stringSee Comfy-Org/ComfyUI#12187
┆Issue is synchronized with this Notion page by Unito