Skip to content

fix: Vue mode socket map data not cleaned up on dynamic input changes #8469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christian-byrne merged 2 commits into from
Jan 30, 2026
Merged

fix: Vue mode socket map data not cleaned up on dynamic input changes #8469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99e5e48
fix: use getAuthHeader in createCustomer to support API key auth
Jan 29, 2026
eeaa6d7
fix: use slot name as Vue key to fix socket map cleanup on dynamic in…
christian-byrne Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/renderer/extensions/vueNodes/components/NodeSlots.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
>
<InputSlot
v-for="(input, index) in filteredInputs"
:key="`input-${index}`"
:key="`input-${input.name}`"
:slot-data="input"
:node-type="nodeData?.type || ''"
:node-id="nodeData?.id != null ? String(nodeData.id) : ''"
Expand All @@ -23,7 +23,7 @@
>
<OutputSlot
v-for="(output, index) in nodeData.outputs"
:key="`output-${index}`"
:key="`output-${output.name}`"
:slot-data="output"
:node-type="nodeData?.type || ''"
:node-id="nodeData?.id != null ? String(nodeData.id) : ''"
Expand Down
8 changes: 8 additions & 0 deletions src/renderer/extensions/vueNodes/composables/useSlotElementTracking.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,14 @@ export function useSlotElementTracking(options: {
// Register slot
const slotKey = getSlotKey(nodeId, index, type === 'input')

// Defensive cleanup: remove stale entry if it exists with different element
// This handles edge cases where Vue component reuse prevents proper unmount
const existingEntry = node.slots.get(slotKey)
if (existingEntry && existingEntry.el !== el) {
delete existingEntry.el.dataset.slotKey
layoutStore.deleteSlotLayout(slotKey)
}

el.dataset.slotKey = slotKey
node.slots.set(slotKey, { el, index, type })

Expand Down
2 changes: 1 addition & 1 deletion src/stores/firebaseAuthStore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ export const useFirebaseAuthStore = defineStore('firebaseAuth', () => {
}

const createCustomer = async (): Promise<CreateCustomerResponse> => {
const authHeader = await getFirebaseAuthHeader()
const authHeader = await getAuthHeader()
if (!authHeader) {
throw new FirebaseAuthStoreError(t('toastMessages.userNotAuthenticated'))
}
Expand Down