Skip to content

[backport cloud/1.37] fix: move WorkspaceAuthGate to LayoutDefault for proper re-login hand…#8388

Merged
simula-r merged 1 commit intocloud/1.37from
backport-8381-to-cloud-1.37
Jan 29, 2026
Merged

[backport cloud/1.37] fix: move WorkspaceAuthGate to LayoutDefault for proper re-login hand…#8388
simula-r merged 1 commit intocloud/1.37from
backport-8381-to-cloud-1.37

Conversation

@comfy-pr-bot
Copy link
Member

@comfy-pr-bot comfy-pr-bot commented Jan 29, 2026

Backport of #8381 to cloud/1.37

Automatically created by backport workflow.

┆Issue is synchronized with this Notion page by Unito

#8381)

## Summary

- Move WorkspaceAuthGate from App.vue to LayoutDefault.vue so it only
wraps authenticated routes
- Change initialize() to run in onMounted() for proper Vue lifecycle
- Restore immediate: true in cloudRemoteConfig watcher as backup
- Gate now mounts fresh after login, fixing re-login feature flag issue

The root cause was a race condition: after logout + page reload, the
cloudRemoteConfig watcher could be set up after the user already logged
in, missing the isLoggedIn change and never calling /features endpoint.

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8381-fix-move-WorkspaceAuthGate-to-LayoutDefault-for-proper-re-login-hand-2f66d73d36508182a3dec09a49214a00)
by [Unito](https://www.unito.io)

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Jan 29, 2026
@comfy-pr-bot comfy-pr-bot requested a review from a team as a code owner January 29, 2026 02:34
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 29, 2026
@github-actions
Copy link

github-actions bot commented Jan 29, 2026

🎭 Playwright Tests: ❌ Failed

Results: 500 passed, 1 failed, 2 flaky, 8 skipped (Total: 511)

❌ Failed Tests

📊 Browser Reports
  • chromium: View Report (✅ 490 / ❌ 1 / ⚠️ 1 / ⏭️ 8)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 7 / ❌ 0 / ⚠️ 1 / ⏭️ 0)

@github-actions
Copy link

github-actions bot commented Jan 29, 2026

🎨 Storybook Build Status

Build completed successfully!

⏰ Completed at: 01/29/2026, 02:36:08 AM UTC

🔗 Links


🎉 Your Storybook is ready for review!

@simula-r
Copy link
Contributor

Playwright test failure unrelated to this change

@simula-r simula-r merged commit 72add79 into cloud/1.37 Jan 29, 2026
32 of 33 checks passed
@simula-r simula-r deleted the backport-8381-to-cloud-1.37 branch January 29, 2026 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants