feat: Change the card description to the filename#8348
Merged
Conversation
dosubot
bot
added
the
size:XS
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 01/28/2026, 07:51:17 PM UTC 🔗 Links🎉 Your Storybook is ready for review! |
🎭 Playwright Tests:
|
Contributor
📝 WalkthroughWalkthroughThe changes replace the Changes
Possibly related PRs
Suggested reviewers
✨ Finishing touches
Comment |
coderabbitai
bot
requested review from
KarryCharon,
Yorha4D,
luke-mino-altherr and
shinshin86
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 25.9 kB (baseline 25.9 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 960 kB (baseline 960 kB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 80.7 kB (baseline 80.7 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed Panels & Settings — 471 kB (baseline 471 kB) • 🟢 -8 BConfiguration panels, inspectors, and settings screens
Status: 12 added / 12 removed User & Accounts — 3.94 kB (baseline 3.94 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 3 added / 3 removed Editors & Dialogs — 2.89 kB (baseline 2.89 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 2 added / 2 removed UI Components — 33.7 kB (baseline 33.7 kB) • ⚪ 0 BReusable component library chunks
Status: 4 added / 4 removed Data & Services — 2.7 MB (baseline 2.7 MB) • 🟢 -45 BStores, services, APIs, and repositories
Status: 8 added / 8 removed Utilities & Hooks — 25.3 kB (baseline 25.3 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 7 added / 7 removed Vendor & Third-Party — 10.7 MB (baseline 10.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 7.05 MB (baseline 7.05 MB) • 🟢 -198 BBundles that do not match a named category
Status: 34 added / 34 removed |
dosubot
bot
added
size:S
🔧 Auto-fixes AppliedThis PR has been automatically updated to fix linting and formatting issues.
Changes made:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/platform/assets/composables/useAssetBrowser.ts`:
- Around line 118-121: Update the comment inside transformAssetForDisplay to
reflect current behavior: state that the description is derived from the
filename via getAssetFilename (not created from tags) and clarify that typeTag
(the variable typeTag) is only used for badges/labels, not for building the
description; keep references to the variables typeTag and description so the
intent is clear to future readers.
| const description = | ||
| getAssetDescription(asset) || | ||
| `${typeTag || t('assetBrowser.unknown')} model` | ||
| const description = getAssetFilename(asset) |
Contributor
There was a problem hiding this comment.
Whats getAssetDescription give? Should we rename the description variable to avoid confusion?
Contributor
Author
There was a problem hiding this comment.
Going with secondaryText for now.
luke-mino-altherr
previously approved these changes
Jan 28, 2026
Amp-Thread-ID: https://ampcode.com/threads/T-019c061f-db7b-7287-9bab-70b2390de2e2 Co-authored-by: Amp <amp@ampcode.com>
dosubot
bot
added
size:M
AustinMroz
approved these changes
Jan 28, 2026
Collaborator
AustinMroz
left a comment
AustinMroz
left a comment
There was a problem hiding this comment.
Change looks a little weird on the cloud models that don't have names, but that's an entirely different problem
| Before | After |
|---|---|
 |
 |
DrJKL
added
needs-backport
github-actions bot
pushed a commit
that referenced
this pull request
Jan 28, 2026
## Summary No longer duplicates the badge info for the Model type. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-8348-feat-Change-the-card-description-to-the-filename-2f66d73d3650818d99e1de479d1f8486) by [Unito](https://www.unito.io) --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Amp <amp@ampcode.com>
Member
github-actions
bot
removed
the
needs-backport
AustinMroz
pushed a commit
that referenced
this pull request
Jan 28, 2026
…me (#8380) Backport of #8348 to `cloud/1.38` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-8380-backport-cloud-1-38-feat-Change-the-card-description-to-the-filename-2f66d73d365081a989a3f793bb72605d) by [Unito](https://www.unito.io) Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
No longer duplicates the badge info for the Model type.
┆Issue is synchronized with this Notion page by Unito