Skip to content

[backport cloud/1.37] Fix dragging Vue nodes into canvas from library #8346

Merged
AustinMroz merged 1 commit intocloud/1.37from
backport-8118-to-cloud-1.37
Jan 28, 2026
Merged

[backport cloud/1.37] Fix dragging Vue nodes into canvas from library #8346
AustinMroz merged 1 commit intocloud/1.37from
backport-8118-to-cloud-1.37

Conversation

@comfy-pr-bot
Copy link
Member

@comfy-pr-bot comfy-pr-bot commented Jan 28, 2026

Backport of #8118 to cloud/1.37

Automatically created by backport workflow.

┆Issue is synchronized with this Notion page by Unito

## Summary

Updates the node preview rendering to use the same app context as the
main app so it can access the same plugins

## Changes

Assigns manually created vnode app context to the current instances
context

## Review Focus

This is using somewhat advanced/almost-internal Vue functionality,
however I couldn't come up with a better alternative that didn't require
recreating an entirely new app and re-registering all dependencies or
redoing how draggable node previews are done.
The draggable image needs to be rendered synchronously, so rendering a
node in the active app and capturing that isn't possible to guarantee to
be done synchronously (afaik - suggestions welcome)

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8118-Fix-dragging-Vue-nodes-into-canvas-from-library-2eb6d73d365081a0a956d8280e009592)
by [Unito](https://www.unito.io)
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Jan 28, 2026
@comfy-pr-bot comfy-pr-bot requested a review from a team as a code owner January 28, 2026 00:40
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 28, 2026
@github-actions
Copy link

github-actions bot commented Jan 28, 2026

🎭 Playwright Tests: ❌ Failed

Results: 500 passed, 1 failed, 2 flaky, 8 skipped (Total: 511)

❌ Failed Tests

📊 Browser Reports
  • chromium: View Report (✅ 490 / ❌ 1 / ⚠️ 1 / ⏭️ 8)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 7 / ❌ 0 / ⚠️ 1 / ⏭️ 0)

@github-actions
Copy link

github-actions bot commented Jan 28, 2026

🎨 Storybook Build Status

Build completed successfully!

⏰ Completed at: 01/28/2026, 12:42:07 AM UTC

🔗 Links


🎉 Your Storybook is ready for review!

@luke-mino-altherr luke-mino-altherr enabled auto-merge (squash) January 28, 2026 00:44
@AustinMroz AustinMroz disabled auto-merge January 28, 2026 01:25
@AustinMroz AustinMroz merged commit 4c2edae into cloud/1.37 Jan 28, 2026
32 of 33 checks passed
@AustinMroz AustinMroz deleted the backport-8118-to-cloud-1.37 branch January 28, 2026 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants