Skip to content

feat: Make the text for the value control a clickable label #8334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DrJKL merged 4 commits into from
Jan 27, 2026
Merged

feat: Make the text for the value control a clickable label #8334

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4588487
feat: Make the text for the value control a clickable label
DrJKL Jan 27, 2026
0fa32a2
style: Buttonify the options
DrJKL Jan 27, 2026
ee53351
[automated] Apply ESLint and Oxfmt fixes
actions-user Jan 27, 2026
9495a3e
Merge branch 'main' into drjkl/its-all-a-button
DrJKL Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions src/renderer/extensions/vueNodes/widgets/components/ValueControlPopover.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<script setup lang="ts">
import RadioButton from 'primevue/radiobutton'
import Button from '@/components/ui/button/Button.vue'
import { computed } from 'vue'

import { useSettingStore } from '@/platform/settings/settingStore'
Expand Down Expand Up @@ -64,12 +65,16 @@ const controlMode = defineModel<ControlOptions>()
</div>

<div class="space-y-2">
<div
<Button
v-for="option in controlOptions"
:key="option.mode"
class="flex items-center justify-between py-2 gap-7"
as="label"
variant="textonly"
size="lg"
class="flex w-full h-[unset] text-left items-center justify-between py-2 gap-7"
:for="option.mode"
>
<div class="flex items-center gap-2 flex-1 min-w-0">
<div class="flex items-center gap-2 flex-1 min-w-0 text-wrap">
<div
class="flex items-center justify-center w-8 h-8 rounded-lg flex-shrink-0 bg-secondary-background border border-border-subtle"
>
Expand Down Expand Up @@ -102,11 +107,11 @@ const controlMode = defineModel<ControlOptions>()

<RadioButton
v-model="controlMode"
class="flex-shrink-0"
class="shrink"
:input-id="option.mode"
:value="option.mode"
/>
</div>
</Button>
</div>
</div>
</template>