[refactor] SearchBox and MultiSelect style improvements#8328
Merged
viva-jinyi merged 12 commits intomainfrom Jan 28, 2026
Merged
[refactor] SearchBox and MultiSelect style improvements#8328viva-jinyi merged 12 commits intomainfrom
viva-jinyi merged 12 commits intomainfrom
Conversation
dosubot
bot
added
the
size:S
Contributor
📝 WalkthroughWalkthroughUpdates UI styling: SearchBox.vue adds an Changes
Possibly related PRs
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎭 Playwright Tests:
|
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 01/28/2026, 02:07:02 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 23.6 kB (baseline 23.6 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 961 kB (baseline 961 kB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 80.7 kB (baseline 80.7 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed Panels & Settings — 470 kB (baseline 470 kB) • 🟢 -8 BConfiguration panels, inspectors, and settings screens
Status: 12 added / 12 removed User & Accounts — 3.94 kB (baseline 3.94 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 3 added / 3 removed Editors & Dialogs — 2.9 kB (baseline 2.9 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 2 added / 2 removed UI Components — 33.7 kB (baseline 33.7 kB) • ⚪ 0 BReusable component library chunks
Status: 4 added / 4 removed Data & Services — 2.7 MB (baseline 2.7 MB) • 🔴 +316 BStores, services, APIs, and repositories
Status: 9 added / 9 removed Utilities & Hooks — 25.5 kB (baseline 25.5 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 7 added / 7 removed Vendor & Third-Party — 10.7 MB (baseline 10.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 7.04 MB (baseline 7.04 MB) • 🟢 -200 BBundles that do not match a named category
Status: 37 added / 37 removed |
DrJKL
reviewed
Jan 27, 2026
src/components/common/SearchBox.vue
Outdated
| ) | ||
|
|
||
| const wrapperStyle = computed(() => { | ||
| const heightClass = size === 'lg' ? 'h-10' : 'h-8' |
Contributor
There was a problem hiding this comment.
Nit: I'd inline this unless it's reused.
DrJKL
previously approved these changes
Jan 27, 2026
Contributor
DrJKL
left a comment
DrJKL
left a comment
There was a problem hiding this comment.
The same check (size === 'lg') in three places makes me feel like it deserves a name, but 👍🏻
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/components/common/SearchBox.vue`:
- Around line 116-122: The computed classes for the search box use heightClass
('h-10'/'h-8') together with 'p-2' which increases the rendered height; update
the branch that builds the class when showBorder is true (the block that returns
cn(...)) to include 'box-border' so padding is included inside the set height
(or alternatively reduce/remove 'p-2' if you prefer less internal padding).
Ensure the same box-sizing change is applied wherever the non-border variant
constructs classes so heightClass behaves consistently.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/components/common/SearchBox.vue (1)
91-122: MakeisLargea computed property to react tosizechanges.
const isLarge = size === 'lg'is evaluated once at initialization. When thesizeprop updates,isLargewon't update, causing size-dependent classes to not react properly. Usecomputed()and reference.valuein the conditional.-const isLarge = size === 'lg' +const isLarge = computed(() => size === 'lg') ... - isLarge ? 'h-10' : 'h-8' + isLarge.value ? 'h-10' : 'h-8'
viva-jinyi
added
the
New Browser Test Expectations
|
Updating Playwright Expectations |
github-actions
bot
removed
the
New Browser Test Expectations
DrJKL
reviewed
Jan 27, 2026
Co-authored-by: Alexander Brown <drjkl@comfy.org>
🔧 Auto-fixes AppliedThis PR has been automatically updated to fix linting and formatting issues.
Changes made:
|
DrJKL
previously approved these changes
Jan 27, 2026
viva-jinyi
added
the
New Browser Test Expectations
github-actions
bot
removed
the
New Browser Test Expectations
DrJKL
approved these changes
Jan 28, 2026
🔧 Auto-fixes AppliedThis PR has been automatically updated to fix linting and formatting issues.
Changes made:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix SearchBox height collapse when typing and improve MultiSelect empty state styling.
Changes
showBorder=trueto prevent collapsesizepropReview Focus
Before
screen-capture.1.mp4
After
screen-capture.mp4
┆Issue is synchronized with this Notion page by Unito