perf: remove autoplay from assets cards#8325
Merged
christian-byrne merged 1 commit intomainfrom Jan 27, 2026
Merged
Conversation
christian-byrne
added
the
needs-backport
christian-byrne
added
core/1.37
dosubot
bot
added
the
size:XS
Contributor
📝 WalkthroughWalkthroughThe Changes
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎭 Playwright Tests:
|
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 01/27/2026, 02:51:16 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 22.8 kB (baseline 22.8 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 960 kB (baseline 960 kB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 80.7 kB (baseline 80.7 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed Panels & Settings — 466 kB (baseline 466 kB) • 🟢 -8 BConfiguration panels, inspectors, and settings screens
Status: 12 added / 12 removed User & Accounts — 3.94 kB (baseline 3.94 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 3 added / 3 removed Editors & Dialogs — 2.83 kB (baseline 2.83 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 2 added / 2 removed UI Components — 33.7 kB (baseline 33.7 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed Data & Services — 3.19 MB (baseline 3.19 MB) • 🔴 +1 BStores, services, APIs, and repositories
Status: 8 added / 8 removed Utilities & Hooks — 25.2 kB (baseline 25.2 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 7 added / 7 removed Vendor & Third-Party — 10.7 MB (baseline 10.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 6.49 MB (baseline 6.49 MB) • 🟢 -211 BBundles that do not match a named category
Status: 35 added / 35 removed |
DrJKL
approved these changes
Jan 27, 2026
github-actions bot
pushed a commit
that referenced
this pull request
Jan 27, 2026
## Summary It's rare that someone has enabled autoplay -- but when they have, scrolling through a large grid of videos and trying to play them all onload can cause extreme lag. We don't need the asset cards to be autoplaying, so the fix here is fine for perf and UX. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-8325-perf-remove-autoplay-from-assets-cards-2f56d73d3650814e8103f01b1f21b2e2) by [Unito](https://www.unito.io)
github-actions bot
pushed a commit
that referenced
this pull request
Jan 27, 2026
## Summary It's rare that someone has enabled autoplay -- but when they have, scrolling through a large grid of videos and trying to play them all onload can cause extreme lag. We don't need the asset cards to be autoplaying, so the fix here is fine for perf and UX. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-8325-perf-remove-autoplay-from-assets-cards-2f56d73d3650814e8103f01b1f21b2e2) by [Unito](https://www.unito.io)
Member
|
@christian-byrne Successfully backported to #8326 |
Member
|
@christian-byrne Successfully backported to #8327 |
github-actions
bot
removed
the
needs-backport
DrJKL
pushed a commit
that referenced
this pull request
Jan 27, 2026
Backport of #8325 to `core/1.37` Automatically created by backport workflow. Co-authored-by: Christian Byrne <cbyrne@comfy.org>
DrJKL
pushed a commit
that referenced
this pull request
Jan 27, 2026
Backport of #8325 to `cloud/1.37` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-8327-backport-cloud-1-37-perf-remove-autoplay-from-assets-cards-2f56d73d365081cd8097e7a8619c427f) by [Unito](https://www.unito.io) Co-authored-by: Christian Byrne <cbyrne@comfy.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
It's rare that someone has enabled autoplay -- but when they have, scrolling through a large grid of videos and trying to play them all onload can cause extreme lag. We don't need the asset cards to be autoplaying, so the fix here is fine for perf and UX.
┆Issue is synchronized with this Notion page by Unito