Skip to content

[backport cloud/1.37] fix: fallback to asset metadata/name when filename missing#8305

Merged
DrJKL merged 1 commit intocloud/1.37from
backport-8302-to-cloud-1.37
Jan 25, 2026
Merged

[backport cloud/1.37] fix: fallback to asset metadata/name when filename missing#8305
DrJKL merged 1 commit intocloud/1.37from
backport-8302-to-cloud-1.37

Conversation

@comfy-pr-bot
Copy link
Member

@comfy-pr-bot comfy-pr-bot commented Jan 25, 2026

Backport of #8302 to cloud/1.37

Automatically created by backport workflow.

┆Issue is synchronized with this Notion page by Unito

## Summary

Fix model node creation failing when `user_metadata.filename` is missing
by falling back to `asset.metadata.filename` or `asset.name`.

## Changes

- Add fallback chain for filename: `userMetadata.filename ||
validAsset.metadata?.filename || validAsset.name`

## Testing

Manual testing with assets that have filename in different metadata
locations.

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8302-fix-fallback-to-asset-metadata-name-when-filename-missing-2f36d73d365081478299e2f2c1abde81)
by [Unito](https://www.unito.io)

---------

Co-authored-by: Amp <amp@ampcode.com>
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Jan 25, 2026
@comfy-pr-bot comfy-pr-bot requested a review from a team as a code owner January 25, 2026 00:31
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 25, 2026
@github-actions
Copy link

github-actions bot commented Jan 25, 2026

🎭 Playwright Tests: ⚠️ Passed with flaky tests

Results: 502 passed, 0 failed, 2 flaky, 8 skipped (Total: 512)

❌ Failed Tests

📊 Browser Reports
  • chromium: View Report (✅ 492 / ❌ 0 / ⚠️ 1 / ⏭️ 8)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 7 / ❌ 0 / ⚠️ 1 / ⏭️ 0)

@github-actions
Copy link

github-actions bot commented Jan 25, 2026

🎨 Storybook Build Status

Build completed successfully!

⏰ Completed at: 01/25/2026, 12:33:20 AM UTC

🔗 Links


🎉 Your Storybook is ready for review!

@DrJKL DrJKL enabled auto-merge (squash) January 25, 2026 00:32
@DrJKL DrJKL merged commit 113a6a7 into cloud/1.37 Jan 25, 2026
32 checks passed
@DrJKL DrJKL deleted the backport-8302-to-cloud-1.37 branch January 25, 2026 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants