Skip to content

Road to No explicit any Part 8 (Group 3): Improve type safety in Group 3 test mocks #8304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Myestery merged 7 commits into from
Jan 26, 2026
Merged

Road to No explicit any Part 8 (Group 3): Improve type safety in Group 3 test mocks #8304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e1af8ec
test: improve type safety in Group 3 test mocks
Myestery Jan 25, 2026
a0265de
test: remove duplicate createMockPointerEvent helper in useLoad3d.tes…
Myestery Jan 25, 2026
c416cab
test: remove duplicate mockedPointerEvent helper in LinkConnector.int…
Myestery Jan 25, 2026
97ecec0
test: replace MockEvents with Partial<CustomEventTarget> in ToOutputR…
Myestery Jan 25, 2026
f315398
test: add Symbol.iterator support to createMockFileList
Myestery Jan 25, 2026
883a0ea
docs: clarify createMockLGraphNodeWithArrayBoundingRect usage
Myestery Jan 25, 2026
1923dd0
refactor: replace local test interfaces with library type aliases
Myestery Jan 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions src/composables/useFeatureFlags.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,7 @@ describe('useFeatureFlags', () => {
it('should access supportsPreviewMetadata', () => {
vi.mocked(api.getServerFeature).mockImplementation(
(path, defaultValue) => {
if (path === ServerFeatureFlag.SUPPORTS_PREVIEW_METADATA)
return true as any
if (path === ServerFeatureFlag.SUPPORTS_PREVIEW_METADATA) return true
return defaultValue
}
)
Expand All @@ -46,8 +45,7 @@ describe('useFeatureFlags', () => {
it('should access maxUploadSize', () => {
vi.mocked(api.getServerFeature).mockImplementation(
(path, defaultValue) => {
if (path === ServerFeatureFlag.MAX_UPLOAD_SIZE)
return 209715200 as any // 200MB
if (path === ServerFeatureFlag.MAX_UPLOAD_SIZE) return 209715200 // 200MB
return defaultValue
}
)
Expand All @@ -62,7 +60,7 @@ describe('useFeatureFlags', () => {
it('should access supportsManagerV4', () => {
vi.mocked(api.getServerFeature).mockImplementation(
(path, defaultValue) => {
if (path === ServerFeatureFlag.MANAGER_SUPPORTS_V4) return true as any
if (path === ServerFeatureFlag.MANAGER_SUPPORTS_V4) return true
return defaultValue
}
)
Expand All @@ -76,7 +74,7 @@ describe('useFeatureFlags', () => {

it('should return undefined when features are not available and no default provided', () => {
vi.mocked(api.getServerFeature).mockImplementation(
(_path, defaultValue) => defaultValue as any
(_path, defaultValue) => defaultValue
)

const { flags } = useFeatureFlags()
Expand All @@ -90,7 +88,7 @@ describe('useFeatureFlags', () => {
it('should create reactive computed for custom feature flags', () => {
vi.mocked(api.getServerFeature).mockImplementation(
(path, defaultValue) => {
if (path === 'custom.feature') return 'custom-value' as any
if (path === 'custom.feature') return 'custom-value'
return defaultValue
}
)
Expand All @@ -108,7 +106,7 @@ describe('useFeatureFlags', () => {
it('should handle nested paths', () => {
vi.mocked(api.getServerFeature).mockImplementation(
(path, defaultValue) => {
if (path === 'extension.custom.nested.feature') return true as any
if (path === 'extension.custom.nested.feature') return true
return defaultValue
}
)
Expand All @@ -122,8 +120,7 @@ describe('useFeatureFlags', () => {
it('should work with ServerFeatureFlag enum', () => {
vi.mocked(api.getServerFeature).mockImplementation(
(path, defaultValue) => {
if (path === ServerFeatureFlag.MAX_UPLOAD_SIZE)
return 104857600 as any
if (path === ServerFeatureFlag.MAX_UPLOAD_SIZE) return 104857600
return defaultValue
}
)
Expand Down
Loading