Skip to content

Conversation

@benceruleanlu
Copy link
Member

@benceruleanlu benceruleanlu commented Jan 24, 2026

Add list view stack UI and selection/gallery alignment.

Summary

Wire useOutputStacks into list view, add stack toggle UI, and ensure list selection and gallery navigation use the visible asset list.

Changes

  • What: add stack toggle UI in list items and list view; pass selectable assets to selection handler; update asset actions to prefer metadata prompt IDs.
  • Dependencies: stacks on PR Add output stack composable #8297.

Review Focus

  • Stack toggle behavior + child indentation in list view.
  • Selection/gallery behavior when stacks expand/collapse.

Screenshots (if applicable)

N/A

┆Issue is synchronized with this Notion page by Unito

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 24, 2026

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Jan 24, 2026

🎨 Storybook Build Status

Build completed successfully!

⏰ Completed at: 01/24/2026, 04:09:40 PM UTC

🔗 Links


🎉 Your Storybook is ready for review!

@github-actions
Copy link

github-actions bot commented Jan 24, 2026

🎭 Playwright Tests: ⚠️ Passed with flaky tests

Results: 505 passed, 0 failed, 1 flaky, 8 skipped (Total: 514)

❌ Failed Tests

📊 Browser Reports
  • chromium: View Report (✅ 493 / ❌ 0 / ⚠️ 1 / ⏭️ 8)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 9 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

@benceruleanlu benceruleanlu marked this pull request as ready for review January 24, 2026 16:09
@benceruleanlu benceruleanlu requested a review from a team as a code owner January 24, 2026 16:09
Copilot AI review requested due to automatic review settings January 24, 2026 16:09
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jan 24, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR wires the useOutputStacks composable into the assets list view, adding UI for stack toggles and ensuring that selection and gallery navigation work correctly with visible (expanded/collapsed) assets.

Changes:

  • Export OutputStackListItem type from useOutputStacks composable for use in list view components
  • Update prompt ID extraction logic in useMediaAssetActions to prefer metadata over asset ID for better Cloud/OSS compatibility
  • Add stack toggle button UI to AssetsListItem component with proper accessibility attributes
  • Integrate useOutputStacks into AssetsSidebarTab and wire visible assets into selection and gallery navigation
  • Update AssetsSidebarListView to accept stack-related props and display child items with indentation

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/platform/assets/composables/useOutputStacks.ts Export OutputStackListItem type for external consumption
src/platform/assets/composables/useMediaAssetActions.ts Reorder prompt ID extraction to prefer metadata over asset.id for consistency
src/platform/assets/components/AssetsListItem.vue Add stack toggle button UI with count display and expand/collapse chevron
src/components/sidebar/tabs/AssetsSidebarTab.vue Integrate useOutputStacks, reconcile selection on visibility changes, use visible assets for gallery
src/components/sidebar/tabs/AssetsSidebarListView.vue Accept stack-related props, display child items with indentation, compute stack counts
src/components/sidebar/tabs/AssetsSidebarListView.stories.ts Update Storybook story to use useOutputStacks composable

@viva-jinyi
Copy link
Member

AssetGridView also has some output-related logic, and I think it’d be good to merge that later so both ListView and GridView can use the same shared implementation.

benceruleanlu added a commit that referenced this pull request Feb 2, 2026
Add expandable output stacks to the assets list view.

Monolith ver. of #8298
and its children

List view currently collapses multi-output jobs into a single row, which
makes sibling outputs easy to miss and causes selection/zoom behavior to
drift once items are expanded elsewhere. This change adds a stack toggle
to list rows, expands child outputs derived from job data, and keeps
list-view selection and gallery navigation aligned with the expanded
list. Output mapping and “load full outputs” checks are centralized so
folder view and stacks share the same helper, and job-detail parsing now
yields previewable outputs for the list view. Asset actions now prefer
metadata prompt IDs to support the composite IDs used by stacked
outputs.

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8283-Add-expandable-output-stacks-to-assets-list-view-2f16d73d365081a99fc6f1519ac2e57c)
by [Unito](https://www.unito.io)

---------

Co-authored-by: GitHub Action <action@github.com>
Co-authored-by: Johnpaul Chiwetelu <49923152+Myestery@users.noreply.github.com>
@benceruleanlu
Copy link
Member Author

Replaced by #8283

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants