-
Notifications
You must be signed in to change notification settings - Fork 491
Wire output stacks into assets list view #8298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 01/24/2026, 04:09:40 PM UTC 🔗 Links🎉 Your Storybook is ready for review! |
🎭 Playwright Tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR wires the useOutputStacks composable into the assets list view, adding UI for stack toggles and ensuring that selection and gallery navigation work correctly with visible (expanded/collapsed) assets.
Changes:
- Export
OutputStackListItemtype fromuseOutputStackscomposable for use in list view components - Update prompt ID extraction logic in
useMediaAssetActionsto prefer metadata over asset ID for better Cloud/OSS compatibility - Add stack toggle button UI to
AssetsListItemcomponent with proper accessibility attributes - Integrate
useOutputStacksintoAssetsSidebarTaband wire visible assets into selection and gallery navigation - Update
AssetsSidebarListViewto accept stack-related props and display child items with indentation
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/platform/assets/composables/useOutputStacks.ts |
Export OutputStackListItem type for external consumption |
src/platform/assets/composables/useMediaAssetActions.ts |
Reorder prompt ID extraction to prefer metadata over asset.id for consistency |
src/platform/assets/components/AssetsListItem.vue |
Add stack toggle button UI with count display and expand/collapse chevron |
src/components/sidebar/tabs/AssetsSidebarTab.vue |
Integrate useOutputStacks, reconcile selection on visibility changes, use visible assets for gallery |
src/components/sidebar/tabs/AssetsSidebarListView.vue |
Accept stack-related props, display child items with indentation, compute stack counts |
src/components/sidebar/tabs/AssetsSidebarListView.stories.ts |
Update Storybook story to use useOutputStacks composable |
|
AssetGridView also has some output-related logic, and I think it’d be good to merge that later so both ListView and GridView can use the same shared implementation. |
Add expandable output stacks to the assets list view. Monolith ver. of #8298 and its children List view currently collapses multi-output jobs into a single row, which makes sibling outputs easy to miss and causes selection/zoom behavior to drift once items are expanded elsewhere. This change adds a stack toggle to list rows, expands child outputs derived from job data, and keeps list-view selection and gallery navigation aligned with the expanded list. Output mapping and “load full outputs” checks are centralized so folder view and stacks share the same helper, and job-detail parsing now yields previewable outputs for the list view. Asset actions now prefer metadata prompt IDs to support the composite IDs used by stacked outputs. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-8283-Add-expandable-output-stacks-to-assets-list-view-2f16d73d365081a99fc6f1519ac2e57c) by [Unito](https://www.unito.io) --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Johnpaul Chiwetelu <49923152+Myestery@users.noreply.github.com>
|
Replaced by #8283 |
Add list view stack UI and selection/gallery alignment.
Summary
Wire
useOutputStacksinto list view, add stack toggle UI, and ensure list selection and gallery navigation use the visible asset list.Changes
Review Focus
Screenshots (if applicable)
N/A
┆Issue is synchronized with this Notion page by Unito