-
Notifications
You must be signed in to change notification settings - Fork 649
Add inline queue progress bar and text summary #8271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 15 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
8c74a03
fix: open assets tab when QPO V2 enabled
benceruleanlu 9fb11a1
fix: toggle assets tab from queue button
benceruleanlu fd07245
Merge remote-tracking branch 'origin/main' into fix/qpo-v2-queue-butt…
benceruleanlu 7609554
test: cover queue button behavior by QPO setting
benceruleanlu c63e27f
Add inline progress text and progress bar
benceruleanlu 76b7137
Adjust spacing
benceruleanlu ce86b53
Fix location when floating
benceruleanlu aef4ddb
Perfectly align inline progress
benceruleanlu c60114f
fix: anchor floating inline progress summary
benceruleanlu 573eb8c
test: cover inline queue progress UI
benceruleanlu 4db59b7
test: stabilize queue inline progress mock
benceruleanlu 15229ba
[automated] Update test expectations
invalid-email-address 4eb547b
Merge remote-tracking branch 'origin/main' into bl-inline-progress
benceruleanlu 9a2383d
Deduplicate node title resolving
benceruleanlu e0cdbe3
Knip
benceruleanlu 4234e2b
Emit progress target instead of expose
benceruleanlu 2a9e31a
Use VueUse unrefElement
benceruleanlu 3225214
Unify usage of resolveNodeDisplayName
benceruleanlu f4f0f6a
Don't use stubbed
benceruleanlu 88f07bd
fix: merge main
benceruleanlu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file modified
BIN
-322 Bytes
(99%)
...obileBaseline.spec.ts-snapshots/mobile-default-workflow-mobile-chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-336 Bytes
(98%)
...ts/mobileBaseline.spec.ts-snapshots/mobile-empty-canvas-mobile-chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+0 Bytes
(100%)
...mobileBaseline.spec.ts-snapshots/mobile-settings-dialog-mobile-chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-366 Bytes
(99%)
...canvas/pan.spec.ts-snapshots/vue-nodes-paned-with-touch-mobile-chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-326 Bytes
(99%)
...s/node/move.spec.ts-snapshots/vue-node-moved-node-touch-mobile-chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick | 🔵 Trivial
Consider using explicit return type annotation for type safety.
The
configureSettingshelper function lacks a return type annotation. While it implicitly returnsvoid, adding an explicit annotation improves readability and catches accidental return value bugs.♻️ Suggested improvement
📝 Committable suggestion
🤖 Prompt for AI Agents