[refactor] Migrate SettingDialog to BaseModalLayout design system#8269
Closed
viva-jinyi wants to merge 1 commit intoComfy-Org:mainfrom
Closed
[refactor] Migrate SettingDialog to BaseModalLayout design system#8269viva-jinyi wants to merge 1 commit intoComfy-Org:mainfrom
viva-jinyi wants to merge 1 commit intoComfy-Org:mainfrom
Conversation
dosubot
bot
added
the
size:XXL
🎨 Storybook Build Status
⏰ Started at: 01/23/2026, 07:55:27 AM UTC 🚀 Building Storybook
⏱️ Please wait while the Storybook build is in progress... |
Contributor
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughThis PR refactors the settings dialog system by replacing the service-based Changes
Possibly related PRs
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎭 Playwright Tests: ⏳ Running...Tests started at 01/23/2026, 07:55:28 AM UTC 📊 Browser Tests
|
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 22.4 kB (baseline 22.7 kB) • 🟢 -285 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 949 kB (baseline 949 kB) • 🟢 -215 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 80.7 kB (baseline 80.7 kB) • 🔴 +2 BTop-level views, pages, and routed surfaces
Status: 11 added / 11 removed Panels & Settings — 439 kB (baseline 440 kB) • 🟢 -1.55 kBConfiguration panels, inspectors, and settings screens
Status: 12 added / 12 removed User & Accounts — 3.94 kB (baseline 3.94 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 3 added / 3 removed Editors & Dialogs — 2.83 kB (baseline 2.83 kB) • 🔴 +1 BModals, dialogs, drawers, and in-app editors
Status: 2 added / 2 removed UI Components — 33.7 kB (baseline 33.7 kB) • 🟢 -2 BReusable component library chunks
Status: 9 added / 9 removed Data & Services — 3.18 MB (baseline 3.17 MB) • 🔴 +12.3 kBStores, services, APIs, and repositories
Status: 10 added / 9 removed Utilities & Hooks — 23.8 kB (baseline 24 kB) • 🟢 -210 BHelpers, composables, and utility bundles
Status: 10 added / 10 removed Vendor & Third-Party — 10.7 MB (baseline 10.7 MB) • 🔴 +15 BExternal libraries and shared vendor chunks
Status: 7 added / 7 removed Other — 6.35 MB (baseline 6.36 MB) • 🟢 -16.3 kBBundles that do not match a named category
Status: 47 added / 48 removed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace PrimeVue-based SettingDialog with BaseModalLayout + custom left panel, extract
useSettingsDialogcomposable, and migrate workspace tabs to design system components.Changes
BaseModalLayoutwith custom left panel (PanelHeader,NavTitle,NavItem), search box, and workspace image supportdialogService.tsfollowinguseManagerDialogpattern; updated all 10 callersTabs/TabList/Tab/TabPanel/TabPanelswith design systemTabList/TabSettingDialogContent.vue,SettingDialogHeader.vue,PanelTemplate.vue,WorkspaceSidebarItem.vueTabPanel/PanelTemplatewrappers from all setting panels (About, Keybinding, Extension, ServerConfig, User, Workspace, Credits, Subscription)Review Focus
useSettingsDialogcomposable replacesdialogService.showSettingsDialog/showAboutDialog