Merged
Conversation
Since dragDelta is a modulus to the next drag step, the prior code created a 1-in-10 chance that a scrub operation would result in text being edited regardless of distance dragged. This is now fixed.
dosubot
bot
added
the
size:S
Contributor
📝 WalkthroughWalkthroughModified drag completion logic in WidgetInputNumberInput to compare current and new values instead of checking dragDelta, and restructured the slider track DOM with nested containers for overflow clipping. Changes
Possibly related PRs
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎭 Playwright Tests:
|
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 01/22/2026, 11:14:21 PM UTC 🔗 Links🎉 Your Storybook is ready for review! |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 22.7 kB (baseline 22.7 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 948 kB (baseline 948 kB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 80.7 kB (baseline 80.7 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed Panels & Settings — 440 kB (baseline 440 kB) • 🟢 -8 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed User & Accounts — 3.94 kB (baseline 3.94 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 3 added / 3 removed Editors & Dialogs — 2.83 kB (baseline 2.83 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 2 added / 2 removed UI Components — 33.7 kB (baseline 33.7 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed Data & Services — 3.16 MB (baseline 3.16 MB) • 🔴 +1 BStores, services, APIs, and repositories
Status: 8 added / 8 removed Utilities & Hooks — 24 kB (baseline 24 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 7 added / 7 removed Vendor & Third-Party — 10.7 MB (baseline 10.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 6.36 MB (baseline 6.36 MB) • 🟢 -95 BBundles that do not match a named category
Status: 30 added / 30 removed |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In
`@src/renderer/extensions/vueNodes/widgets/components/WidgetInputNumberInput.vue`:
- Around line 205-212: The inner track element uses the class "size-full" while
its width is controlled via inline style; update the inner div (the element
currently having class "bg-primary-background/15 size-full") to use "h-full"
instead of "size-full" so the intent (full height, variable width) is clearer
and avoids implying the width is fixed.
Comment on lines
205
to
+212
| <div | ||
| class="bg-primary-background/15 absolute left-0 bottom-0 h-full rounded-lg pointer-events-none" | ||
| :style="{ width: `${sliderWidth}%` }" | ||
| /> | ||
| class="absolute size-full rounded-lg pointer-events-none overflow-clip" | ||
| > | ||
| <div | ||
| class="bg-primary-background/15 size-full" | ||
| :style="{ width: `${sliderWidth}%` }" | ||
| /> | ||
| </div> |
Contributor
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
LGTM! The nested structure with overflow-clip correctly prevents slider overflow.
The outer container with rounded-lg and overflow-clip ensures the track is clipped at small values while maintaining rounded corners at the ends.
Minor clarity improvement: since the inline style overrides width, you could use h-full instead of size-full on the inner div to make the intent clearer:
♻️ Optional: clarify width/height intent
<div
- class="bg-primary-background/15 size-full"
+ class="bg-primary-background/15 h-full"
:style="{ width: `${sliderWidth}%` }"
/>🤖 Prompt for AI Agents
In
`@src/renderer/extensions/vueNodes/widgets/components/WidgetInputNumberInput.vue`
around lines 205 - 212, The inner track element uses the class "size-full" while
its width is controlled via inline style; update the inner div (the element
currently having class "bg-primary-background/15 size-full") to use "h-full"
instead of "size-full" so the intent (full height, variable width) is clearer
and avoids implying the width is fixed.
DrJKL
approved these changes
Jan 23, 2026
Contributor
DrJKL
left a comment
DrJKL
left a comment
There was a problem hiding this comment.
Screenshots would be nice, but 👍🏻
Myestery
pushed a commit
that referenced
this pull request
Jan 23, 2026
- The slider indicator is now only rounded at the ends and doesn't display outside the widget at small values - Prevents a bug where scrubbing would result in a 1/10 chance of causing text selection after a completed scrub. | Before | After | | ------ | ----- | | <img width="360" alt="before" src="https://github.com/user-attachments/assets/94d1a232-4667-4f99-8fce-93567a10b2f3" /> | <img width="360" alt="after" src="https://github.com/user-attachments/assets/66a44109-906f-4c1e-809e-118c9c96eb4a" />| ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-8251-Further-number-widget-fixes-2f06d73d3650811f9548ded527ca16ae) by [Unito](https://www.unito.io)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
┆Issue is synchronized with this Notion page by Unito