Updates: Model Management #8248
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -106,6 +106,16 @@ const zAssetUserMetadata = z.object({ | |
|
|
||
| export type AssetUserMetadata = z.infer<typeof zAssetUserMetadata> | ||
|
|
||
| export const tagsOperationResultSchema = z.object({ | ||
| total_tags: z.array(z.string()), | ||
| added: z.array(z.string()).optional(), | ||
| removed: z.array(z.string()).optional(), | ||
| already_present: z.array(z.string()).optional(), | ||
| not_present: z.array(z.string()).optional() | ||
| }) | ||
|
|
||
| export type TagsOperationResult = z.infer<typeof tagsOperationResultSchema> | ||
|
|
||
| // Legacy interface for backward compatibility (now aligned with Zod schema) | ||
| export interface ModelFolderInfo { | ||
| name: string | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,8 @@ import { st } from '@/i18n' | |
| import { | ||
| assetItemSchema, | ||
| assetResponseSchema, | ||
| asyncUploadResponseSchema, | ||
| tagsOperationResultSchema | ||
| } from '@/platform/assets/schemas/assetSchema' | ||
| import type { | ||
| AssetItem, | ||
|
|
@@ -14,7 +15,8 @@ import type { | |
| AssetUpdatePayload, | ||
| AsyncUploadResponse, | ||
| ModelFile, | ||
| ModelFolder, | ||
| TagsOperationResult | ||
| } from '@/platform/assets/schemas/assetSchema' | ||
| import { api } from '@/scripts/api' | ||
| import { useModelToNodeStore } from '@/stores/modelToNodeStore' | ||
|
|
@@ -471,6 +473,66 @@ function createAssetService() { | |
| return await res.json() | ||
| } | ||
|
|
||
| /** | ||
| * Add tags to an asset | ||
| * @param id - The asset ID (UUID) | ||
| * @param tags - Tags to add | ||
| * @returns Promise<TagsOperationResult> | ||
| */ | ||
| async function addAssetTags( | ||
| id: string, | ||
| tags: string[] | ||
| ): Promise<TagsOperationResult> { | ||
| const res = await api.fetchApi(`${ASSETS_ENDPOINT}/${id}/tags`, { | ||
| method: 'POST', | ||
| headers: { 'Content-Type': 'application/json' }, | ||
| body: JSON.stringify({ tags }) | ||
| }) | ||
|
|
||
| if (!res.ok) { | ||
| throw new Error( | ||
| `Unable to add tags to asset ${id}: Server returned ${res.status}` | ||
| ) | ||
| } | ||
|
|
||
| const result = await res.json() | ||
| const parseResult = tagsOperationResultSchema.safeParse(result) | ||
| if (!parseResult.success) { | ||
| throw fromZodError(parseResult.error) | ||
| } | ||
| return parseResult.data | ||
| } | ||
|
|
||
| /** | ||
| * Remove tags from an asset | ||
| * @param id - The asset ID (UUID) | ||
| * @param tags - Tags to remove | ||
| * @returns Promise<TagsOperationResult> | ||
| */ | ||
| async function removeAssetTags( | ||
| id: string, | ||
| tags: string[] | ||
| ): Promise<TagsOperationResult> { | ||
| const res = await api.fetchApi(`${ASSETS_ENDPOINT}/${id}/tags`, { | ||
| method: 'DELETE', | ||
| headers: { 'Content-Type': 'application/json' }, | ||
| body: JSON.stringify({ tags }) | ||
| }) | ||
|
|
||
| if (!res.ok) { | ||
| throw new Error( | ||
| `Unable to remove tags from asset ${id}: Server returned ${res.status}` | ||
| ) | ||
| } | ||
|
|
||
| const result = await res.json() | ||
| const parseResult = tagsOperationResultSchema.safeParse(result) | ||
| if (!parseResult.success) { | ||
| throw fromZodError(parseResult.error) | ||
| } | ||
| return parseResult.data | ||
| } | ||
coderabbitai[bot] marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| /** | ||
| * Uploads an asset asynchronously using the /api/assets/download endpoint | ||
| * Returns immediately with either the asset (if already exists) or a task to track | ||
|
|
@@ -546,6 +608,8 @@ function createAssetService() { | |
| getAssetsByTag, | ||
| deleteAsset, | ||
| updateAsset, | ||
| addAssetTags, | ||
| removeAssetTags, | ||
| getAssetMetadata, | ||
| uploadAssetFromUrl, | ||
| uploadAssetFromBase64, | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick | 🔵 Trivial
Consider using
vi.hoisted()to enable assertions on clipboard calls.The current mock prevents runtime errors but doesn't expose
copyToClipboardfor test assertions. Since the PR adds click-to-copy functionality, tests should verify the behavior works correctly.♻️ Proposed refactor to enable per-test assertions
Then add tests for the copy functionality:
Based on learnings, using
vi.hoisted()allows per-test manipulation of mock state, which is essential for verifying clipboard interactions.Would you like me to generate complete test cases for the new copy-to-clipboard functionality?
📝 Committable suggestion
🤖 Prompt for AI Agents