Skip to content

[backport cloud/1.37] feat: implement progressive pagination for Asset Browser model assets#8240

Merged
DrJKL merged 1 commit intocloud/1.37from
backport-8212-to-cloud-1.37
Jan 22, 2026
Merged

[backport cloud/1.37] feat: implement progressive pagination for Asset Browser model assets#8240
DrJKL merged 1 commit intocloud/1.37from
backport-8212-to-cloud-1.37

Conversation

@DrJKL
Copy link
Contributor

@DrJKL DrJKL commented Jan 22, 2026

Backport of #8212 to cloud/1.37

┆Issue is synchronized with this Notion page by Unito

@DrJKL DrJKL requested a review from a team as a code owner January 22, 2026 03:53
@DrJKL DrJKL added the backport Backporting a PR onto a release candidate label Jan 22, 2026
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Jan 22, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 22, 2026

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Excluded labels (none allowed) (1)
  • backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Jan 22, 2026

🎨 Storybook Build Status

Build completed successfully!

⏰ Completed at: 01/22/2026, 03:59:05 AM UTC

🔗 Links


🎉 Your Storybook is ready for review!

@github-actions
Copy link

github-actions bot commented Jan 22, 2026

🎭 Playwright Tests: ⚠️ Passed with flaky tests

Results: 502 passed, 0 failed, 2 flaky, 8 skipped (Total: 512)

❌ Failed Tests

📊 Browser Reports
  • chromium: View Report (✅ 492 / ❌ 0 / ⚠️ 1 / ⏭️ 8)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 7 / ❌ 0 / ⚠️ 1 / ⏭️ 0)

…#8212)

Implements progressive pagination for model assets - returns the first
batch immediately while loading remaining batches in the background.

- Adds `ModelPaginationState` tracking (assets Map, offset, hasMore,
loading, error)
- `updateModelsForKey()` returns first batch, then calls
`loadRemainingBatches()` to fetch the rest
- Accessor functions `getAssets(key)`, `isModelLoading(key)` replace
direct Map access

- Adds `PaginationOptions` interface (`{ limit?, offset? }`)

- `AssetBrowserModal.vue` uses new accessor API

- Updated mocks for new accessor pattern

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8212-feat-implement-progressive-pagination-for-Asset-Browser-model-assets-2ef6d73d36508157af04d1264780997e)
by [Unito](https://www.unito.io)

---------

Co-authored-by: Amp <amp@ampcode.com>
@DrJKL DrJKL force-pushed the backport-8212-to-cloud-1.37 branch from a16e431 to a4c0780 Compare January 22, 2026 03:57
@DrJKL DrJKL merged commit eb7d0c7 into cloud/1.37 Jan 22, 2026
25 checks passed
@DrJKL DrJKL deleted the backport-8212-to-cloud-1.37 branch January 22, 2026 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant