-
Notifications
You must be signed in to change notification settings - Fork 491
feat: When a list of strings is received, show all of them. #8195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 01/21/2026, 01:29:28 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
🎭 Playwright Tests:
|
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughChanged preview text assignment in PreviewAny widget to join array inputs with two newlines into a single string; non-array inputs fall back to the original value. Also reformatted a Vue component template without functional changes. Changes
Possibly related PRs
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 22.4 kB (baseline 22.4 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.02 MB (baseline 1.02 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 80.7 kB (baseline 80.7 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed Panels & Settings — 430 kB (baseline 430 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 8 added / 8 removed User & Accounts — 3.94 kB (baseline 3.94 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 3 added / 3 removed Editors & Dialogs — 2.8 kB (baseline 2.8 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 2 added / 2 removed UI Components — 32.8 kB (baseline 32.8 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed Data & Services — 3.04 MB (baseline 3.04 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 7 added / 7 removed Utilities & Hooks — 18.8 kB (baseline 18.8 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 4 added / 4 removed Vendor & Third-Party — 10.4 MB (baseline 10.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 6.25 MB (baseline 6.25 MB) • 🔴 +11 BBundles that do not match a named category
Status: 25 added / 25 removed |
🔧 Auto-fixes AppliedThis PR has been automatically updated to fix linting and formatting issues.
Changes made:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/extensions/core/previewAny.ts`:
- Around line 77-80: Replace the native Array.isArray check in the preview code
with the es-toolkit helper: import isArray from 'es-toolkit/compat' and use
isArray(text) where currently Array.isArray(text) is used (affects the block
setting previewWidget.value and the surrounding logic in previewAny.ts); update
the import section to include isArray and ensure the fallback behavior (joining
array with '\n\n' or returning the string) remains identical.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/platform/assets/components/MediaAssetFilterBar.vue`:
- Line 16: Update the prop binding in MediaAssetFilterBar.vue to use camelCase
shorthand: replace the kebab-case binding ":media-type-filters" with the
same-name camelCase shorthand ":mediaTypeFilters" so the template passes the
mediaTypeFilters prop correctly to the component; locate the template where the
prop is bound and swap the attribute to match the prop name (mediaTypeFilters)
used in the component definition/props.
## Summary Show all of the received strings, double newline separated.
…all of them. (#8196) Backport of #8195 to `cloud/1.37` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-8196-backport-cloud-1-37-feat-When-a-list-of-strings-is-received-show-all-of-them-2ef6d73d36508194a355d34222758435) by [Unito](https://www.unito.io) Co-authored-by: Alexander Brown <drjkl@comfy.org>
…g#8195) ## Summary Show all of the received strings, double newline separated.
Summary
Show all of the received strings, double newline separated.
┆Issue is synchronized with this Notion page by Unito