Fix padding, color, and move to reka-ui popover#8164
Merged
AustinMroz merged 5 commits intomainfrom Jan 20, 2026
Merged
Conversation
dosubot
bot
added
the
size:L
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 01/19/2026, 11:41:25 PM UTC 🔗 Links🎉 Your Storybook is ready for review! |
Contributor
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (19)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the 📝 WalkthroughWalkthroughMoves Popover responsibility from ValueControlPopover into WidgetWithControl: ValueControlPopover is simplified to render inline content; WidgetWithControl now wraps the control button and popover content with a Popover component and uses the Popover trigger slot. Changes
Sequence Diagram(s)mermaid Possibly related PRs
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎭 Playwright Tests:
|
coderabbitai
bot
requested review from
DrJKL,
benceruleanlu and
christian-byrne
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 18.1 kB (baseline 18.1 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 875 kB (baseline 878 kB) • 🟢 -2.81 kBGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 66.6 kB (baseline 66.6 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed Panels & Settings — 385 kB (baseline 385 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 8 added / 8 removed User & Accounts — 4.22 kB (baseline 4.22 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 3 added / 3 removed Editors & Dialogs — 2.85 kB (baseline 2.85 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 2 added / 2 removed UI Components — 26.3 kB (baseline 26.3 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed Data & Services — 2.75 MB (baseline 2.75 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 7 added / 7 removed Utilities & Hooks — 16.6 kB (baseline 16.6 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 4 added / 4 removed Vendor & Third-Party — 9.09 MB (baseline 9.09 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 5.91 MB (baseline 5.91 MB) • 🔴 +2.76 kBBundles that do not match a named category
Status: 25 added / 25 removed |
christian-byrne
added
the
preview-cpu
AustinMroz
added
the
New Browser Test Expectations
|
Updating Playwright Expectations |
github-actions
bot
removed
the
New Browser Test Expectations
Now using our One Button. Has proper hover states, rounded border on one side, and further reduced opacity when disabled
AustinMroz
added
the
New Browser Test Expectations
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Fix all issues with AI agents
In
`@src/renderer/extensions/vueNodes/widgets/components/WidgetInputNumberInput.vue`:
- Around line 266-276: Replace the direct mutation of modelValue in the
increment button click handler with a call to the existing updateValueBy helper
so behavior matches the decrement button and keyboard handlers; specifically
change the `@click` on the increment Button (data-testid="increment",
:disabled="!canIncrement") to call updateValueBy(stepValue) instead of doing
modelValue += stepValue, ensuring any validation/constraints in updateValueBy
are applied consistently.
- Around line 208-218: The decrement Button currently mutates modelValue
directly (modelValue -= stepValue) which bypasses the clamping logic in
updateValueBy; change the click handler to call updateValueBy(-stepValue)
instead so the same min/max bounds and side-effects are applied consistently
(keep Button, data-testid="decrement", :disabled="!canDecrement", stepValue and
updateValueBy references intact).
- Line 6: The file imports a non-existent Button component; replace that import
with the repository-standard icon button by importing IconButton from
'@/components/button/IconButton.vue' and register it in the component's
components object, then update any places using Button (e.g., the
decrement/increment controls in the template or methods referencing Button) to
use IconButton and pass the same props/slots expected by IconButton so styling
and behavior match the design system.
src/renderer/extensions/vueNodes/widgets/components/WidgetInputNumberInput.vue
Show resolved
Hide resolved
src/renderer/extensions/vueNodes/widgets/components/WidgetInputNumberInput.vue
Show resolved
Hide resolved
src/renderer/extensions/vueNodes/widgets/components/WidgetInputNumberInput.vue
Show resolved
Hide resolved
github-actions
bot
removed
the
New Browser Test Expectations
christian-byrne
approved these changes
Jan 20, 2026
godwiniheuwa
pushed a commit
to godwiniheuwa/ComfyUI_frontend
that referenced
this pull request
Jan 22, 2026
- Fixes some options, like decrement, being off center - Fixes button being very hard to see on light themes - Moves the popover to use our fancy new reka-ui Popover component instead of primvue - Since the display control is no longer in the ValueControlPopover, loading is now actually async Most changed lines in `ValueControlPopover` are just indentation. | Before | After | | ------ | ----- | | <img width="360" alt="before" src="https://github.com/user-attachments/assets/5867d70c-a606-4092-a5f8-dd18ecda5b6f" /> | <img width="360" alt="after" src="https://github.com/user-attachments/assets/7bbaf036-77da-4c98-acb0-4b142e4a4761" />| ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-8164-Fix-padding-color-and-move-to-reka-ui-popover-2ed6d73d3650817ea314f04699f1387f) by [Unito](https://www.unito.io) --------- Co-authored-by: github-actions <github-actions@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most changed lines in
ValueControlPopoverare just indentation.┆Issue is synchronized with this Notion page by Unito