Skip to content

feat(canvas): show 'Show Advanced' button on nodes with advanced widgets #8148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christian-byrne merged 2 commits into from
Jan 20, 2026
Merged

feat(canvas): show 'Show Advanced' button on nodes with advanced widgets #8148

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8cce1b4
feat(canvas): show 'Show Advanced' button on nodes with advanced widgets
christian-byrne Jan 18, 2026
8440a6b
fix: remove unnecessary setDirty call and check both widget.advanced …
christian-byrne Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions src/renderer/extensions/vueNodes/components/LGraphNode.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,18 +482,30 @@ const lgraphNode = computed(() => {

const showAdvancedInputsButton = computed(() => {
const node = lgraphNode.value
if (!node || !(node instanceof SubgraphNode)) return false
if (!node) return false

// Check if there are hidden inputs (widgets not promoted)
const interiorNodes = node.subgraph.nodes
const allInteriorWidgets = interiorNodes.flatMap((n) => n.widgets ?? [])
// For subgraph nodes: check for unpromoted widgets
if (node instanceof SubgraphNode) {
const interiorNodes = node.subgraph.nodes
const allInteriorWidgets = interiorNodes.flatMap((n) => n.widgets ?? [])
return allInteriorWidgets.some((w) => !w.computedDisabled && !w.promoted)
}

return allInteriorWidgets.some((w) => !w.computedDisabled && !w.promoted)
// For regular nodes: show button if there are advanced widgets and they're currently hidden
const hasAdvancedWidgets = nodeData.widgets?.some((w) => w.options?.advanced)

@AustinMroz AustinMroz Jan 20, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old, not-very-well-supported advanced option was on the widget directly (widget.advanced). Is migrating to widget.options.advanced intentional?

@christian-byrne christian-byrne Jan 20, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, are there any concerns?

@AustinMroz AustinMroz Jan 20, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

none.

return hasAdvancedWidgets && !node.showAdvanced
})

function handleShowAdvancedInputs() {
const rightSidePanelStore = useRightSidePanelStore()
rightSidePanelStore.focusSection('advanced-inputs')
const node = lgraphNode.value
if (!node) return

if (node instanceof SubgraphNode) {
const rightSidePanelStore = useRightSidePanelStore()
rightSidePanelStore.focusSection('advanced-inputs')
} else {
node.showAdvanced = true
}
}

const nodeMedia = computed(() => {
Expand Down