Skip to content

[backport cloud/1.37] Fix asset selection in litegraph#8119

Merged
christian-byrne merged 1 commit intocloud/1.37from
backport-8117-to-cloud-1.37
Jan 17, 2026
Merged

[backport cloud/1.37] Fix asset selection in litegraph#8119
christian-byrne merged 1 commit intocloud/1.37from
backport-8117-to-cloud-1.37

Conversation

@comfy-pr-bot
Copy link
Member

@comfy-pr-bot comfy-pr-bot commented Jan 17, 2026

Backport of #8117 to cloud/1.37

Automatically created by backport workflow.

┆Issue is synchronized with this Notion page by Unito

#8074 included some refactoring to the asset dialogue to ensure that it
wouldn't pop up multiple times in vue mode

But moving the openModal function to be contained in options means that
`this` is no longer the widget, but instead the options object. This is
fixed by requiring that widget be explicitly passed as a parameter.

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8117-Fix-asset-selection-in-litegraph-2eb6d73d36508176b5a3f6d21964be39)
by [Unito](https://www.unito.io)
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Jan 17, 2026
@comfy-pr-bot comfy-pr-bot requested a review from a team as a code owner January 17, 2026 02:18
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Jan 17, 2026
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 17, 2026
@github-actions
Copy link

github-actions bot commented Jan 17, 2026

🎨 Storybook Build Status

Build completed successfully!

⏰ Completed at: 01/17/2026, 02:19:58 AM UTC

🔗 Links


🎉 Your Storybook is ready for review!

@github-actions
Copy link

github-actions bot commented Jan 17, 2026

🎭 Playwright Tests: ⚠️ Passed with flaky tests

Results: 504 passed, 0 failed, 1 flaky, 8 skipped (Total: 513)

❌ Failed Tests

📊 Browser Reports
  • chromium: View Report (✅ 494 / ❌ 0 / ⚠️ 0 / ⏭️ 8)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 7 / ❌ 0 / ⚠️ 1 / ⏭️ 0)

@christian-byrne christian-byrne merged commit e036d76 into cloud/1.37 Jan 17, 2026
36 of 37 checks passed
@christian-byrne christian-byrne deleted the backport-8117-to-cloud-1.37 branch January 17, 2026 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants