Skip to content

Road to No Explicit Any Part 7: Scripts and Dialog Cleanup #8092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Myestery merged 8 commits into from
Jan 20, 2026
+298 −282
Merged

Road to No Explicit Any Part 7: Scripts and Dialog Cleanup #8092

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
00141c4
fix(api): replace any types with proper TypeScript types
Myestery Jan 16, 2026
7f0f030
fix(types): remove all @ts-expect-error from groupNodeManage.ts
Myestery Jan 16, 2026
5bcf9e7
fix(changeTracker): type nodeOutputs and prompt callback with proper …
Myestery Jan 16, 2026
7321c6e
fix(types): type ComfyDialog and ComfyAsyncDialog properly
Myestery Jan 16, 2026
c1d763a
fix(types): address CodeRabbit review comments
Myestery Jan 16, 2026
ed1dd91
Merge main into fix/remove-any-types-part7
Myestery Jan 16, 2026
7712ada
fix: add schema for custom nodes i18n and simplify storeUserData type
Myestery Jan 17, 2026
66199d4
refactor: simplify merge function to reduce type casts
Myestery Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/extensions/core/groupNode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,7 @@ export class GroupNodeConfig {
}

getNodeDef(
node: GroupNodeData
node: GroupNodeData | GroupNodeWorkflowData['nodes'][number]
): GroupNodeDef | ComfyNodeDef | null | undefined {
if (node.type) {
const def = globalDefs[node.type]
Expand All @@ -386,7 +386,8 @@ export class GroupNodeConfig {
let type: string | number | null = linksFrom[0]?.[0]?.[5] ?? null
if (type === 'COMBO') {
// Use the array items
const source = node.outputs?.[0]?.widget?.name
const output = node.outputs?.[0] as GroupNodeOutput | undefined
Copy link
Contributor

@DrJKL DrJKL Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using type assertions isn't much safer than any

const source = output?.widget?.name
Comment on lines +389 to +390
Copy link
Contributor

@coderabbitai coderabbitai bot Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial

Type assertion is necessary due to unknown[] in workflow data.

Since GroupNodeWorkflowData['nodes'][number]['outputs'] is typed as unknown[], the cast to GroupNodeOutput | undefined is needed to access the widget property. The guarded access pattern (output?.widget?.name) is safer than the previous direct chain access.

Consider whether the outputs type in GroupNodeWorkflowData could be narrowed to GroupNodeOutput[] to eliminate this cast, though that may require broader changes.

🤖 Prompt for AI Agents 
In `@src/extensions/core/groupNode.ts` around lines 389 - 390, The code currently
casts node.outputs?.[0] to GroupNodeOutput | undefined because
GroupNodeWorkflowData['nodes'][number]['outputs'] is typed as unknown[]; keep
this explicit cast (const output = node.outputs?.[0] as GroupNodeOutput |
undefined) and the guarded access (const source = output?.widget?.name) to avoid
runtime errors when accessing widget, and if feasible consider narrowing the
outputs type in GroupNodeWorkflowData to GroupNodeOutput[] across the workflow
typings to remove the need for the cast.

const nodeIdx = linksFrom[0]?.[0]?.[2]
if (source && nodeIdx != null) {
const fromTypeName = this.nodeData.nodes[Number(nodeIdx)]?.type
Expand Down
Loading