-
Notifications
You must be signed in to change notification settings - Fork 490
feat: add per-tab workspace authentication infrastructure #8073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
1a92e9d
feat: add per-tab workspace authentication infrastructure
christian-byrne 6f36d3a
feat: gate workspace auth behind team_workspaces_enabled feature flag
christian-byrne 2549440
refactor: export WORKSPACE_STORAGE_KEYS constant for shared use
christian-byrne 9f44d20
fix: add missing afterEach import in useWorkspaceAuth.test.ts
christian-byrne 53fbe86
refactor: consolidate initial state tests into single test
christian-byrne 5c15818
fix: add Zod validation for API response and validate expires_at
christian-byrne 6240acc
fix: validate workspace data in initializeFromSession
christian-byrne e0a3bc3
feat: add i18n keys for workspace auth and unsaved changes dialog
christian-byrne 3f24155
fix: use vi.hoisted() for mock variables in useWorkspaceSwitch.test.ts
christian-byrne b9b9d96
test: add edge case test for isAuthenticated when token is null
christian-byrne afe6129
fix: add JSDoc and runtime guard for component setup context
christian-byrne 175647a
fix: add exponential backoff retry for refreshToken transient failures
christian-byrne aeb77cc
chore: remove unused WorkspaceTokenResponse interface
christian-byrne 9e7d8e3
refactor: use VueUse useTimeoutFn, improve refreshToken error handlin…
christian-byrne 9a04df5
refactor(auth): convert useWorkspaceAuth to Pinia store and fix auth …
christian-byrne f22e4f0
refactor: remove useWorkspaceAuth wrapper, use store directly
christian-byrne 401557c
fix(auth): clear workspace on logout and prevent stale refresh races
simula-r 29d84fc
chore: remove temporary documentation files
simula-r 24e7d95
fix(auth): check all workflows for unsaved changes on workspace switch
simula-r File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion | 🟠 Major
Return the watcher stop handle to allow cleanup.
watch()returns a disposer; exposing it avoids lingering subscriptions whenonUserLogoutis used outside a component scope or registered multiple times. Based on learnings, consider returning the stop handle for cleanup.♻️ Proposed fix
📝 Committable suggestion
🤖 Prompt for AI Agents