refactor: centralized node mode management to layoutStore #8045
Conversation
LittleSound
requested review from
a team,
Myestery and
jtydhr88
as code owners
dosubot
bot
added
the
size:L
📝 WalkthroughWalkthroughMigrates node mode state management from direct property mutations to a centralized layoutStore system. Adds mode field to NodeLayout with synchronization support, patches LGraphNode.changeMode for store integration, and updates UI components to leverage the store for multi-node operations. Changes
Sequence DiagramsequenceDiagram
participant UI as Right-side Panel
participant Store as layoutStore
participant Patch as patchLGraphNodeMode
participant LNode as LGraphNode
participant Sync as useLayoutSync
UI->>Store: setNodesMode(nodeIds, newMode)
Store->>Store: handleSetNodeMode (update CRDT)
Store->>Store: emit SetNodeModeOperation
LNode->>LNode: changeMode(newMode) [direct call]
activate Patch
Patch->>LNode: intercept changeMode
Patch->>Store: setNodeMode(nodeId, newMode)
Patch->>LNode: call original changeMode
deactivate Patch
Sync->>LNode: read layout.mode
Sync->>LNode: liteNode.changeMode(layout.mode)
LNode->>Patch: changeMode triggers patch
Patch->>Store: sync back to layoutStore
Possibly Related PRs
Suggested Reviewers
✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 01/14/2026, 12:43:19 PM UTC 🔗 Links🎉 Your Storybook is ready for review! |
🎭 Playwright Tests: ❌ FailedResults: 493 passed, 5 failed, 2 flaky, 8 skipped (Total: 508) ❌ Failed Tests📊 Browser Reports
|
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 3.34 MB (baseline 3.34 MB) • 🔴 +2.14 kBMain entry bundles and manifests
Status: 3 added / 3 removed Graph Workspace — 1.15 MB (baseline 1.15 MB) • 🔴 +907 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 6.66 kB (baseline 6.66 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 1 added / 1 removed Panels & Settings — 372 kB (baseline 372 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 6 added / 6 removed UI Components — 209 kB (baseline 209 kB) • ⚪ 0 BReusable component library chunks
Status: 8 added / 8 removed Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 2 added / 2 removed Utilities & Hooks — 1.41 kB (baseline 1.41 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 1 added / 1 removed Vendor & Third-Party — 9.34 MB (baseline 9.34 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 5.25 MB (baseline 5.25 MB) • ⚪ 0 BBundles that do not match a named category
Status: 16 added / 16 removed |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Fix all issues with AI agents
In `@src/composables/canvas/useSelectedLiteGraphItems.ts`:
- Line 148: The loop currently calls layoutStore.setNodeMode(node.id.toString(),
newModeForSelectedNode) for each child which is inefficient for large subgraphs;
modify the traversal in useSelectedLiteGraphItems.ts to collect a map/object of
child node IDs to newModeForSelectedNode (use node.id.toString() as the key) and
after traversal call layoutStore.setNodesMode(collectedMap) once; keep the
existing per-node logic to determine newModeForSelectedNode but replace
individual setNodeMode calls with building the map and a single batch
setNodesMode call.
In `@src/extensions/core/groupOptions.ts`:
- Around line 16-18: The current setNodeMode(node: LGraphNode, mode: number)
delegates to layoutStore.setNodeMode for single-node updates; when you change
mode for an entire group, replace the per-node loop with a single batch call to
layoutStore.setNodesMode(idsArray, mode) to avoid repetitive store writes—keep
setNodeMode for individual updates but modify the group callbacks (where you
currently iterate nodes and call setNodeMode) to collect node.id strings into an
array and call layoutStore.setNodesMode once with that array and the new mode.
In `@src/renderer/core/layout/store/layoutStore.ts`:
- Around line 1487-1499: The setNodesMode method currently calls setNodeMode for
each node causing N operations/notifications; replace this with a single batched
operation following the batchUpdateNodeBounds pattern: create a
BatchSetNodeModeOperation (or similar) that takes nodeIds and mode, applies mode
to each node in one atomic update, increments the store version once, and emits
a single change/notification; update setNodesMode to construct and push/commit
that batch operation (refer to setNodesMode, setNodeMode, batchUpdateNodeBounds,
and the new BatchSetNodeModeOperation) so large selections perform efficiently.
In `@src/renderer/core/layout/utils/mappers.ts`:
- Line 13: Replace the magic number assignment "mode: 0" in the mapper object
with the enum value LGraphEventMode.ALWAYS and add an import for LGraphEventMode
from "@/lib/litegraph/src/litegraph"; locate the occurrence of "mode: 0" in
mappers.ts and change it to "mode: LGraphEventMode.ALWAYS", then add the named
import (or extend an existing import) for LGraphEventMode at the top of the file
so the enum is referenced instead of the hardcoded 0.
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (16)
src/components/rightSidePanel/settings/SetNodeState.vuesrc/composables/canvas/useSelectedLiteGraphItems.test.tssrc/composables/canvas/useSelectedLiteGraphItems.tssrc/composables/graph/useVueNodeLifecycle.tssrc/extensions/core/groupOptions.tssrc/lib/litegraph/src/LGraphNode.tssrc/renderer/core/layout/operations/layoutMutations.tssrc/renderer/core/layout/store/layoutStore.test.tssrc/renderer/core/layout/store/layoutStore.tssrc/renderer/core/layout/sync/patchLGraphNodeMode.tssrc/renderer/core/layout/sync/useLayoutSync.tssrc/renderer/core/layout/types.tssrc/renderer/core/layout/utils/layoutMath.test.tssrc/renderer/core/layout/utils/mappers.tssrc/renderer/extensions/minimap/data/MinimapDataSource.test.tssrc/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.ts
🧰 Additional context used
📓 Path-based instructions (18)
src/**/*.{vue,ts}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json
Files:
src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.tssrc/renderer/core/layout/sync/patchLGraphNodeMode.tssrc/composables/canvas/useSelectedLiteGraphItems.test.tssrc/renderer/core/layout/store/layoutStore.test.tssrc/renderer/core/layout/operations/layoutMutations.tssrc/extensions/core/groupOptions.tssrc/renderer/extensions/minimap/data/MinimapDataSource.test.tssrc/renderer/core/layout/sync/useLayoutSync.tssrc/composables/canvas/useSelectedLiteGraphItems.tssrc/components/rightSidePanel/settings/SetNodeState.vuesrc/lib/litegraph/src/LGraphNode.tssrc/renderer/core/layout/utils/mappers.tssrc/renderer/core/layout/utils/layoutMath.test.tssrc/composables/graph/useVueNodeLifecycle.tssrc/renderer/core/layout/types.tssrc/renderer/core/layout/store/layoutStore.ts
src/**/*.ts
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.ts: Use es-toolkit for utility functions
Use TypeScript for type safety
src/**/*.ts: Derive component types usingvue-component-type-helpers(ComponentProps,ComponentSlots) instead of separate type files
Use es-toolkit for utility functions
Minimize the surface area (exported values) of each module and composable
Favor pure functions, especially testable ones
Files:
src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.tssrc/renderer/core/layout/sync/patchLGraphNodeMode.tssrc/composables/canvas/useSelectedLiteGraphItems.test.tssrc/renderer/core/layout/store/layoutStore.test.tssrc/renderer/core/layout/operations/layoutMutations.tssrc/extensions/core/groupOptions.tssrc/renderer/extensions/minimap/data/MinimapDataSource.test.tssrc/renderer/core/layout/sync/useLayoutSync.tssrc/composables/canvas/useSelectedLiteGraphItems.tssrc/lib/litegraph/src/LGraphNode.tssrc/renderer/core/layout/utils/mappers.tssrc/renderer/core/layout/utils/layoutMath.test.tssrc/composables/graph/useVueNodeLifecycle.tssrc/renderer/core/layout/types.tssrc/renderer/core/layout/store/layoutStore.ts
src/**/{services,composables}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (src/CLAUDE.md)
src/**/{services,composables}/**/*.{ts,tsx}: Useapi.apiURL()for backend endpoints instead of constructing URLs directly
Useapi.fileURL()for static file access instead of constructing URLs directly
Files:
src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.tssrc/composables/canvas/useSelectedLiteGraphItems.test.tssrc/composables/canvas/useSelectedLiteGraphItems.tssrc/composables/graph/useVueNodeLifecycle.ts
src/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using@ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebase
src/**/*.{ts,tsx,vue}: Use separateimport typestatements instead of inlinetypein mixed imports
Apply Prettier formatting with 2-space indentation, single quotes, no trailing semicolons, 80-character width
Sort and group imports by plugin, runpnpm formatbefore committing
Never useanytype - use proper TypeScript types
Never useas anytype assertions - fix the underlying type issue
Write code that is expressive and self-documenting - avoid unnecessary comments
Do not add or retain redundant comments - clean as you go
Avoid mutable state - prefer immutability and assignment at point of declaration
Watch out for Code Smells and refactor to avoid them
Files:
src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.tssrc/renderer/core/layout/sync/patchLGraphNodeMode.tssrc/composables/canvas/useSelectedLiteGraphItems.test.tssrc/renderer/core/layout/store/layoutStore.test.tssrc/renderer/core/layout/operations/layoutMutations.tssrc/extensions/core/groupOptions.tssrc/renderer/extensions/minimap/data/MinimapDataSource.test.tssrc/renderer/core/layout/sync/useLayoutSync.tssrc/composables/canvas/useSelectedLiteGraphItems.tssrc/components/rightSidePanel/settings/SetNodeState.vuesrc/lib/litegraph/src/LGraphNode.tssrc/renderer/core/layout/utils/mappers.tssrc/renderer/core/layout/utils/layoutMath.test.tssrc/composables/graph/useVueNodeLifecycle.tssrc/renderer/core/layout/types.tssrc/renderer/core/layout/store/layoutStore.ts
src/**/{composables,components}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Clean up subscriptions in state management to prevent memory leaks
Files:
src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.tssrc/composables/canvas/useSelectedLiteGraphItems.test.tssrc/composables/canvas/useSelectedLiteGraphItems.tssrc/components/rightSidePanel/settings/SetNodeState.vuesrc/composables/graph/useVueNodeLifecycle.ts
src/**/*.{vue,ts,tsx}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Follow Vue 3 composition API style guide
Files:
src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.tssrc/renderer/core/layout/sync/patchLGraphNodeMode.tssrc/composables/canvas/useSelectedLiteGraphItems.test.tssrc/renderer/core/layout/store/layoutStore.test.tssrc/renderer/core/layout/operations/layoutMutations.tssrc/extensions/core/groupOptions.tssrc/renderer/extensions/minimap/data/MinimapDataSource.test.tssrc/renderer/core/layout/sync/useLayoutSync.tssrc/composables/canvas/useSelectedLiteGraphItems.tssrc/components/rightSidePanel/settings/SetNodeState.vuesrc/lib/litegraph/src/LGraphNode.tssrc/renderer/core/layout/utils/mappers.tssrc/renderer/core/layout/utils/layoutMath.test.tssrc/composables/graph/useVueNodeLifecycle.tssrc/renderer/core/layout/types.tssrc/renderer/core/layout/store/layoutStore.ts
src/**/{components,composables}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Use vue-i18n for ALL user-facing strings by adding them to
src/locales/en/main.json
Files:
src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.tssrc/composables/canvas/useSelectedLiteGraphItems.test.tssrc/composables/canvas/useSelectedLiteGraphItems.tssrc/components/rightSidePanel/settings/SetNodeState.vuesrc/composables/graph/useVueNodeLifecycle.ts
+(tests-ui|src)/**/*.test.ts
📄 CodeRabbit inference engine (AGENTS.md)
+(tests-ui|src)/**/*.test.ts: Unit and component tests belong intests-ui/orsrc/**/*.test.tsusing Vitest
Write tests for all changes, especially bug fixes to catch future regressions
Do not write tests dependent on non-behavioral features like utility classes or styles
Do not write tests that just test the mocks - ensure tests fail when code behaves unexpectedly
Leverage Vitest's utilities for mocking where possible
Keep module mocks contained - do not use global mutable state within test files; usevi.hoisted()if necessary
Use Vue Test Utils for Component testing and follow best practices for making components easy to test
Aim for behavioral coverage of critical and new features in unit tests
Files:
src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.tssrc/composables/canvas/useSelectedLiteGraphItems.test.tssrc/renderer/core/layout/store/layoutStore.test.tssrc/renderer/extensions/minimap/data/MinimapDataSource.test.tssrc/renderer/core/layout/utils/layoutMath.test.ts
src/**/*.{ts,vue}
📄 CodeRabbit inference engine (AGENTS.md)
src/**/*.{ts,vue}: Usereffor reactive state,computed()for derived values, andwatch/watchEffectfor side effects in Composition API
Avoid usingrefwithwatchif acomputedwould suffice - minimize refs and derived state
Useprovide/injectfor dependency injection only when simpler alternatives (Store or shared composable) won't work
Leverage VueUse functions for performance-enhancing composables
Use VueUse function for useI18n in composition API for string literals
Files:
src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.tssrc/renderer/core/layout/sync/patchLGraphNodeMode.tssrc/composables/canvas/useSelectedLiteGraphItems.test.tssrc/renderer/core/layout/store/layoutStore.test.tssrc/renderer/core/layout/operations/layoutMutations.tssrc/extensions/core/groupOptions.tssrc/renderer/extensions/minimap/data/MinimapDataSource.test.tssrc/renderer/core/layout/sync/useLayoutSync.tssrc/composables/canvas/useSelectedLiteGraphItems.tssrc/components/rightSidePanel/settings/SetNodeState.vuesrc/lib/litegraph/src/LGraphNode.tssrc/renderer/core/layout/utils/mappers.tssrc/renderer/core/layout/utils/layoutMath.test.tssrc/composables/graph/useVueNodeLifecycle.tssrc/renderer/core/layout/types.tssrc/renderer/core/layout/store/layoutStore.ts
src/**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
src/**/*.{ts,tsx}: Keep functions short and functional
Minimize nesting (if statements, for loops, etc.)
Use function declarations instead of function expressions when possible
Files:
src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.tssrc/renderer/core/layout/sync/patchLGraphNodeMode.tssrc/composables/canvas/useSelectedLiteGraphItems.test.tssrc/renderer/core/layout/store/layoutStore.test.tssrc/renderer/core/layout/operations/layoutMutations.tssrc/extensions/core/groupOptions.tssrc/renderer/extensions/minimap/data/MinimapDataSource.test.tssrc/renderer/core/layout/sync/useLayoutSync.tssrc/composables/canvas/useSelectedLiteGraphItems.tssrc/lib/litegraph/src/LGraphNode.tssrc/renderer/core/layout/utils/mappers.tssrc/renderer/core/layout/utils/layoutMath.test.tssrc/composables/graph/useVueNodeLifecycle.tssrc/renderer/core/layout/types.tssrc/renderer/core/layout/store/layoutStore.ts
+(tests-ui|src|browser_tests)/**/*.+(test.ts|spec.ts)
📄 CodeRabbit inference engine (AGENTS.md)
+(tests-ui|src|browser_tests)/**/*.+(test.ts|spec.ts): Do not write change detector tests - avoid tests that only assert default values
Be parsimonious in testing - do not write redundant tests
Don't Mock What You Don't Own
Files:
src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.tssrc/composables/canvas/useSelectedLiteGraphItems.test.tssrc/renderer/core/layout/store/layoutStore.test.tssrc/renderer/extensions/minimap/data/MinimapDataSource.test.tssrc/renderer/core/layout/utils/layoutMath.test.ts
src/composables/**/*.ts
📄 CodeRabbit inference engine (AGENTS.md)
Name composables as
useXyz.ts(e.g.,useForm.ts)
Files:
src/composables/canvas/useSelectedLiteGraphItems.test.tssrc/composables/canvas/useSelectedLiteGraphItems.tssrc/composables/graph/useVueNodeLifecycle.ts
src/**/*.vue
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.vue: Use the Vue 3 Composition API instead of the Options API when writing Vue components (exception: when overriding or extending PrimeVue components for compatibility)
Use setup() function for component logic
Utilize ref and reactive for reactive state
Implement computed properties with computed()
Use watch and watchEffect for side effects
Implement lifecycle hooks with onMounted, onUpdated, etc.
Utilize provide/inject for dependency injection
Use vue 3.5 style of default prop declaration
Use Tailwind CSS for styling
Implement proper props and emits definitions
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Follow Vue 3 style guide and naming conventions
src/**/*.vue: Use Vue 3 Single File Components (SFCs) with Composition API only
Use<script setup lang="ts">for component logic in Vue SFCs
Avoid<style>blocks in Vue components - use Tailwind 4 styling instead
Use vue-i18n for all string literals in Vue components - place translation entries insrc/locales/en/main.json
Use Tailwind utility classes instead ofdark:variant - use semantic values fromstyle.csstheme (e.g.,bg-node-component-surface)
Usecn()utility from@/utils/tailwindUtilfor merging Tailwind class names instead of:class="[]"or hardcoding
Never use!importantor!Tailwind prefix - fix interfering classes instead
Use Tailwind fraction utilities instead of arbitrary percentage values (e.g.,w-4/5instead ofw-[80%])
Use TypeScript Vue 3.5 style default prop declaration with reactive props destructuring - avoidwithDefaultsor runtime props
PreferdefineModelover separately defining a prop and emit for v-model bindings
Define slots via template usage, not viadefineSlots
Use same-name shorthand for slot prop bindings (e.g.,:isExpandedinstead of:is-expanded="isExpanded")
Do not import Vue macros unnecessarily
Avoid new usage of PrimeVue components
Use Tailwind's plurals system via i18n instead of hardcoding ...
Files:
src/components/rightSidePanel/settings/SetNodeState.vue
src/components/**/*.vue
📄 CodeRabbit inference engine (src/components/CLAUDE.md)
src/components/**/*.vue: Use setup() function in Vue 3 Composition API
Destructure props using Vue 3.5 style in Vue components
Use ref/reactive for state management in Vue 3 Composition API
Implement computed() for derived state in Vue 3 Composition API
Use provide/inject for dependency injection in Vue components
Prefer emit/@event-name for state changes over other communication patterns
Use defineExpose only for imperative operations (such as form.validate(), modal.open())
Replace PrimeVue Dropdown component with Select
Replace PrimeVue OverlayPanel component with Popover
Replace PrimeVue Calendar component with DatePicker
Replace PrimeVue InputSwitch component with ToggleSwitch
Replace PrimeVue Sidebar component with Drawer
Replace PrimeVue Chips component with AutoComplete with multiple enabled
Replace PrimeVue TabMenu component with Tabs without panels
Replace PrimeVue Steps component with Stepper without panels
Replace PrimeVue InlineMessage component with Message
Extract complex conditionals to computed properties
Implement cleanup for async operations in Vue components
Use lifecycle hooks: onMounted, onUpdated in Vue 3 Composition API
Use Teleport/Suspense when needed for component rendering
Define proper props and emits definitions in Vue componentsName Vue components in PascalCase (e.g.,
MenuHamburger.vue)
Files:
src/components/rightSidePanel/settings/SetNodeState.vue
src/components/**/*.{vue,css}
📄 CodeRabbit inference engine (src/components/CLAUDE.md)
src/components/**/*.{vue,css}: Use Tailwind CSS only for styling (no custom CSS)
Use the correct tokens from style.css in the design system package
Files:
src/components/rightSidePanel/settings/SetNodeState.vue
src/components/**/*.{vue,ts,js}
📄 CodeRabbit inference engine (src/components/CLAUDE.md)
src/components/**/*.{vue,ts,js}: Use existing VueUse composables (such as useElementHover) instead of manually managing event listeners
Use useIntersectionObserver for visibility detection instead of custom scroll handlers
Use vue-i18n for ALL UI strings
Files:
src/components/rightSidePanel/settings/SetNodeState.vue
src/lib/litegraph/**/*.{js,ts,jsx,tsx}
📄 CodeRabbit inference engine (src/lib/litegraph/CLAUDE.md)
src/lib/litegraph/**/*.{js,ts,jsx,tsx}: Run ESLint instead of manually figuring out whitespace fixes or other trivial style concerns using thepnpm lint:fixcommand
Take advantage ofTypedArraysubarraywhen appropriate
Thesizeandposproperties ofRectangleshare the same array buffer (subarray); they may be used to set the rectangle's size and position
Prefer single lineifsyntax over adding curly braces, when the statement has a very concise expression and concise, single line statement
Do not replace&&=or||=with=when there is no reason to do so. If you do find a reason to remove either&&=or||=, leave a comment explaining why the removal occurred
When writing methods, prefer returning idiomatic JavaScriptundefinedovernull
Files:
src/lib/litegraph/src/LGraphNode.ts
src/lib/litegraph/**/*.{ts,tsx}
📄 CodeRabbit inference engine (src/lib/litegraph/CLAUDE.md)
Type assertions are an absolute last resort. In almost all cases, they are a crutch that leads to brittle code
Files:
src/lib/litegraph/src/LGraphNode.ts
🧠 Learnings (39)
📚 Learning: 2025-11-24T19:47:56.371Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/lib/litegraph/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:56.371Z
Learning: Applies to src/lib/litegraph/**/*.{test,spec}.{ts,tsx} : Use provided test helpers `createTestSubgraph` and `createTestSubgraphNode` from `./fixtures/subgraphHelpers` for consistent subgraph test setup
Applied to files:
src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.tssrc/composables/canvas/useSelectedLiteGraphItems.test.tssrc/renderer/extensions/minimap/data/MinimapDataSource.test.tssrc/composables/canvas/useSelectedLiteGraphItems.tssrc/lib/litegraph/src/LGraphNode.tssrc/renderer/core/layout/utils/layoutMath.test.tssrc/composables/graph/useVueNodeLifecycle.ts
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to +(tests-ui|src)/**/*.test.ts : Leverage Vitest's utilities for mocking where possible
Applied to files:
src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.ts
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to +(tests-ui|src)/**/*.test.ts : Keep module mocks contained - do not use global mutable state within test files; use `vi.hoisted()` if necessary
Applied to files:
src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.tssrc/renderer/extensions/minimap/data/MinimapDataSource.test.ts
📚 Learning: 2026-01-09T02:07:54.558Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7898
File: src/composables/usePaste.test.ts:248-248
Timestamp: 2026-01-09T02:07:54.558Z
Learning: In test files (e.g., any .test.ts or .test.tsx under src/...), when you create mock objects that partially implement an interface (such as LGraphNode), prefer casting with as Partial<InterfaceType> as InterfaceType rather than as any or as unknown as InterfaceType. This makes the incomplete implementation explicit while preserving type safety, improving readability and maintainability of tests.
Applied to files:
src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.tssrc/composables/canvas/useSelectedLiteGraphItems.test.tssrc/renderer/core/layout/store/layoutStore.test.tssrc/renderer/extensions/minimap/data/MinimapDataSource.test.tssrc/renderer/core/layout/utils/layoutMath.test.ts
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to +(tests-ui|src|browser_tests)/**/*.+(test.ts|spec.ts) : Do not write change detector tests - avoid tests that only assert default values
Applied to files:
src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.tssrc/renderer/core/layout/utils/layoutMath.test.ts
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to +(tests-ui|src)/**/*.test.ts : Write tests for all changes, especially bug fixes to catch future regressions
Applied to files:
src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.tssrc/composables/canvas/useSelectedLiteGraphItems.test.tssrc/renderer/core/layout/utils/layoutMath.test.ts
📚 Learning: 2026-01-08T02:40:15.482Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7894
File: src/renderer/extensions/vueNodes/widgets/components/WidgetToggleSwitch.test.ts:11-14
Timestamp: 2026-01-08T02:40:15.482Z
Learning: In TypeScript test files (e.g., any test under src), avoid duplicating interface/type definitions. Import real type definitions from the component modules under test and reference them directly, so there is a single source of truth and to prevent type drift. This improves maintainability and consistency across tests.
Applied to files:
src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.tssrc/composables/canvas/useSelectedLiteGraphItems.test.tssrc/renderer/core/layout/store/layoutStore.test.tssrc/renderer/extensions/minimap/data/MinimapDataSource.test.tssrc/renderer/core/layout/utils/layoutMath.test.ts
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to +(tests-ui|src)/**/*.test.ts : Do not write tests that just test the mocks - ensure tests fail when code behaves unexpectedly
Applied to files:
src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.ts
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to +(tests-ui|src)/**/*.test.ts : Use Vue Test Utils for Component testing and follow best practices for making components easy to test
Applied to files:
src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.ts
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to +(tests-ui|src|browser_tests)/**/*.+(test.ts|spec.ts) : Don't Mock What You Don't Own
Applied to files:
src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.ts
📚 Learning: 2025-12-09T03:39:54.501Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7169
File: src/platform/remote/comfyui/jobs/jobTypes.ts:1-107
Timestamp: 2025-12-09T03:39:54.501Z
Learning: In the ComfyUI_frontend project, Zod is on v3.x. Do not suggest Zod v4 standalone validators (z.uuid, z.ulid, z.cuid2, z.nanoid) until an upgrade to Zod 4 is performed. When reviewing TypeScript files (e.g., src/platform/remote/comfyui/jobs/jobTypes.ts) validate against Zod 3 capabilities and avoid introducing v4-specific features; flag any proposal to upgrade or incorporate v4-only validators and propose staying with compatible 3.x patterns.
Applied to files:
src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.tssrc/renderer/core/layout/sync/patchLGraphNodeMode.tssrc/composables/canvas/useSelectedLiteGraphItems.test.tssrc/renderer/core/layout/store/layoutStore.test.tssrc/renderer/core/layout/operations/layoutMutations.tssrc/extensions/core/groupOptions.tssrc/renderer/extensions/minimap/data/MinimapDataSource.test.tssrc/renderer/core/layout/sync/useLayoutSync.tssrc/composables/canvas/useSelectedLiteGraphItems.tssrc/lib/litegraph/src/LGraphNode.tssrc/renderer/core/layout/utils/mappers.tssrc/renderer/core/layout/utils/layoutMath.test.tssrc/composables/graph/useVueNodeLifecycle.tssrc/renderer/core/layout/types.tssrc/renderer/core/layout/store/layoutStore.ts
📚 Learning: 2025-12-13T11:03:11.264Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7416
File: src/stores/imagePreviewStore.ts:5-7
Timestamp: 2025-12-13T11:03:11.264Z
Learning: In the ComfyUI_frontend repository, lint rules require keeping 'import type' statements separate from non-type imports, even if importing from the same module. Do not suggest consolidating them into a single import statement. Ensure type imports remain on their own line (import type { ... } from 'module') and regular imports stay on separate lines.
Applied to files:
src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.tssrc/renderer/core/layout/sync/patchLGraphNodeMode.tssrc/composables/canvas/useSelectedLiteGraphItems.test.tssrc/renderer/core/layout/store/layoutStore.test.tssrc/renderer/core/layout/operations/layoutMutations.tssrc/extensions/core/groupOptions.tssrc/renderer/extensions/minimap/data/MinimapDataSource.test.tssrc/renderer/core/layout/sync/useLayoutSync.tssrc/composables/canvas/useSelectedLiteGraphItems.tssrc/lib/litegraph/src/LGraphNode.tssrc/renderer/core/layout/utils/mappers.tssrc/renderer/core/layout/utils/layoutMath.test.tssrc/composables/graph/useVueNodeLifecycle.tssrc/renderer/core/layout/types.tssrc/renderer/core/layout/store/layoutStore.ts
📚 Learning: 2025-12-17T00:40:09.635Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.stories.ts:45-55
Timestamp: 2025-12-17T00:40:09.635Z
Learning: Prefer pure function declarations over function expressions (e.g., use function foo() { ... } instead of const foo = () => { ... }) for pure functions in the repository. Function declarations are more functional-leaning, offer better hoisting clarity, and can improve readability and tooling consistency. Apply this guideline across TypeScript files in Comfy-Org/ComfyUI_frontend, including story and UI component code, except where a function expression is semantically required (e.g., callbacks, higher-order functions with closures).
Applied to files:
src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.tssrc/renderer/core/layout/sync/patchLGraphNodeMode.tssrc/composables/canvas/useSelectedLiteGraphItems.test.tssrc/renderer/core/layout/store/layoutStore.test.tssrc/renderer/core/layout/operations/layoutMutations.tssrc/extensions/core/groupOptions.tssrc/renderer/extensions/minimap/data/MinimapDataSource.test.tssrc/renderer/core/layout/sync/useLayoutSync.tssrc/composables/canvas/useSelectedLiteGraphItems.tssrc/lib/litegraph/src/LGraphNode.tssrc/renderer/core/layout/utils/mappers.tssrc/renderer/core/layout/utils/layoutMath.test.tssrc/composables/graph/useVueNodeLifecycle.tssrc/renderer/core/layout/types.tssrc/renderer/core/layout/store/layoutStore.ts
📚 Learning: 2025-12-30T22:22:33.836Z
Learnt from: kaili-yang
Repo: Comfy-Org/ComfyUI_frontend PR: 7805
File: src/composables/useCoreCommands.ts:439-439
Timestamp: 2025-12-30T22:22:33.836Z
Learning: When accessing reactive properties from Pinia stores in TypeScript files, avoid using .value on direct property access (e.g., useStore().isOverlayExpanded). Pinia auto-wraps refs when accessed directly, returning the primitive value. The .value accessor is only needed when destructuring store properties or when using storeToRefs().
Applied to files:
src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.tssrc/renderer/core/layout/sync/patchLGraphNodeMode.tssrc/composables/canvas/useSelectedLiteGraphItems.test.tssrc/renderer/core/layout/store/layoutStore.test.tssrc/renderer/core/layout/operations/layoutMutations.tssrc/extensions/core/groupOptions.tssrc/renderer/extensions/minimap/data/MinimapDataSource.test.tssrc/renderer/core/layout/sync/useLayoutSync.tssrc/composables/canvas/useSelectedLiteGraphItems.tssrc/lib/litegraph/src/LGraphNode.tssrc/renderer/core/layout/utils/mappers.tssrc/renderer/core/layout/utils/layoutMath.test.tssrc/composables/graph/useVueNodeLifecycle.tssrc/renderer/core/layout/types.tssrc/renderer/core/layout/store/layoutStore.ts
📚 Learning: 2025-12-10T03:09:13.807Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7303
File: src/components/topbar/CurrentUserPopover.test.ts:199-205
Timestamp: 2025-12-10T03:09:13.807Z
Learning: In test files, prefer selecting or asserting on accessible properties (text content, aria-label, role, accessible name) over data-testid attributes. This ensures tests validate actual user-facing behavior and accessibility, reducing reliance on implementation details like test IDs.
Applied to files:
src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.tssrc/composables/canvas/useSelectedLiteGraphItems.test.tssrc/renderer/core/layout/store/layoutStore.test.tssrc/renderer/extensions/minimap/data/MinimapDataSource.test.tssrc/renderer/core/layout/utils/layoutMath.test.ts
📚 Learning: 2025-12-30T01:31:04.927Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7797
File: tests-ui/tests/lib/litegraph/src/widgets/ComboWidget.test.ts:648-648
Timestamp: 2025-12-30T01:31:04.927Z
Learning: In Vitest v4, when mocking functions that may be called as constructors (using new), the mock implementation must use function() or class syntax rather than an arrow function. Arrow mocks can cause '<anonymous> is not a constructor' errors. This is a breaking change from Vitest v3 where mocks could use an arrow function. Apply this guideline to test files that mock constructor-like calls (e.g., in tests under tests-ui, such as ComboWidget.test.ts) and ensure mock implementations are defined with function() { ... } or class { ... } to preserve constructor behavior.
Applied to files:
src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.tssrc/composables/canvas/useSelectedLiteGraphItems.test.tssrc/renderer/core/layout/store/layoutStore.test.tssrc/renderer/extensions/minimap/data/MinimapDataSource.test.tssrc/renderer/core/layout/utils/layoutMath.test.ts
📚 Learning: 2025-12-11T12:25:15.470Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:15.470Z
Learning: This repository uses CI automation to format code (pnpm format). Do not include manual formatting suggestions in code reviews for Comfy-Org/ComfyUI_frontend. If formatting issues are detected, rely on the CI formatter or re-run pnpm format. Focus reviews on correctness, readability, performance, accessibility, and maintainability rather than style formatting.
Applied to files:
src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.tssrc/renderer/core/layout/sync/patchLGraphNodeMode.tssrc/composables/canvas/useSelectedLiteGraphItems.test.tssrc/renderer/core/layout/store/layoutStore.test.tssrc/renderer/core/layout/operations/layoutMutations.tssrc/extensions/core/groupOptions.tssrc/renderer/extensions/minimap/data/MinimapDataSource.test.tssrc/renderer/core/layout/sync/useLayoutSync.tssrc/composables/canvas/useSelectedLiteGraphItems.tssrc/components/rightSidePanel/settings/SetNodeState.vuesrc/lib/litegraph/src/LGraphNode.tssrc/renderer/core/layout/utils/mappers.tssrc/renderer/core/layout/utils/layoutMath.test.tssrc/composables/graph/useVueNodeLifecycle.tssrc/renderer/core/layout/types.tssrc/renderer/core/layout/store/layoutStore.ts
📚 Learning: 2026-01-12T17:39:27.738Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7906
File: src/components/sidebar/tabs/AssetsSidebarTab.vue:545-552
Timestamp: 2026-01-12T17:39:27.738Z
Learning: In Vue/TypeScript files (src/**/*.{ts,tsx,vue}), prefer if/else statements over ternary operators when performing side effects or actions (e.g., mutating state, calling methods with side effects). Ternaries should be reserved for computing and returning values.
Applied to files:
src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.tssrc/renderer/core/layout/sync/patchLGraphNodeMode.tssrc/composables/canvas/useSelectedLiteGraphItems.test.tssrc/renderer/core/layout/store/layoutStore.test.tssrc/renderer/core/layout/operations/layoutMutations.tssrc/extensions/core/groupOptions.tssrc/renderer/extensions/minimap/data/MinimapDataSource.test.tssrc/renderer/core/layout/sync/useLayoutSync.tssrc/composables/canvas/useSelectedLiteGraphItems.tssrc/components/rightSidePanel/settings/SetNodeState.vuesrc/lib/litegraph/src/LGraphNode.tssrc/renderer/core/layout/utils/mappers.tssrc/renderer/core/layout/utils/layoutMath.test.tssrc/composables/graph/useVueNodeLifecycle.tssrc/renderer/core/layout/types.tssrc/renderer/core/layout/store/layoutStore.ts
📚 Learning: 2025-11-24T19:47:56.371Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/lib/litegraph/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:56.371Z
Learning: Applies to src/lib/litegraph/**/*.{test,spec}.{ts,tsx} : When writing tests for subgraph-related code, always import from the barrel export at `@/lib/litegraph/src/litegraph` to avoid circular dependency issues
Applied to files:
src/composables/canvas/useSelectedLiteGraphItems.test.tssrc/composables/canvas/useSelectedLiteGraphItems.tssrc/lib/litegraph/src/LGraphNode.ts
📚 Learning: 2025-11-24T19:47:56.371Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/lib/litegraph/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:56.371Z
Learning: Applies to src/lib/litegraph/**/*.{test,spec}.{js,ts,jsx,tsx} : When adding features, always write vitest unit tests using cursor rules in @.cursor
Applied to files:
src/composables/canvas/useSelectedLiteGraphItems.test.ts
📚 Learning: 2025-11-24T19:47:56.371Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/lib/litegraph/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:56.371Z
Learning: Applies to src/lib/litegraph/**/*.{js,ts,jsx,tsx} : Take advantage of `TypedArray` `subarray` when appropriate
Applied to files:
src/composables/canvas/useSelectedLiteGraphItems.test.tssrc/composables/canvas/useSelectedLiteGraphItems.ts
📚 Learning: 2025-11-24T19:47:56.371Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/lib/litegraph/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:56.371Z
Learning: Applies to src/lib/litegraph/**/*.{js,ts,jsx,tsx} : Do not replace `&&=` or `||=` with `=` when there is no reason to do so. If you do find a reason to remove either `&&=` or `||=`, leave a comment explaining why the removal occurred
Applied to files:
src/composables/canvas/useSelectedLiteGraphItems.test.tssrc/composables/canvas/useSelectedLiteGraphItems.tssrc/lib/litegraph/src/LGraphNode.ts
📚 Learning: 2025-11-24T19:47:56.371Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/lib/litegraph/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:56.371Z
Learning: Applies to src/lib/litegraph/**/*.{js,ts,jsx,tsx} : The `size` and `pos` properties of `Rectangle` share the same array buffer (`subarray`); they may be used to set the rectangle's size and position
Applied to files:
src/composables/canvas/useSelectedLiteGraphItems.test.tssrc/composables/canvas/useSelectedLiteGraphItems.ts
📚 Learning: 2025-11-24T19:47:56.371Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/lib/litegraph/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:56.371Z
Learning: Applies to src/lib/litegraph/**/*.{ts,tsx} : Type assertions are an absolute last resort. In almost all cases, they are a crutch that leads to brittle code
Applied to files:
src/composables/canvas/useSelectedLiteGraphItems.tssrc/lib/litegraph/src/LGraphNode.ts
📚 Learning: 2025-12-04T21:43:49.363Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7137
File: src/components/rightSidePanel/parameters/TabParameters.vue:10-0
Timestamp: 2025-12-04T21:43:49.363Z
Learning: Vue 3.5+ supports reactive props destructure in <script setup>. Destructuring props directly (e.g., `const { nodes } = defineProps<{ nodes: LGraphNode[] }>()`) maintains reactivity through compiler transformation. This is the recommended modern approach and does not require using `props.x` or `toRef`/`toRefs`.
Applied to files:
src/components/rightSidePanel/settings/SetNodeState.vue
📚 Learning: 2025-12-09T03:49:52.828Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 6300
File: src/platform/updates/components/WhatsNewPopup.vue:5-13
Timestamp: 2025-12-09T03:49:52.828Z
Learning: In Vue files across the ComfyUI_frontend repo, when a button is needed, prefer the repo's common button components from src/components/button/ (IconButton.vue, TextButton.vue, IconTextButton.vue) over plain HTML <button> elements. These components wrap PrimeVue with the project’s design system styling. Use only the common button components for consistency and theming, and import them from src/components/button/ as needed.
Applied to files:
src/components/rightSidePanel/settings/SetNodeState.vue
📚 Learning: 2025-12-09T21:40:12.361Z
Learnt from: benceruleanlu
Repo: Comfy-Org/ComfyUI_frontend PR: 7297
File: src/components/actionbar/ComfyActionbar.vue:33-43
Timestamp: 2025-12-09T21:40:12.361Z
Learning: In Vue single-file components, allow inline Tailwind CSS class strings for static classes and avoid extracting them into computed properties solely for readability. Prefer keeping static class names inline for simplicity and performance. For dynamic or conditional classes, use Vue bindings (e.g., :class) to compose classes.
Applies to all Vue files in the repository (e.g., src/**/*.vue) where Tailwind utilities are used for static styling.
Applied to files:
src/components/rightSidePanel/settings/SetNodeState.vue
📚 Learning: 2025-12-16T22:26:49.463Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.vue:17-17
Timestamp: 2025-12-16T22:26:49.463Z
Learning: In Vue 3.5+ with <script setup>, when using defineProps<Props>() with partial destructuring (e.g., const { as = 'button', class: customClass = '' } = defineProps<Props>() ), props that are not destructured (e.g., variant, size) stay accessible by name in the template scope. This pattern is valid: you can destructure only a subset of props for convenience while referencing the remaining props directly in template expressions. Apply this guideline to Vue components across the codebase (all .vue files).
Applied to files:
src/components/rightSidePanel/settings/SetNodeState.vue
📚 Learning: 2025-12-22T21:36:08.369Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7649
File: src/platform/cloud/subscription/components/PricingTable.vue:185-201
Timestamp: 2025-12-22T21:36:08.369Z
Learning: In Vue components, avoid creating single-use variants for common UI components (e.g., Button and other shared components). Aim for reusable variants that cover multiple use cases. It’s acceptable to temporarily mix variant props with inline Tailwind classes when a styling need is unique to one place, but plan and consolidate into shared, reusable variants as patterns emerge across the codebase.
Applied to files:
src/components/rightSidePanel/settings/SetNodeState.vue
📚 Learning: 2026-01-08T02:26:18.357Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7893
File: src/components/button/IconGroup.vue:5-6
Timestamp: 2026-01-08T02:26:18.357Z
Learning: In components that use the cn utility from '@/utils/tailwindUtil' with tailwind-merge, rely on the behavior that conflicting Tailwind classes are resolved by keeping the last one. For example, cn('base-classes bg-default', propClass) will have any conflicting background class from propClass override bg-default. This additive pattern is intentional and aligns with the shadcn-ui convention; ensure you document or review expectations accordingly in Vue components.
Applied to files:
src/components/rightSidePanel/settings/SetNodeState.vue
📚 Learning: 2025-12-18T02:07:38.870Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7598
File: src/components/sidebar/tabs/AssetsSidebarTab.vue:131-131
Timestamp: 2025-12-18T02:07:38.870Z
Learning: Tailwind CSS v4 safe utilities (e.g., items-center-safe, justify-*-safe, place-*-safe) are allowed in Vue components under src/ and in story files. Do not flag these specific safe variants as invalid when reviewing code in src/**/*.vue or related stories.
Applied to files:
src/components/rightSidePanel/settings/SetNodeState.vue
📚 Learning: 2025-12-18T21:15:46.862Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7603
File: src/components/queue/QueueOverlayHeader.vue:49-59
Timestamp: 2025-12-18T21:15:46.862Z
Learning: In the ComfyUI_frontend repository, for Vue components, do not add aria-label to buttons that have visible text content (e.g., buttons containing <span> text). The visible text provides the accessible name. Use aria-label only for elements without visible labels (e.g., icon-only buttons). If a button has no visible label, provide a clear aria-label or associate with an aria-labelledby describing its action.
Applied to files:
src/components/rightSidePanel/settings/SetNodeState.vue
📚 Learning: 2025-12-21T01:06:02.786Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7649
File: src/components/graph/selectionToolbox/ColorPickerButton.vue:15-18
Timestamp: 2025-12-21T01:06:02.786Z
Learning: In Comfy-Org/ComfyUI_frontend, in Vue component files, when a filled icon is required (e.g., 'pi pi-circle-fill'), you may mix PrimeIcons with Lucide icons since Lucide lacks filled variants. This mixed usage is acceptable when one icon library does not provide an equivalent filled icon. Apply consistently across Vue components in the src directory where icons are used, and document the rationale when a mixed approach is chosen.
Applied to files:
src/components/rightSidePanel/settings/SetNodeState.vue
📚 Learning: 2025-12-18T16:03:02.066Z
Learnt from: henrikvilhelmberglund
Repo: Comfy-Org/ComfyUI_frontend PR: 7617
File: src/components/actionbar/ComfyActionbar.vue:301-308
Timestamp: 2025-12-18T16:03:02.066Z
Learning: In the ComfyUI frontend queue system, useQueuePendingTaskCountStore().count indicates the number of tasks in the queue, where count = 1 means a single active/running task and count > 1 means there are pending tasks in addition to the active task. Therefore, in src/components/actionbar/ComfyActionbar.vue, enable the 'Clear Pending Tasks' button only when count > 1 to avoid clearing the currently running task. The active task should be canceled using the 'Cancel current run' button instead. This rule should be enforced via a conditional check on the queue count, with appropriate disabled/aria-disabled states for accessibility, and tests should verify behavior for count = 1 and count > 1.
Applied to files:
src/components/rightSidePanel/settings/SetNodeState.vue
📚 Learning: 2026-01-09T02:07:59.035Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7898
File: src/composables/usePaste.test.ts:248-248
Timestamp: 2026-01-09T02:07:59.035Z
Learning: In test files at src/**/*.test.ts, when creating mock objects that partially implement an interface (e.g., LGraphNode), use `as Partial<InterfaceType> as InterfaceType` instead of `as any` or `as unknown as InterfaceType` to explicitly acknowledge the incomplete implementation while maintaining type safety.
Applied to files:
src/lib/litegraph/src/LGraphNode.ts
📚 Learning: 2025-11-24T19:47:56.371Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/lib/litegraph/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:56.371Z
Learning: Applies to src/lib/litegraph/**/*.{js,ts,jsx,tsx} : Prefer single line `if` syntax over adding curly braces, when the statement has a very concise expression and concise, single line statement
Applied to files:
src/lib/litegraph/src/LGraphNode.ts
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to +(tests-ui|src)/**/*.test.ts : Do not write tests dependent on non-behavioral features like utility classes or styles
Applied to files:
src/renderer/core/layout/utils/layoutMath.test.ts
📚 Learning: 2025-12-11T03:55:57.926Z
Learnt from: simula-r
Repo: Comfy-Org/ComfyUI_frontend PR: 7252
File: src/renderer/extensions/vueNodes/components/ImagePreview.vue:151-158
Timestamp: 2025-12-11T03:55:57.926Z
Learning: In src/renderer/extensions/vueNodes/components/ImagePreview.vue and LGraphNode.vue, keyboard navigation for image galleries should respond to node-level focus (via keyEvent injection from LGraphNode), not require focus within the image preview wrapper itself. This allows users to navigate the gallery with arrow keys immediately when the node is focused/selected.
Applied to files:
src/composables/graph/useVueNodeLifecycle.ts
📚 Learning: 2025-11-24T19:47:02.860Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.{vue,ts} : Leverage VueUse functions for performance-enhancing styles
Applied to files:
src/composables/graph/useVueNodeLifecycle.ts
🧬 Code graph analysis (6)
src/renderer/core/layout/sync/patchLGraphNodeMode.ts (2)
src/lib/litegraph/src/LGraphNode.ts (4)
LGraphNode(213-215)LGraphNode(225-4199)LGraphNode(746-754)LGraphNode(756-762)src/renderer/core/layout/store/layoutStore.ts (1)
layoutStore(1555-1555)
src/extensions/core/groupOptions.ts (3)
src/renderer/core/layout/store/layoutStore.ts (2)
setNodeMode(1468-1485)layoutStore(1555-1555)src/lib/litegraph/src/LGraphNode.ts (4)
LGraphNode(213-215)LGraphNode(225-4199)LGraphNode(746-754)LGraphNode(756-762)src/lib/litegraph/src/subgraph/ExecutableNodeDTO.ts (1)
mode(80-82)
src/composables/canvas/useSelectedLiteGraphItems.ts (3)
src/renderer/core/layout/store/layoutStore.ts (1)
layoutStore(1555-1555)src/lib/litegraph/src/subgraph/ExecutableNodeDTO.ts (1)
mode(80-82)src/lib/litegraph/src/litegraph.ts (1)
LGraphEventMode(127-127)
src/lib/litegraph/src/LGraphNode.ts (1)
src/lib/litegraph/src/litegraph.ts (1)
LGraphEventMode(127-127)
src/composables/graph/useVueNodeLifecycle.ts (1)
src/renderer/core/layout/sync/patchLGraphNodeMode.ts (1)
patchLGraphNodeMode(15-33)
src/renderer/core/layout/store/layoutStore.ts (4)
src/renderer/core/layout/types.ts (2)
SetNodeModeOperation(165-169)NodeId(40-40)src/lib/litegraph/src/LGraph.ts (2)
change(1279-1282)nodes(400-402)src/lib/litegraph/src/subgraph/ExecutableNodeDTO.ts (1)
mode(80-82)src/renderer/core/layout/utils/mappers.ts (1)
yNodeToLayout(38-48)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: deploy-and-comment
- GitHub Check: setup
- GitHub Check: test
- GitHub Check: lint-and-format
- GitHub Check: collect
🔇 Additional comments (24)
src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.ts (1)
76-92: LGTM!The mock fixture correctly includes the new
modefield to match the updatedNodeLayouttype. Usingvi.hoisted()for shared mock data is the correct pattern per coding guidelines.src/renderer/core/layout/types.ts (2)
45-54: LGTM!The
modefield is properly added toNodeLayoutwith a helpful inline comment documenting the LGraphEventMode values.
162-169: LGTM!The
SetNodeModeOperationinterface follows the established pattern of other node operations (e.g.,SetNodeZIndexOperation), correctly includingpreviousModefor undo/redo support.src/renderer/extensions/minimap/data/MinimapDataSource.test.ts (1)
28-41: LGTM!Test fixture correctly updated to include the new
modefield, maintaining type conformance withNodeLayout.src/renderer/core/layout/utils/layoutMath.test.ts (1)
53-67: LGTM!Test helper
createTestNodecorrectly updated to include the newmodefield, ensuring all generatedNodeLayoutfixtures conform to the updated type.src/renderer/core/layout/sync/useLayoutSync.ts (1)
56-60: Mode sync uses proper guard to prevent infinite loops.The implementation correctly prevents sync loops. After calling
liteNode.changeMode(layout.mode), theliteNode.modeis updated to matchlayout.mode, so if the patchedchangeModemethod triggers anotheronChangecallback, the guard conditionliteNode.mode !== layout.modewill fail and no recursive call occurs.src/renderer/core/layout/store/layoutStore.test.ts (1)
20-20: LGTM!The test fixture correctly includes the new
modefield with value0(representingLGraphEventMode.ALWAYS), aligning with the updatedNodeLayouttype.src/composables/graph/useVueNodeLifecycle.ts (3)
11-11: LGTM!Import follows repo conventions with type imports kept separate from value imports.
40-42: LGTM!Correctly extends the node data passed to
layoutStore.initializeFromLiteGraphto include themodeproperty from each LGraphNode, enabling the layout store to track node modes from initialization.
64-66: LGTM!The patch is correctly applied after
layoutStore.initializeFromLiteGraphis called, ensuring the store is seeded beforeLGraphNode.changeModestarts syncing to it. The patch function is idempotent (uses anisPatchedguard), so multiple calls are safe.src/extensions/core/groupOptions.ts (1)
10-10: LGTM!Import correctly added for layoutStore access.
src/lib/litegraph/src/LGraphNode.ts (1)
1328-1330: LGTM!Adding an explicit
BYPASScase ensures this mode is handled correctly bychangeMode, allowing the mode to be set without falling through to the default case (which would returnfalseand reject the change). This is essential for the centralized mode management to work with bypass operations.src/composables/canvas/useSelectedLiteGraphItems.ts (3)
3-3: LGTM!Import correctly added for layoutStore access.
123-128: LGTM!The mode comparison now correctly reads from
layoutStore.getNodeLayoutRef()instead of directly from node properties. The optional chaining (?.mode) safely handles cases where the node layout might not exist in the store.
134-137: LGTM!Correctly delegates mode changes to
layoutStore.setNodeMode, aligning with centralized state management.src/renderer/core/layout/sync/patchLGraphNodeMode.ts (1)
1-33: LGTM! Clean patch implementation with proper guard and defensive checks.The double-patch guard, defensive condition check (
result && previousMode !== this.mode), and proper ID normalization are all well-implemented. The synchronization withlayoutStore.setNodeModecorrectly ensures bidirectional consistency between LiteGraph and the centralized store.src/composables/canvas/useSelectedLiteGraphItems.test.ts (2)
226-275: Good migration to store-based assertions.The tests correctly initialize the layoutStore before each scenario and verify mode changes through
getNodeLayoutRef().value?.mode. The string ID normalization aligns with the store's internal representation.
301-364: Subgraph mode unification test is comprehensive.The test properly verifies that subgraph children receive the unified state from their parent, with all nodes initialized in layoutStore and assertions checking the store's state rather than direct node properties.
src/renderer/core/layout/operations/layoutMutations.ts (1)
145-160: LGTM! Consistent addition of mode field to node creation.The default value of
0(ALWAYS) follows the pattern established ininitializeFromLiteGraphand aligns with theNODE_LAYOUT_DEFAULTS.modevalue in mappers.src/components/rightSidePanel/settings/SetNodeState.vue (1)
24-59: LGTM! Clean store-based mode management.The refactored implementation correctly:
- Derives
nodeIdsfrom props (immutable)- Creates reactive refs via
layoutStore.getNodeLayoutRef()- Returns a unified mode only when all nodes share the same mode
- Uses the setter with proper null/undefined guards and emits the change event
The pattern of passing only
idto the component and delegating state to the store improves separation of concerns.src/renderer/core/layout/store/layoutStore.ts (3)
299-310: LGTM! Mode change detection follows established patterns.The mode comparison and operation emission follows the same pattern as position, size, and zIndex changes. The operation includes
previousModefor undo support.
1103-1112: LGTM! Handler follows existing patterns.The implementation correctly updates the CRDT and adds the nodeId to the change for downstream notification.
1464-1485: LGTM! Proper short-circuit prevents sync loops.The
if (currentLayout.mode === mode) returncheck is crucial for preventing infinite loops during bidirectional synchronization between layoutStore and LiteGraph (viapatchLGraphNodeMode).src/renderer/core/layout/utils/mappers.ts (1)
24-24: LGTM!The
modefield serialization and deserialization follow the established patterns for other NodeLayout fields, with proper fallback handling viagetOr.Also applies to: 45-45
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
|
|
||
| // Apply the parent's new mode to all children uniformly | ||
| node.mode = newModeForSelectedNode | ||
| layoutStore.setNodeMode(node.id.toString(), newModeForSelectedNode) |
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Consider batch mode updates for subgraph children.
When traversing subgraph nodes, each child triggers a separate layoutStore.setNodeMode call. For large subgraphs, using layoutStore.setNodesMode with a pre-collected map of node IDs to modes could be more efficient.
♻️ Optional: Collect child nodes and batch update
// If this selected node is a subgraph, apply the same mode uniformly to all its children
// This ensures predictable behavior: all children get the same state as their parent
if (selectedNode.isSubgraphNode?.() && selectedNode.subgraph) {
+ const childNodeModes: Record<string, number> = {}
traverseNodesDepthFirst([selectedNode], {
visitor: (node) => {
// Skip the parent node since we already handled it above
if (node === selectedNode) return undefined
- // Apply the parent's new mode to all children uniformly
- layoutStore.setNodeMode(node.id.toString(), newModeForSelectedNode)
+ childNodeModes[node.id.toString()] = newModeForSelectedNode
return undefined
}
})
+ if (Object.keys(childNodeModes).length > 0) {
+ layoutStore.setNodesMode(childNodeModes)
+ }
}🤖 Prompt for AI Agents
In `@src/composables/canvas/useSelectedLiteGraphItems.ts` at line 148, The loop
currently calls layoutStore.setNodeMode(node.id.toString(),
newModeForSelectedNode) for each child which is inefficient for large subgraphs;
modify the traversal in useSelectedLiteGraphItems.ts to collect a map/object of
child node IDs to newModeForSelectedNode (use node.id.toString() as the key) and
after traversal call layoutStore.setNodesMode(collectedMap) once; keep the
existing per-node logic to determine newModeForSelectedNode but replace
individual setNodeMode calls with building the map and a single batch
setNodesMode call.
| function setNodeMode(node: LGraphNode, mode: number) { | ||
| node.mode = mode | ||
| node.graph?.change() | ||
| layoutStore.setNodeMode(node.id.toString(), mode) | ||
| } |
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Good refactor to centralized mode management.
The function now correctly delegates to layoutStore.setNodeMode. However, consider using layoutStore.setNodesMode for batch updates when changing mode for all nodes in a group, as this could reduce redundant store operations.
♻️ Optional: Use batch mode update
function setNodeMode(node: LGraphNode, mode: number) {
layoutStore.setNodeMode(node.id.toString(), mode)
}
+
+function setNodesModeForGroup(nodes: LGraphNode[], mode: number) {
+ const nodeIdModes: Record<string, number> = {}
+ for (const node of nodes) {
+ nodeIdModes[node.id.toString()] = mode
+ }
+ layoutStore.setNodesMode(nodeIdModes)
+}Then update the callbacks to use the batch function instead of looping.
🤖 Prompt for AI Agents
In `@src/extensions/core/groupOptions.ts` around lines 16 - 18, The current
setNodeMode(node: LGraphNode, mode: number) delegates to layoutStore.setNodeMode
for single-node updates; when you change mode for an entire group, replace the
per-node loop with a single batch call to layoutStore.setNodesMode(idsArray,
mode) to avoid repetitive store writes—keep setNodeMode for individual updates
but modify the group callbacks (where you currently iterate nodes and call
setNodeMode) to collect node.id strings into an array and call
layoutStore.setNodesMode once with that array and the new mode.
| /** | ||
| * Set the execution mode for multiple nodes. | ||
| * Applies the mode to all nodes atomically. | ||
| */ | ||
| setNodesMode(nodeIds: NodeId[], mode: number): void { | ||
| if (nodeIds.length === 0) return | ||
|
|
||
| // Apply mode to each node | ||
| // Note: We could create a batch operation type if needed for better performance | ||
| nodeIds.forEach((nodeId) => { | ||
| this.setNodeMode(nodeId, mode) | ||
| }) | ||
| } |
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Consider batch operation for multi-node mode changes.
The current implementation creates N separate operations for N nodes, each triggering its own version increment and change notification. For large selections, this could impact performance.
The existing batchUpdateNodeBounds pattern (lines 1504-1551) demonstrates how to atomically update multiple nodes in a single operation with one notification cycle. A similar BatchSetNodeModeOperation would improve efficiency.
♻️ Potential batch operation pattern
+interface BatchSetNodeModeOperation extends OpBase {
+ type: 'batchSetNodeMode'
+ entity: 'node'
+ nodeIds: NodeId[]
+ mode: number
+ previousModes: Record<NodeId, number>
+}
setNodesMode(nodeIds: NodeId[], mode: number): void {
if (nodeIds.length === 0) return
- // Apply mode to each node
- // Note: We could create a batch operation type if needed for better performance
- nodeIds.forEach((nodeId) => {
- this.setNodeMode(nodeId, mode)
- })
+ // Single node optimization
+ if (nodeIds.length === 1) {
+ this.setNodeMode(nodeIds[0], mode)
+ return
+ }
+
+ // Batch operation for multiple nodes
+ const previousModes: Record<NodeId, number> = {}
+ const validNodeIds: NodeId[] = []
+
+ for (const nodeId of nodeIds) {
+ const ynode = this.ynodes.get(nodeId)
+ if (!ynode) continue
+ const currentLayout = yNodeToLayout(ynode)
+ if (currentLayout.mode === mode) continue
+ previousModes[nodeId] = currentLayout.mode
+ validNodeIds.push(nodeId)
+ }
+
+ if (validNodeIds.length === 0) return
+
+ this.applyOperation({
+ type: 'batchSetNodeMode',
+ entity: 'node',
+ nodeIds: validNodeIds,
+ mode,
+ previousModes,
+ timestamp: Date.now(),
+ source: this.currentSource,
+ actor: this.currentActor
+ })
}🤖 Prompt for AI Agents
In `@src/renderer/core/layout/store/layoutStore.ts` around lines 1487 - 1499, The
setNodesMode method currently calls setNodeMode for each node causing N
operations/notifications; replace this with a single batched operation following
the batchUpdateNodeBounds pattern: create a BatchSetNodeModeOperation (or
similar) that takes nodeIds and mode, applies mode to each node in one atomic
update, increments the store version once, and emits a single
change/notification; update setNodesMode to construct and push/commit that batch
operation (refer to setNodesMode, setNodeMode, batchUpdateNodeBounds, and the
new BatchSetNodeModeOperation) so large selections perform efficiently.
| size: { width: 100, height: 50 }, | ||
| zIndex: 0, | ||
| visible: true, | ||
| mode: 0, // LGraphEventMode.ALWAYS |
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Find LGraphEventMode definition
rg -n "enum LGraphEventMode|LGraphEventMode\s*=" --type ts -B2 -A10Repository: Comfy-Org/ComfyUI_frontend
Length of output: 1817
🏁 Script executed:
#!/bin/bash
# Examine the mappers.ts file to see current imports and line 13 context
cat -n src/renderer/core/layout/utils/mappers.ts | head -60Repository: Comfy-Org/ComfyUI_frontend
Length of output: 1937
🏁 Script executed:
#!/bin/bash
# Search for existing imports from litegraph in mappers.ts
rg -n "import.*from.*litegraph" src/renderer/core/layout/utils/mappers.tsRepository: Comfy-Org/ComfyUI_frontend
Length of output: 52
🏁 Script executed:
#!/bin/bash
# Find and examine NodeLayout type definition
rg -n "type NodeLayout|interface NodeLayout" --type ts -A20 | head -50Repository: Comfy-Org/ComfyUI_frontend
Length of output: 2907
🏁 Script executed:
#!/bin/bash
# Check the litegraph barrel export
cat -n src/lib/litegraph/src/litegraph.ts | head -50Repository: Comfy-Org/ComfyUI_frontend
Length of output: 1797
🏁 Script executed:
#!/bin/bash
# Check what's exported from the globalEnums
rg -n "export.*LGraphEventMode" --type tsRepository: Comfy-Org/ComfyUI_frontend
Length of output: 145
🏁 Script executed:
#!/bin/bash
# Check if there are any existing imports from litegraph in renderer/core/layout
find src/renderer/core/layout -type f \( -name "*.ts" -o -name "*.tsx" \) -exec grep -l "from.*litegraph" {} \;Repository: Comfy-Org/ComfyUI_frontend
Length of output: 449
🏁 Script executed:
#!/bin/bash
# Check what files in layout module import from litegraph, especially patchLGraphNodeMode
head -20 src/renderer/core/layout/sync/patchLGraphNodeMode.ts
head -20 src/renderer/core/layout/operations/layoutMutations.tsRepository: Comfy-Org/ComfyUI_frontend
Length of output: 1298
🏁 Script executed:
#!/bin/bash
# Check the full barrel export to see if LGraphEventMode is exported
grep -n "LGraphEventMode" src/lib/litegraph/src/litegraph.tsRepository: Comfy-Org/ComfyUI_frontend
Length of output: 92
🏁 Script executed:
#!/bin/bash
# Check if there's any pattern of importing LGraphEventMode directly in the codebase
rg "import.*LGraphEventMode" --type ts -A2 -B2Repository: Comfy-Org/ComfyUI_frontend
Length of output: 5773
Import LGraphEventMode.ALWAYS instead of using the magic number 0.
This improves type safety and makes the code self-documenting, eliminating the need for the explanatory comment. The enum is already exported from the barrel at @/lib/litegraph/src/litegraph and used throughout the codebase with this import pattern.
🤖 Prompt for AI Agents
In `@src/renderer/core/layout/utils/mappers.ts` at line 13, Replace the magic
number assignment "mode: 0" in the mapper object with the enum value
LGraphEventMode.ALWAYS and add an import for LGraphEventMode from
"@/lib/litegraph/src/litegraph"; locate the occurrence of "mode: 0" in
mappers.ts and change it to "mode: LGraphEventMode.ALWAYS", then add the named
import (or extend an existing import) for LGraphEventMode at the top of the file
so the enum is referenced instead of the hardcoded 0.
christian-byrne
left a comment
christian-byrne
left a comment
There was a problem hiding this comment.
Can you give a high-level explanation of the approach here?
|
Sorry. what do you mean? |
|
I encountered an issue: layoutStore is specifically designed for Nodes 2.0. After switching to layoutStore, if Nodes 2.0 is not started, it will be impossible to modify the state of Nodes. |
2 participants
related #8023, #7812 (comment)
Important
I encountered an issue: layoutStore is specifically designed for Nodes 2.0. After switching to layoutStore, if Nodes 2.0 is not started, it will be impossible to modify the state of Nodes.
┆Issue is synchronized with this Notion page by Unito