-
Notifications
You must be signed in to change notification settings - Fork 492
chore: move renameWidget function to widgetUtil.ts #8042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
christian-byrne
merged 2 commits into
main
from
rizumu/chore/move-renameWidget-function-to-widgetUtil
Jan 18, 2026
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| import { isProxyWidget } from '@/core/graph/subgraph/proxyWidget' | ||
| import type { LGraphNode } from '@/lib/litegraph/src/LGraphNode' | ||
| import type { SubgraphNode } from '@/lib/litegraph/src/subgraph/SubgraphNode' | ||
| import type { IBaseWidget } from '@/lib/litegraph/src/types/widgets' | ||
|
|
||
| /** | ||
| * Renames a widget and its corresponding input. | ||
| * Handles both regular widgets and proxy widgets in subgraphs. | ||
| * | ||
| * @param widget The widget to rename | ||
| * @param node The node containing the widget | ||
| * @param newLabel The new label for the widget (empty string or undefined to clear) | ||
| * @param parents Optional array of parent SubgraphNodes (for proxy widgets) | ||
| * @returns true if the rename was successful, false otherwise | ||
| */ | ||
| export function renameWidget( | ||
| widget: IBaseWidget, | ||
| node: LGraphNode, | ||
| newLabel: string, | ||
| parents?: SubgraphNode[] | ||
| ): boolean { | ||
| // For proxy widgets in subgraphs, we need to rename the original interior widget | ||
| if (isProxyWidget(widget) && parents?.length) { | ||
| const subgraph = parents[0].subgraph | ||
| if (!subgraph) { | ||
| console.error('Could not find subgraph for proxy widget') | ||
| return false | ||
| } | ||
| const interiorNode = subgraph.getNodeById(widget._overlay.nodeId) | ||
|
|
||
| if (!interiorNode) { | ||
| console.error('Could not find interior node for proxy widget') | ||
| return false | ||
| } | ||
|
|
||
| const originalWidget = interiorNode.widgets?.find( | ||
| (w) => w.name === widget._overlay.widgetName | ||
| ) | ||
|
|
||
| if (!originalWidget) { | ||
| console.error('Could not find original widget for proxy widget') | ||
| return false | ||
| } | ||
|
|
||
| // Rename the original widget | ||
| originalWidget.label = newLabel || undefined | ||
|
|
||
| // Also rename the corresponding input on the interior node | ||
| const interiorInput = interiorNode.inputs?.find( | ||
| (inp) => inp.widget?.name === widget._overlay.widgetName | ||
| ) | ||
| if (interiorInput) { | ||
| interiorInput.label = newLabel || undefined | ||
| } | ||
| } | ||
|
|
||
| // Always rename the widget on the current node (either regular widget or proxy widget) | ||
| const input = node.inputs?.find((inp) => inp.widget?.name === widget.name) | ||
|
|
||
| // Intentionally mutate the widget object here as it's a reference | ||
| // to the actual widget in the graph | ||
| widget.label = newLabel || undefined | ||
| if (input) { | ||
| input.label = newLabel || undefined | ||
| } | ||
|
|
||
| return true | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.