Skip to content

[backport core/1.36] Fix reactivity washing in refreshNodeSlots#8018

Merged
christian-byrne merged 1 commit intocore/1.36from
backport-7802-to-core-1.36
Jan 13, 2026
Merged

[backport core/1.36] Fix reactivity washing in refreshNodeSlots#8018
christian-byrne merged 1 commit intocore/1.36from
backport-7802-to-core-1.36

Conversation

@comfy-pr-bot
Copy link
Member

@comfy-pr-bot comfy-pr-bot commented Jan 13, 2026

Backport of #7802 to core/1.36

Automatically created by backport workflow.

┆Issue is synchronized with this Notion page by Unito

Creating a copy with spread resulted in a copy which was not reactive.

Solves a bug where all widgets on a node in vue mode would cease to be
reactive after any connection is made to the node.

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7802-Fix-reactivity-washing-in-refreshNodeSlots-2d96d73d3650819e842ff46030bebfa1)
by [Unito](https://www.unito.io)

---------

Co-authored-by: Alexander Brown <drjkl@comfy.org>
@comfy-pr-bot comfy-pr-bot requested a review from a team as a code owner January 13, 2026 05:18
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Jan 13, 2026
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 13, 2026
@github-actions
Copy link

github-actions bot commented Jan 13, 2026

🎭 Playwright Test Results

Some tests failed

⏰ Completed at: 01/13/2026, 05:25:07 AM UTC

📈 Summary

  • Total Tests: 512
  • Passed: 502 ✅
  • Failed: 1 ❌
  • Flaky: 1 ⚠️
  • Skipped: 8 ⏭️

📊 Test Reports by Browser

  • chromium: View Report • ✅ 492 / ❌ 1 / ⚠️ 0 / ⏭️ 8
  • chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • mobile-chrome: View Report • ✅ 7 / ❌ 0 / ⚠️ 1 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

@github-actions
Copy link

github-actions bot commented Jan 13, 2026

🎨 Storybook Build Status

Build completed successfully!

⏰ Completed at: 01/13/2026, 05:19:51 AM UTC

🔗 Links


🎉 Your Storybook is ready for review!

@christian-byrne christian-byrne merged commit 3339fc4 into core/1.36 Jan 13, 2026
32 of 33 checks passed
@christian-byrne christian-byrne deleted the backport-7802-to-core-1.36 branch January 13, 2026 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants