[backport core/1.36] CI: Use custom container for E2E tests#7982
Merged
christian-byrne merged 1 commit intocore/1.36from Jan 13, 2026
Merged
[backport core/1.36] CI: Use custom container for E2E tests#7982christian-byrne merged 1 commit intocore/1.36from
christian-byrne merged 1 commit intocore/1.36from
Conversation
## Summary Use a pre-built container image with all dependencies for Playwright E2E tests, eliminating ~130s setup time per shard. ## Changes - Use `ghcr.io/comfy-org/comfyui-ci-container:0.0.8` container for test jobs - Container includes: Playwright browsers, Node.js, pnpm, Python, ComfyUI backend (v0.5.1), all Python deps - Simplified setup: just copy devtools and start server (no cloning, no pip install, no browser setup) - Add `version-bump*` to `branches-ignore` to skip E2E tests for version bump PRs - Replace cache with artifacts (cache doesn't work inside containers) ## Benefits - ~130s faster per shard (no ComfyUI clone, no pip install, no browser download) - Consistent environment across all test jobs - Simpler workflow configuration ## Container Image Repository: https://github.com/comfy-org/comfyui-ci-container Image: `ghcr.io/comfy-org/comfyui-ci-container:0.0.8` ## Test plan - [x] Verify CI workflow runs with container - [x] Verify Playwright tests pass - [x] Verify snapshot updates work correctly --------- Co-authored-by: github-actions <github-actions@github.com>
3 tasks
dosubot
bot
added
the
size:L
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 01/13/2026, 03:03:56 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
🎭 Playwright Test Results❌ Some tests failed ⏰ Completed at: 01/13/2026, 03:09:08 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #7625 to
core/1.36Automatically created by backport workflow.
┆Issue is synchronized with this Notion page by Unito