Skip to content

[backport core/1.36] fix: PrimitiveNode combo widget value not persisting in vueNodes mode#7979

Merged
christian-byrne merged 1 commit intocore/1.36from
backport-7782-to-core-1.36
Jan 13, 2026
Merged

[backport core/1.36] fix: PrimitiveNode combo widget value not persisting in vueNodes mode#7979
christian-byrne merged 1 commit intocore/1.36from
backport-7782-to-core-1.36

Conversation

@comfy-pr-bot
Copy link
Member

@comfy-pr-bot comfy-pr-bot commented Jan 13, 2026

Backport of #7782 to core/1.36

Automatically created by backport workflow.

┆Issue is synchronized with this Notion page by Unito

…#7782)

## Summary
- Add missing v-model binding to WidgetWithControl in WidgetSelect.vue
- Trigger callback after setting widget value in PrimitiveNode to update
linked widgets

The combo widget value was lost because PrimitiveNode creates combo
widgets with controlWidget (via addValueControlWidgets), causing it to
use the WidgetWithControl branch which was missing v-model binding.

fix #7694 and
#7696

## Screenshots
before

https://github.com/user-attachments/assets/0a0dc668-eb71-4072-b5f7-0c20483fc1ff

after

https://github.com/user-attachments/assets/dfd2274c-8ebf-4105-821a-946063d87e9a
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Jan 13, 2026
@comfy-pr-bot comfy-pr-bot requested a review from a team as a code owner January 13, 2026 02:41
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Jan 13, 2026
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 13, 2026
@github-actions
Copy link

github-actions bot commented Jan 13, 2026

🎨 Storybook Build Status

Build completed successfully!

⏰ Completed at: 01/13/2026, 02:42:48 AM UTC

🔗 Links


🎉 Your Storybook is ready for review!

@github-actions
Copy link

github-actions bot commented Jan 13, 2026

🎭 Playwright Test Results

Some tests failed

⏰ Completed at: 01/13/2026, 02:52:44 AM UTC

📈 Summary

  • Total Tests: 512
  • Passed: 502 ✅
  • Failed: 1 ❌
  • Flaky: 1 ⚠️
  • Skipped: 8 ⏭️

📊 Test Reports by Browser

  • chromium: View Report • ✅ 490 / ❌ 1 / ⚠️ 1 / ⏭️ 8
  • chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • mobile-chrome: View Report • ✅ 9 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

@christian-byrne christian-byrne merged commit fd67ee0 into core/1.36 Jan 13, 2026
35 of 37 checks passed
@christian-byrne christian-byrne deleted the backport-7782-to-core-1.36 branch January 13, 2026 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants