feat/3d-dropdown #7975

kaili-yang · 2026-01-13T01:11:56Z

Summary

Enable the rich WidgetSelectDropdown component for the model_file input on "Load 3D" nodes in Vue (Nodes 2.0) mode.

Changes

Update acceptTypes computed property to include 3D file extensions when assetKind is mesh.

Screenshots

before-after.3d.dropdown.mov

┆Issue is synchronized with this Notion page by Unito

coderabbitai · 2026-01-13T01:12:10Z

📝 Walkthrough

Walkthrough

Adds explicit 3D "mesh" asset support across widgets and upload handling, and makes Load3D URL resolution recognize a trailing [output] suffix on model paths (stripping it and forcing output-type resource URLs).

Changes

Cohort / File(s)	Summary
Type definitions `src/types/widgetTypes.ts`	Add `'mesh'` to the `AssetKind` union.
Widget UI: selection & dropdown `src/renderer/extensions/vueNodes/widgets/components/WidgetSelect.vue`, `src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue`	Treat Load3D `model_file` widgets as mesh uploads (adds `kind: 'mesh'`, allows uploads, sets `subfolder: '3d'` and `folder: 'input'` override). Extend output filtering to include mesh outputs, update placeholder mapping, and register mesh accept types (`.obj`, `.stl`, `.ply`, `.spz`).
Load3D composable `src/composables/useLoad3d.ts`	Detect and strip a trailing `[output]` from `modelPath`, set `forcedType = 'output'`, and use the cleaned path for `splitFilePath` and resource URL construction (forcedType used when present; otherwise previous preview-mode fallback remains).

Possibly related PRs

Feat: Load Image (from Outputs) support in Vue Nodes #6836: Modifies WidgetSelectDropdown.vue output handling and filtering logic (likely overlaps with mesh/output filtering changes).

Suggested reviewers

christian-byrne
PabloWiedemann

✨ Finishing touches

📝 Generate docstrings

📜 Recent review details

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 22aa15f and 4912011.

📒 Files selected for processing (1)

src/composables/useLoad3d.ts

🧰 Additional context used

📓 Path-based instructions (10)

src/**/*.{vue,ts}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json

Files:

src/composables/useLoad3d.ts

src/**/*.ts

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.ts: Use es-toolkit for utility functions
Use TypeScript for type safety

src/**/*.ts: Derive component types using vue-component-type-helpers (ComponentProps, ComponentSlots) instead of separate type files
Use es-toolkit for utility functions
Minimize the surface area (exported values) of each module and composable
Favor pure functions, especially testable ones

Files:

src/composables/useLoad3d.ts

src/**/{services,composables}/**/*.{ts,tsx}

📄 CodeRabbit inference engine (src/CLAUDE.md)

src/**/{services,composables}/**/*.{ts,tsx}: Use api.apiURL() for backend endpoints instead of constructing URLs directly
Use api.fileURL() for static file access instead of constructing URLs directly

Files:

src/composables/useLoad3d.ts

src/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebase

src/**/*.{ts,tsx,vue}: Use separate import type statements instead of inline type in mixed imports
Apply Prettier formatting with 2-space indentation, single quotes, no trailing semicolons, 80-character width
Sort and group imports by plugin, run pnpm format before committing
Never use any type - use proper TypeScript types
Never use as any type assertions - fix the underlying type issue
Write code that is expressive and self-documenting - avoid unnecessary comments
Do not add or retain redundant comments - clean as you go
Avoid mutable state - prefer immutability and assignment at point of declaration
Watch out for Code Smells and refactor to avoid them

Files:

src/composables/useLoad3d.ts

src/**/{composables,components}/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Clean up subscriptions in state management to prevent memory leaks

Files:

src/composables/useLoad3d.ts

src/**/*.{vue,ts,tsx}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Follow Vue 3 composition API style guide

Files:

src/composables/useLoad3d.ts

src/**/{components,composables}/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Use vue-i18n for ALL user-facing strings by adding them to src/locales/en/main.json

Files:

src/composables/useLoad3d.ts

src/composables/**/*.ts

📄 CodeRabbit inference engine (AGENTS.md)

Name composables as useXyz.ts (e.g., useForm.ts)

Files:

src/composables/useLoad3d.ts

src/**/*.{ts,vue}

📄 CodeRabbit inference engine (AGENTS.md)

src/**/*.{ts,vue}: Use ref for reactive state, computed() for derived values, and watch/watchEffect for side effects in Composition API
Avoid using ref with watch if a computed would suffice - minimize refs and derived state
Use provide/inject for dependency injection only when simpler alternatives (Store or shared composable) won't work
Leverage VueUse functions for performance-enhancing composables
Use VueUse function for useI18n in composition API for string literals

Files:

src/composables/useLoad3d.ts

src/**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

src/**/*.{ts,tsx}: Keep functions short and functional
Minimize nesting (if statements, for loops, etc.)
Use function declarations instead of function expressions when possible

Files:

src/composables/useLoad3d.ts

🧠 Learnings (8)

📓 Common learnings

Learnt from: kaili-yang
Repo: Comfy-Org/ComfyUI_frontend PR: 7975
File: src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue:210-211
Timestamp: 2026-01-14T20:49:35.553Z
Learning: In the ComfyUI frontend, for 3D mesh file uploads in WidgetSelectDropdown.vue, only `.obj,.stl,.ply,.spz` formats are security-validated and acceptable. Other 3D formats like `.gltf,.glb,.fbx,.splat,.ksplat` have not passed security testing and should not be included in the acceptTypes list.

📚 Learning: 2025-11-24T19:47:34.324Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:34.324Z
Learning: Applies to src/**/{services,composables}/**/*.{ts,tsx} : Use `api.fileURL()` for static file access instead of constructing URLs directly

Applied to files:

src/composables/useLoad3d.ts

📚 Learning: 2025-12-09T03:39:54.501Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7169
File: src/platform/remote/comfyui/jobs/jobTypes.ts:1-107
Timestamp: 2025-12-09T03:39:54.501Z
Learning: In the ComfyUI_frontend project, Zod is on v3.x. Do not suggest Zod v4 standalone validators (z.uuid, z.ulid, z.cuid2, z.nanoid) until an upgrade to Zod 4 is performed. When reviewing TypeScript files (e.g., src/platform/remote/comfyui/jobs/jobTypes.ts) validate against Zod 3 capabilities and avoid introducing v4-specific features; flag any proposal to upgrade or incorporate v4-only validators and propose staying with compatible 3.x patterns.

Applied to files:

src/composables/useLoad3d.ts

📚 Learning: 2025-12-13T11:03:11.264Z

Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7416
File: src/stores/imagePreviewStore.ts:5-7
Timestamp: 2025-12-13T11:03:11.264Z
Learning: In the ComfyUI_frontend repository, lint rules require keeping 'import type' statements separate from non-type imports, even if importing from the same module. Do not suggest consolidating them into a single import statement. Ensure type imports remain on their own line (import type { ... } from 'module') and regular imports stay on separate lines.

Applied to files:

src/composables/useLoad3d.ts

📚 Learning: 2025-12-17T00:40:09.635Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.stories.ts:45-55
Timestamp: 2025-12-17T00:40:09.635Z
Learning: Prefer pure function declarations over function expressions (e.g., use function foo() { ... } instead of const foo = () => { ... }) for pure functions in the repository. Function declarations are more functional-leaning, offer better hoisting clarity, and can improve readability and tooling consistency. Apply this guideline across TypeScript files in Comfy-Org/ComfyUI_frontend, including story and UI component code, except where a function expression is semantically required (e.g., callbacks, higher-order functions with closures).

Applied to files:

src/composables/useLoad3d.ts

📚 Learning: 2025-12-30T22:22:33.836Z

Learnt from: kaili-yang
Repo: Comfy-Org/ComfyUI_frontend PR: 7805
File: src/composables/useCoreCommands.ts:439-439
Timestamp: 2025-12-30T22:22:33.836Z
Learning: When accessing reactive properties from Pinia stores in TypeScript files, avoid using .value on direct property access (e.g., useStore().isOverlayExpanded). Pinia auto-wraps refs when accessed directly, returning the primitive value. The .value accessor is only needed when destructuring store properties or when using storeToRefs().

Applied to files:

src/composables/useLoad3d.ts

📚 Learning: 2025-12-11T12:25:15.470Z

Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:15.470Z
Learning: This repository uses CI automation to format code (pnpm format). Do not include manual formatting suggestions in code reviews for Comfy-Org/ComfyUI_frontend. If formatting issues are detected, rely on the CI formatter or re-run pnpm format. Focus reviews on correctness, readability, performance, accessibility, and maintainability rather than style formatting.

Applied to files:

src/composables/useLoad3d.ts

📚 Learning: 2026-01-12T17:39:27.738Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7906
File: src/components/sidebar/tabs/AssetsSidebarTab.vue:545-552
Timestamp: 2026-01-12T17:39:27.738Z
Learning: In Vue/TypeScript files (src/**/*.{ts,tsx,vue}), prefer if/else statements over ternary operators when performing side effects or actions (e.g., mutating state, calling methods with side effects). Ternaries should be reserved for computing and returning values.

Applied to files:

src/composables/useLoad3d.ts

🧬 Code graph analysis (1)

src/composables/useLoad3d.ts (1)

src/scripts/api.ts (1)

api (1306-1306)

🔇 Additional comments (2)

src/composables/useLoad3d.ts (2)

217-225: LGTM! The suffix handling logic is now correctly aligned.

The previous concern about mismatch between the endsWith check and regex replacement has been properly addressed. The code now:

Trims modelPath into cleanPath upfront

Performs endsWith check on the trimmed value

Applies replacement with an additional .trim() for any whitespace before [output]

Minor consideration: if modelPath were theoretically just "[output]" or " [output] ", cleanPath would become an empty string after stripping. This seems unlikely in practice given the widget's purpose, but you may want to add a guard if Load3dUtils.splitFilePath doesn't handle empty strings gracefully.

230-230: Good use of nullish coalescing for type fallback.

The forcedType ?? (isPreview.value ? 'output' : 'input') pattern cleanly preserves backward compatibility—existing behavior remains unchanged when no [output] suffix is present.

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-01-13T01:12:22Z

🎨 Storybook Build Status

Build is starting...

⏰ Started at: 01/14/2026, 09:06:13 PM UTC

🚀 Building Storybook

📦 Installing dependencies...
🔧 Building Storybook components...
🌐 Preparing deployment to Cloudflare Pages...

⏱️ Please wait while the Storybook build is in progress...

github-actions · 2026-01-13T01:12:24Z

🎭 Playwright Tests: ⚠️ Passed with flaky tests

Results: 505 passed, 0 failed, 1 flaky, 8 skipped (Total: 514)

❌ Failed Tests

📊 Browser Reports

chromium: View Report (✅ 495 / ❌ 0 / ⚠️ 0 / ⏭️ 8)
chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
mobile-chrome: View Report (✅ 7 / ❌ 0 / ⚠️ 1 / ⏭️ 0)

coderabbitai

Actionable comments posted: 2

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

src/renderer/extensions/vueNodes/widgets/components/WidgetSelect.vue (1)

57-110: Remove or properly type the unused subfolder property.

The specDescriptor computed property returns subfolder (line 109) but the type annotation (lines 57-61) doesn't include it. More importantly, subfolder is never used—it's not accessed anywhere in the component. Remove the unused computation (lines 102-103), or if subfolder should be used in the future, add it to the type annotation and explain its purpose.

Note: WidgetSelectDropdown does not accept a subfolder prop and doesn't need it—subfolder usage within that component comes from API responses, not from parent props.

🤖 Fix all issues with AI agents

In @src/composables/useLoad3d.ts:
- Around line 217-225: The suffix detection uses
modelPath.trim().endsWith('[output]') but the replacement runs on the untrimmed
modelPath, causing cases like "model.obj [output]  " to fail to remove the
suffix; update the logic to operate on the trimmed value (assign a trimmed
variable or call .trim() once), e.g. trim modelPath into a local variable,
perform the endsWith and the regex replacement against that trimmed string to
set cleanPath and forcedType consistently before calling
Load3dUtils.splitFilePath(cleanPath).

In
@src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue:
- Around line 210-211: The 'mesh' branch in WidgetSelectDropdown.vue currently
returns '.obj,.stl,.ply,.spz' but must match Load3D's supported formats; update
the return value used for acceptTypes in the switch case 'mesh' (in the
component rendering/select logic) to include
'.gltf,.glb,.obj,.fbx,.stl,.ply,.spz,.splat,.ksplat' so the dropdown accepts all
Load3D formats.

📜 Review details

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dfb78b2 and 22aa15f.

📒 Files selected for processing (4)

src/composables/useLoad3d.ts
src/renderer/extensions/vueNodes/widgets/components/WidgetSelect.vue
src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
src/types/widgetTypes.ts

🧰 Additional context used

📓 Path-based instructions (11)

src/**/*.{vue,ts}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json

Files:

src/types/widgetTypes.ts
src/composables/useLoad3d.ts
src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
src/renderer/extensions/vueNodes/widgets/components/WidgetSelect.vue

src/**/*.ts

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.ts: Use es-toolkit for utility functions
Use TypeScript for type safety

src/**/*.ts: Derive component types using vue-component-type-helpers (ComponentProps, ComponentSlots) instead of separate type files
Use es-toolkit for utility functions
Minimize the surface area (exported values) of each module and composable
Favor pure functions, especially testable ones

Files:

src/types/widgetTypes.ts
src/composables/useLoad3d.ts

src/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebase

src/**/*.{ts,tsx,vue}: Use separate import type statements instead of inline type in mixed imports
Apply Prettier formatting with 2-space indentation, single quotes, no trailing semicolons, 80-character width
Sort and group imports by plugin, run pnpm format before committing
Never use any type - use proper TypeScript types
Never use as any type assertions - fix the underlying type issue
Write code that is expressive and self-documenting - avoid unnecessary comments
Do not add or retain redundant comments - clean as you go
Avoid mutable state - prefer immutability and assignment at point of declaration
Watch out for Code Smells and refactor to avoid them

Files:

src/types/widgetTypes.ts
src/composables/useLoad3d.ts
src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
src/renderer/extensions/vueNodes/widgets/components/WidgetSelect.vue

src/**/*.{vue,ts,tsx}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Follow Vue 3 composition API style guide

Files:

src/types/widgetTypes.ts
src/composables/useLoad3d.ts
src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
src/renderer/extensions/vueNodes/widgets/components/WidgetSelect.vue

src/**/*.{ts,vue}

📄 CodeRabbit inference engine (AGENTS.md)

src/**/*.{ts,vue}: Use ref for reactive state, computed() for derived values, and watch/watchEffect for side effects in Composition API
Avoid using ref with watch if a computed would suffice - minimize refs and derived state
Use provide/inject for dependency injection only when simpler alternatives (Store or shared composable) won't work
Leverage VueUse functions for performance-enhancing composables
Use VueUse function for useI18n in composition API for string literals

Files:

src/types/widgetTypes.ts
src/composables/useLoad3d.ts
src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
src/renderer/extensions/vueNodes/widgets/components/WidgetSelect.vue

src/**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

src/**/*.{ts,tsx}: Keep functions short and functional
Minimize nesting (if statements, for loops, etc.)
Use function declarations instead of function expressions when possible

Files:

src/types/widgetTypes.ts
src/composables/useLoad3d.ts

src/**/{services,composables}/**/*.{ts,tsx}

📄 CodeRabbit inference engine (src/CLAUDE.md)

src/**/{services,composables}/**/*.{ts,tsx}: Use api.apiURL() for backend endpoints instead of constructing URLs directly
Use api.fileURL() for static file access instead of constructing URLs directly

Files:

src/composables/useLoad3d.ts

src/**/{composables,components}/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Clean up subscriptions in state management to prevent memory leaks

Files:

src/composables/useLoad3d.ts
src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
src/renderer/extensions/vueNodes/widgets/components/WidgetSelect.vue

src/**/{components,composables}/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Use vue-i18n for ALL user-facing strings by adding them to src/locales/en/main.json

Files:

src/composables/useLoad3d.ts
src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
src/renderer/extensions/vueNodes/widgets/components/WidgetSelect.vue

src/composables/**/*.ts

📄 CodeRabbit inference engine (AGENTS.md)

Name composables as useXyz.ts (e.g., useForm.ts)

Files:

src/composables/useLoad3d.ts

src/**/*.vue

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.vue: Use the Vue 3 Composition API instead of the Options API when writing Vue components (exception: when overriding or extending PrimeVue components for compatibility)
Use setup() function for component logic
Utilize ref and reactive for reactive state
Implement computed properties with computed()
Use watch and watchEffect for side effects
Implement lifecycle hooks with onMounted, onUpdated, etc.
Utilize provide/inject for dependency injection
Use vue 3.5 style of default prop declaration
Use Tailwind CSS for styling
Implement proper props and emits definitions
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Follow Vue 3 style guide and naming conventions

src/**/*.vue: Use Vue 3 Single File Components (SFCs) with Composition API only
Use <script setup lang="ts"> for component logic in Vue SFCs
Avoid <style> blocks in Vue components - use Tailwind 4 styling instead
Use vue-i18n for all string literals in Vue components - place translation entries in src/locales/en/main.json
Use Tailwind utility classes instead of dark: variant - use semantic values from style.css theme (e.g., bg-node-component-surface)
Use cn() utility from @/utils/tailwindUtil for merging Tailwind class names instead of :class="[]" or hardcoding
Never use !important or ! Tailwind prefix - fix interfering classes instead
Use Tailwind fraction utilities instead of arbitrary percentage values (e.g., w-4/5 instead of w-[80%])
Use TypeScript Vue 3.5 style default prop declaration with reactive props destructuring - avoid withDefaults or runtime props
Prefer defineModel over separately defining a prop and emit for v-model bindings
Define slots via template usage, not via defineSlots
Use same-name shorthand for slot prop bindings (e.g., :isExpanded instead of :is-expanded="isExpanded")
Do not import Vue macros unnecessarily
Avoid new usage of PrimeVue components
Use Tailwind's plurals system via i18n instead of hardcoding ...

Files:

src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
src/renderer/extensions/vueNodes/widgets/components/WidgetSelect.vue

🧠 Learnings (18)

📓 Common learnings

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Dropdown component with Select

📚 Learning: 2025-12-09T03:39:54.501Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7169
File: src/platform/remote/comfyui/jobs/jobTypes.ts:1-107
Timestamp: 2025-12-09T03:39:54.501Z
Learning: In the ComfyUI_frontend project, Zod is on v3.x. Do not suggest Zod v4 standalone validators (z.uuid, z.ulid, z.cuid2, z.nanoid) until an upgrade to Zod 4 is performed. When reviewing TypeScript files (e.g., src/platform/remote/comfyui/jobs/jobTypes.ts) validate against Zod 3 capabilities and avoid introducing v4-specific features; flag any proposal to upgrade or incorporate v4-only validators and propose staying with compatible 3.x patterns.

Applied to files:

src/types/widgetTypes.ts
src/composables/useLoad3d.ts

📚 Learning: 2025-12-13T11:03:11.264Z

Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7416
File: src/stores/imagePreviewStore.ts:5-7
Timestamp: 2025-12-13T11:03:11.264Z
Learning: In the ComfyUI_frontend repository, lint rules require keeping 'import type' statements separate from non-type imports, even if importing from the same module. Do not suggest consolidating them into a single import statement. Ensure type imports remain on their own line (import type { ... } from 'module') and regular imports stay on separate lines.

Applied to files:

src/types/widgetTypes.ts
src/composables/useLoad3d.ts

📚 Learning: 2025-12-17T00:40:09.635Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.stories.ts:45-55
Timestamp: 2025-12-17T00:40:09.635Z
Learning: Prefer pure function declarations over function expressions (e.g., use function foo() { ... } instead of const foo = () => { ... }) for pure functions in the repository. Function declarations are more functional-leaning, offer better hoisting clarity, and can improve readability and tooling consistency. Apply this guideline across TypeScript files in Comfy-Org/ComfyUI_frontend, including story and UI component code, except where a function expression is semantically required (e.g., callbacks, higher-order functions with closures).

Applied to files:

src/types/widgetTypes.ts
src/composables/useLoad3d.ts

📚 Learning: 2025-12-30T22:22:33.836Z

Learnt from: kaili-yang
Repo: Comfy-Org/ComfyUI_frontend PR: 7805
File: src/composables/useCoreCommands.ts:439-439
Timestamp: 2025-12-30T22:22:33.836Z
Learning: When accessing reactive properties from Pinia stores in TypeScript files, avoid using .value on direct property access (e.g., useStore().isOverlayExpanded). Pinia auto-wraps refs when accessed directly, returning the primitive value. The .value accessor is only needed when destructuring store properties or when using storeToRefs().

Applied to files:

src/types/widgetTypes.ts
src/composables/useLoad3d.ts

📚 Learning: 2025-12-11T12:25:15.470Z

Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:15.470Z
Learning: This repository uses CI automation to format code (pnpm format). Do not include manual formatting suggestions in code reviews for Comfy-Org/ComfyUI_frontend. If formatting issues are detected, rely on the CI formatter or re-run pnpm format. Focus reviews on correctness, readability, performance, accessibility, and maintainability rather than style formatting.

Applied to files:

src/types/widgetTypes.ts
src/composables/useLoad3d.ts
src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
src/renderer/extensions/vueNodes/widgets/components/WidgetSelect.vue

📚 Learning: 2026-01-12T17:39:27.738Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7906
File: src/components/sidebar/tabs/AssetsSidebarTab.vue:545-552
Timestamp: 2026-01-12T17:39:27.738Z
Learning: In Vue/TypeScript files (src/**/*.{ts,tsx,vue}), prefer if/else statements over ternary operators when performing side effects or actions (e.g., mutating state, calling methods with side effects). Ternaries should be reserved for computing and returning values.

Applied to files:

src/types/widgetTypes.ts
src/composables/useLoad3d.ts
src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
src/renderer/extensions/vueNodes/widgets/components/WidgetSelect.vue

📚 Learning: 2025-11-24T19:47:34.324Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:34.324Z
Learning: Applies to src/**/{services,composables}/**/*.{ts,tsx} : Use `api.fileURL()` for static file access instead of constructing URLs directly

Applied to files:

src/composables/useLoad3d.ts

📚 Learning: 2025-11-24T19:47:45.616Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Dropdown component with Select

Applied to files:

src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue

📚 Learning: 2025-12-09T03:49:52.828Z

Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 6300
File: src/platform/updates/components/WhatsNewPopup.vue:5-13
Timestamp: 2025-12-09T03:49:52.828Z
Learning: In Vue files across the ComfyUI_frontend repo, when a button is needed, prefer the repo's common button components from src/components/button/ (IconButton.vue, TextButton.vue, IconTextButton.vue) over plain HTML <button> elements. These components wrap PrimeVue with the project’s design system styling. Use only the common button components for consistency and theming, and import them from src/components/button/ as needed.

Applied to files:

src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
src/renderer/extensions/vueNodes/widgets/components/WidgetSelect.vue

📚 Learning: 2025-12-09T21:40:12.361Z

Learnt from: benceruleanlu
Repo: Comfy-Org/ComfyUI_frontend PR: 7297
File: src/components/actionbar/ComfyActionbar.vue:33-43
Timestamp: 2025-12-09T21:40:12.361Z
Learning: In Vue single-file components, allow inline Tailwind CSS class strings for static classes and avoid extracting them into computed properties solely for readability. Prefer keeping static class names inline for simplicity and performance. For dynamic or conditional classes, use Vue bindings (e.g., :class) to compose classes.

Applies to all Vue files in the repository (e.g., src/**/*.vue) where Tailwind utilities are used for static styling.

Applied to files:

src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
src/renderer/extensions/vueNodes/widgets/components/WidgetSelect.vue

📚 Learning: 2025-12-16T22:26:49.463Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.vue:17-17
Timestamp: 2025-12-16T22:26:49.463Z
Learning: In Vue 3.5+ with <script setup>, when using defineProps<Props>() with partial destructuring (e.g., const { as = 'button', class: customClass = '' } = defineProps<Props>() ), props that are not destructured (e.g., variant, size) stay accessible by name in the template scope. This pattern is valid: you can destructure only a subset of props for convenience while referencing the remaining props directly in template expressions. Apply this guideline to Vue components across the codebase (all .vue files).

Applied to files:

src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
src/renderer/extensions/vueNodes/widgets/components/WidgetSelect.vue

📚 Learning: 2025-12-22T21:36:08.369Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7649
File: src/platform/cloud/subscription/components/PricingTable.vue:185-201
Timestamp: 2025-12-22T21:36:08.369Z
Learning: In Vue components, avoid creating single-use variants for common UI components (e.g., Button and other shared components). Aim for reusable variants that cover multiple use cases. It’s acceptable to temporarily mix variant props with inline Tailwind classes when a styling need is unique to one place, but plan and consolidate into shared, reusable variants as patterns emerge across the codebase.

Applied to files:

src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
src/renderer/extensions/vueNodes/widgets/components/WidgetSelect.vue

📚 Learning: 2026-01-08T02:26:18.357Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7893
File: src/components/button/IconGroup.vue:5-6
Timestamp: 2026-01-08T02:26:18.357Z
Learning: In components that use the cn utility from '@/utils/tailwindUtil' with tailwind-merge, rely on the behavior that conflicting Tailwind classes are resolved by keeping the last one. For example, cn('base-classes bg-default', propClass) will have any conflicting background class from propClass override bg-default. This additive pattern is intentional and aligns with the shadcn-ui convention; ensure you document or review expectations accordingly in Vue components.

Applied to files:

src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
src/renderer/extensions/vueNodes/widgets/components/WidgetSelect.vue

📚 Learning: 2025-12-11T03:55:51.755Z

Learnt from: simula-r
Repo: Comfy-Org/ComfyUI_frontend PR: 7252
File: src/renderer/extensions/vueNodes/components/ImagePreview.vue:151-158
Timestamp: 2025-12-11T03:55:51.755Z
Learning: In Vue components under src/renderer/extensions/vueNodes (e.g., ImagePreview.vue and LGraphNode.vue), implement image gallery keyboard navigation so that it responds to the node's focus state rather than requiring focus inside the image preview wrapper. Achieve this by wiring keyEvent handling at the node focus level and injecting or propagating key events (arrow keys) to the gallery when the node is focused/selected. This improves accessibility and aligns navigation with node-level focus behavior.

Applied to files:

src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
src/renderer/extensions/vueNodes/widgets/components/WidgetSelect.vue

📚 Learning: 2025-12-18T02:07:38.870Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7598
File: src/components/sidebar/tabs/AssetsSidebarTab.vue:131-131
Timestamp: 2025-12-18T02:07:38.870Z
Learning: Tailwind CSS v4 safe utilities (e.g., items-center-safe, justify-*-safe, place-*-safe) are allowed in Vue components under src/ and in story files. Do not flag these specific safe variants as invalid when reviewing code in src/**/*.vue or related stories.

Applied to files:

src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
src/renderer/extensions/vueNodes/widgets/components/WidgetSelect.vue

📚 Learning: 2025-12-18T21:15:46.862Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7603
File: src/components/queue/QueueOverlayHeader.vue:49-59
Timestamp: 2025-12-18T21:15:46.862Z
Learning: In the ComfyUI_frontend repository, for Vue components, do not add aria-label to buttons that have visible text content (e.g., buttons containing <span> text). The visible text provides the accessible name. Use aria-label only for elements without visible labels (e.g., icon-only buttons). If a button has no visible label, provide a clear aria-label or associate with an aria-labelledby describing its action.

Applied to files:

src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
src/renderer/extensions/vueNodes/widgets/components/WidgetSelect.vue

📚 Learning: 2025-12-21T01:06:02.786Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7649
File: src/components/graph/selectionToolbox/ColorPickerButton.vue:15-18
Timestamp: 2025-12-21T01:06:02.786Z
Learning: In Comfy-Org/ComfyUI_frontend, in Vue component files, when a filled icon is required (e.g., 'pi pi-circle-fill'), you may mix PrimeIcons with Lucide icons since Lucide lacks filled variants. This mixed usage is acceptable when one icon library does not provide an equivalent filled icon. Apply consistently across Vue components in the src directory where icons are used, and document the rationale when a mixed approach is chosen.

Applied to files:

src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
src/renderer/extensions/vueNodes/widgets/components/WidgetSelect.vue

🔇 Additional comments (6)

src/types/widgetTypes.ts (1)

3-9: LGTM!

The mesh variant is a clean addition to the AssetKind union, enabling cohesive 3D mesh asset handling across the widget system.

src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue (3)

116-147: LGTM!

The outputItems computed property is correctly extended to handle mesh assets. The guard condition and the output.is3D check align with the existing patterns for image and video.

186-187: LGTM!

Appropriately maps the mesh asset kind to the model placeholder translation.

331-337: No action needed—empty mediaSrc for mesh assets is handled gracefully.

The getMediaUrl function correctly returns an empty string for mesh assets since they are 3D models, not viewable as images or videos. The FormDropdownMenuItem component explicitly handles empty mediaSrc with a fallback gradient background (v-else clause on line 117–120), so mesh items display properly without broken thumbnails or blank spaces.

src/renderer/extensions/vueNodes/widgets/components/WidgetSelect.vue (2)

62-72: LGTM!

The isLoad3DMesh condition correctly identifies the Load3D node's model file widget, and the guard is appropriately extended to allow processing when no comboSpec is present for this specific case.

74-91: LGTM!

The safe destructuring with spec || {} and the mesh kind assignment follow the established patterns for other asset types.

src/composables/useLoad3d.ts

src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue

github-actions · 2026-01-13T13:26:15Z

Bundle Size Report

Summary

Raw size: 19.7 MB baseline 19.7 MB — 🟢 -33 B
Gzip: 4.01 MB baseline 4.01 MB — 🔴 +44 B
Brotli: 3.06 MB baseline 3.06 MB — 🟢 -126 B
Bundles: 99 current • 99 baseline • 38 added / 38 removed

Category Glance
Graph Workspace 🟢 -683 B (1.15 MB) · UI Components 🔴 +421 B (209 kB) · App Entry Points 🔴 +229 B (3.34 MB) · Vendor & Third-Party ⚪ 0 B (9.34 MB) · Other ⚪ 0 B (5.25 MB) · Panels & Settings ⚪ 0 B (372 kB) · + 3 more

Per-category breakdown

App Entry Points — 3.34 MB (baseline 3.34 MB) • 🔴 +229 B

Main entry bundles and manifests

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/index-BihmDxe-.js (new)	—	3.14 MB	🔴 +3.14 MB	🔴 +657 kB	🔴 +499 kB
~~assets/index-DN1btu9R.js~~ (removed)	3.14 MB	—	🟢 -3.14 MB	🟢 -657 kB	🟢 -499 kB
assets/index-CdfREato.js (new)	—	200 kB	🔴 +200 kB	🔴 +44 kB	🔴 +36.4 kB
~~assets/index-CUMUoYMe.js~~ (removed)	200 kB	—	🟢 -200 kB	🟢 -44.1 kB	🟢 -36.4 kB
~~assets/index-CQJ5iGZ5.js~~ (removed)	345 B	—	🟢 -345 B	🟢 -247 B	🟢 -232 B
assets/index-CuwbKC6z.js (new)	—	345 B	🔴 +345 B	🔴 +244 B	🔴 +239 B

Status: 3 added / 3 removed

Graph Workspace — 1.15 MB (baseline 1.15 MB) • 🟢 -683 B

Graph editor runtime, canvas, workflow orchestration

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
~~assets/GraphView-C8PrQRv8.js~~ (removed)	1.15 MB	—	🟢 -1.15 MB	🟢 -220 kB	🟢 -165 kB
assets/GraphView-Dh95K8u2.js (new)	—	1.15 MB	🔴 +1.15 MB	🔴 +220 kB	🔴 +165 kB

Status: 1 added / 1 removed

Views & Navigation — 6.66 kB (baseline 6.66 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
~~assets/UserSelectView-CwqzY-CW.js~~ (removed)	6.66 kB	—	🟢 -6.66 kB	🟢 -2.16 kB	🟢 -1.91 kB
assets/UserSelectView-gagSvz3v.js (new)	—	6.66 kB	🔴 +6.66 kB	🔴 +2.16 kB	🔴 +1.92 kB

Status: 1 added / 1 removed

Panels & Settings — 372 kB (baseline 372 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/LegacyCreditsPanel-BX5sTo9Z.js (new)	—	25.2 kB	🔴 +25.2 kB	🔴 +5.76 kB	🔴 +5.02 kB
~~assets/LegacyCreditsPanel-C6ZscrP1.js~~ (removed)	25.2 kB	—	🟢 -25.2 kB	🟢 -5.76 kB	🟢 -5.02 kB
~~assets/KeybindingPanel-DRhOMyAj.js~~ (removed)	14.9 kB	—	🟢 -14.9 kB	🟢 -3.59 kB	🟢 -3.13 kB
assets/KeybindingPanel-tdM5Echf.js (new)	—	14.9 kB	🔴 +14.9 kB	🔴 +3.59 kB	🔴 +3.14 kB
assets/ExtensionPanel-DcllB_iG.js (new)	—	11.1 kB	🔴 +11.1 kB	🔴 +2.63 kB	🔴 +2.31 kB
~~assets/ExtensionPanel-DEiG_GJk.js~~ (removed)	11.1 kB	—	🟢 -11.1 kB	🟢 -2.63 kB	🟢 -2.31 kB
~~assets/AboutPanel-Cmtowgcy.js~~ (removed)	9.2 kB	—	🟢 -9.2 kB	🟢 -2.47 kB	🟢 -2.23 kB
assets/AboutPanel-CmxUZ3cs.js (new)	—	9.2 kB	🔴 +9.2 kB	🔴 +2.47 kB	🔴 +2.23 kB
~~assets/ServerConfigPanel-DqywrswA.js~~ (removed)	7.55 kB	—	🟢 -7.55 kB	🟢 -2.06 kB	🟢 -1.83 kB
assets/ServerConfigPanel-ZtAg6M1B.js (new)	—	7.55 kB	🔴 +7.55 kB	🔴 +2.06 kB	🔴 +1.83 kB
~~assets/UserPanel-DnimeCnq.js~~ (removed)	6.92 kB	—	🟢 -6.92 kB	🟢 -1.8 kB	🟢 -1.58 kB
assets/UserPanel-DXch_YJ2.js (new)	—	6.92 kB	🔴 +6.92 kB	🔴 +1.8 kB	🔴 +1.58 kB
assets/settings-BGQfQzTx.js	25.6 kB	25.6 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-BVE4KHTw.js	22.7 kB	22.7 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-BVtpJmlU.js	30.9 kB	30.9 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-C2aO00Dz.js	28.6 kB	28.6 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-Cm3ieBXR.js	27.8 kB	27.8 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-CzQKMdK3.js	26.2 kB	26.2 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-CzYUIUnL.js	27.1 kB	27.1 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-DwKpL7jw.js	26.3 kB	26.3 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-DX8feV4n.js	25.3 kB	25.3 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-mWzYycGc.js	22 kB	22 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-U4AdZ8Rl.js	34.9 kB	34.9 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

Status: 6 added / 6 removed

UI Components — 209 kB (baseline 209 kB) • 🔴 +421 B

Reusable component library chunks

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/LazyImage.vue_vue_type_script_setup_true_lang-Bts_tBWO.js (new)	—	69.6 kB	🔴 +69.6 kB	🔴 +14.2 kB	🔴 +12.3 kB
~~assets/LazyImage.vue_vue_type_script_setup_true_lang-jx7GFiZh.js~~ (removed)	69.6 kB	—	🟢 -69.6 kB	🟢 -14.2 kB	🟢 -12.3 kB
~~assets/Load3D.vue_vue_type_script_setup_true_lang-BUf9SZIj.js~~ (removed)	56.4 kB	—	🟢 -56.4 kB	🟢 -8.78 kB	🟢 -7.55 kB
assets/Load3D.vue_vue_type_script_setup_true_lang-CYU_iTmd.js (new)	—	56.4 kB	🔴 +56.4 kB	🔴 +8.78 kB	🔴 +7.53 kB
assets/WidgetSelect.vue_vue_type_script_setup_true_lang-DOozepPB.js (new)	—	48.5 kB	🔴 +48.5 kB	🔴 +10.5 kB	🔴 +9.11 kB
~~assets/WidgetSelect.vue_vue_type_script_setup_true_lang-Du7k85GI.js~~ (removed)	48.1 kB	—	🟢 -48.1 kB	🟢 -10.4 kB	🟢 -9.01 kB
~~assets/WidgetInputNumber.vue_vue_type_script_setup_true_lang-3XVhQax7.js~~ (removed)	16.4 kB	—	🟢 -16.4 kB	🟢 -4.11 kB	🟢 -3.65 kB
assets/WidgetInputNumber.vue_vue_type_script_setup_true_lang-DfaInBZ0.js (new)	—	16.4 kB	🔴 +16.4 kB	🔴 +4.11 kB	🔴 +3.64 kB
assets/ComfyQueueButton-B8FpNB25.js (new)	—	8.87 kB	🔴 +8.87 kB	🔴 +2.6 kB	🔴 +2.31 kB
~~assets/ComfyQueueButton-bzq3CIis.js~~ (removed)	8.87 kB	—	🟢 -8.87 kB	🟢 -2.6 kB	🟢 -2.31 kB
assets/WidgetWithControl.vue_vue_type_script_setup_true_lang-BUsAq9qd.js (new)	—	3.75 kB	🔴 +3.75 kB	🔴 +1.47 kB	🔴 +1.33 kB
~~assets/WidgetWithControl.vue_vue_type_script_setup_true_lang-FtvFLreT.js~~ (removed)	3.75 kB	—	🟢 -3.75 kB	🟢 -1.47 kB	🟢 -1.33 kB
~~assets/WidgetButton-Cm9rQsCt.js~~ (removed)	2.25 kB	—	🟢 -2.25 kB	🟢 -1.01 kB	🟢 -909 B
assets/WidgetButton-Ko-BzuiG.js (new)	—	2.25 kB	🔴 +2.25 kB	🔴 +1.01 kB	🔴 +889 B
~~assets/WidgetLayoutField.vue_vue_type_script_setup_true_lang-B_5xIQWy.js~~ (removed)	2.14 kB	—	🟢 -2.14 kB	🟢 -891 B	🟢 -775 B
assets/WidgetLayoutField.vue_vue_type_script_setup_true_lang-DzYuQQzz.js (new)	—	2.14 kB	🔴 +2.14 kB	🔴 +891 B	🔴 +771 B
assets/UserAvatar.vue_vue_type_script_setup_true_lang-IJTLOeU1.js	1.34 kB	1.34 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

Status: 8 added / 8 removed

Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 B

Stores, services, APIs, and repositories

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
~~assets/keybindingService-BBkVC0Ai.js~~ (removed)	7.51 kB	—	🟢 -7.51 kB	🟢 -1.83 kB	🟢 -1.57 kB
assets/keybindingService-DjkamHrt.js (new)	—	7.51 kB	🔴 +7.51 kB	🔴 +1.83 kB	🔴 +1.57 kB
assets/audioService-BQQHZ8jK.js (new)	—	2.2 kB	🔴 +2.2 kB	🔴 +962 B	🔴 +830 B
~~assets/audioService-CY7gvPaK.js~~ (removed)	2.2 kB	—	🟢 -2.2 kB	🟢 -962 B	🟢 -829 B
assets/serverConfigStore-DyIvWaGz.js	2.83 kB	2.83 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

Status: 2 added / 2 removed

Utilities & Hooks — 1.41 kB (baseline 1.41 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/audioUtils-BowIwYrK.js (new)	—	1.41 kB	🔴 +1.41 kB	🔴 +650 B	🔴 +543 B
~~assets/audioUtils-D4McwaI0.js~~ (removed)	1.41 kB	—	🟢 -1.41 kB	🟢 -649 B	🟢 -552 B

Status: 1 added / 1 removed

Vendor & Third-Party — 9.34 MB (baseline 9.34 MB) • ⚪ 0 B

External libraries and shared vendor chunks

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/vendor-chart-DZdD68iT.js	452 kB	452 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-other-C9GFBFnP.js	3.93 MB	3.93 MB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-primevue-NX-4NPlN.js	1.95 MB	1.95 MB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-reka-ui-7Sidv1he.js	111 kB	111 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-three-Bz1zdJb0.js	2.08 MB	2.08 MB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-tiptap-DFkXpum7.js	232 kB	232 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-vue-DMH2Ziq4.js	165 kB	165 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-xterm-BF8peZ5_.js	420 kB	420 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

Other — 5.25 MB (baseline 5.25 MB) • ⚪ 0 B

Bundles that do not match a named category

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/SubscriptionRequiredDialogContent-Ck5ylUnw.js (new)	—	29.4 kB	🔴 +29.4 kB	🔴 +6.52 kB	🔴 +5.68 kB
~~assets/SubscriptionRequiredDialogContent-t4aUMouw.js~~ (removed)	29.4 kB	—	🟢 -29.4 kB	🟢 -6.53 kB	🟢 -5.69 kB
~~assets/WidgetRecordAudio-B-PNBbVr.js~~ (removed)	20.5 kB	—	🟢 -20.5 kB	🟢 -5.25 kB	🟢 -4.65 kB
assets/WidgetRecordAudio-lawafrR9.js (new)	—	20.5 kB	🔴 +20.5 kB	🔴 +5.25 kB	🔴 +4.65 kB
assets/AudioPreviewPlayer-BU8vVR1Y.js (new)	—	13.4 kB	🔴 +13.4 kB	🔴 +3.36 kB	🔴 +3.01 kB
~~assets/AudioPreviewPlayer-N89nCzAe.js~~ (removed)	13.4 kB	—	🟢 -13.4 kB	🟢 -3.36 kB	🟢 -3.01 kB
assets/ValueControlPopover-B4yBKBw-.js (new)	—	5.53 kB	🔴 +5.53 kB	🔴 +1.72 kB	🔴 +1.53 kB
~~assets/ValueControlPopover-DJ9MXHb8.js~~ (removed)	5.53 kB	—	🟢 -5.53 kB	🟢 -1.72 kB	🟢 -1.53 kB
~~assets/WidgetGalleria-BOHIeMgU.js~~ (removed)	4.14 kB	—	🟢 -4.14 kB	🟢 -1.46 kB	🟢 -1.32 kB
assets/WidgetGalleria-moCGjhdm.js (new)	—	4.14 kB	🔴 +4.14 kB	🔴 +1.46 kB	🔴 +1.32 kB
assets/WidgetColorPicker-BFJRtWn7.js (new)	—	3.44 kB	🔴 +3.44 kB	🔴 +1.4 kB	🔴 +1.25 kB
~~assets/WidgetColorPicker-C0tqHpYN.js~~ (removed)	3.44 kB	—	🟢 -3.44 kB	🟢 -1.4 kB	🟢 -1.25 kB
assets/WidgetTextarea-DbS7b0Ur.js (new)	—	3.12 kB	🔴 +3.12 kB	🔴 +1.23 kB	🔴 +1.09 kB
~~assets/WidgetTextarea-XEmJGJXW.js~~ (removed)	3.12 kB	—	🟢 -3.12 kB	🟢 -1.23 kB	🟢 -1.09 kB
assets/WidgetMarkdown-D9J7T1IE.js (new)	—	3.12 kB	🔴 +3.12 kB	🔴 +1.29 kB	🔴 +1.14 kB
~~assets/WidgetMarkdown-DaNC-XOF.js~~ (removed)	3.12 kB	—	🟢 -3.12 kB	🟢 -1.29 kB	🟢 -1.14 kB
assets/WidgetAudioUI-D5Thgzzj.js (new)	—	2.93 kB	🔴 +2.93 kB	🔴 +1.18 kB	🔴 +1.07 kB
~~assets/WidgetAudioUI-XI1yyTI8.js~~ (removed)	2.93 kB	—	🟢 -2.93 kB	🟢 -1.19 kB	🟢 -1.07 kB
assets/WidgetToggleSwitch-ChCYR4JO.js (new)	—	2.7 kB	🔴 +2.7 kB	🔴 +1.14 kB	🔴 +1.02 kB
~~assets/WidgetToggleSwitch-idyTj3Ey.js~~ (removed)	2.7 kB	—	🟢 -2.7 kB	🟢 -1.14 kB	🟢 -1.04 kB
~~assets/WidgetInputText-D1NNHANh.js~~ (removed)	2.03 kB	—	🟢 -2.03 kB	🟢 -937 B	🟢 -864 B
assets/WidgetInputText-D4Z2Fcpm.js (new)	—	2.03 kB	🔴 +2.03 kB	🔴 +936 B	🔴 +862 B
~~assets/Media3DTop-bf-TQtaB.js~~ (removed)	1.53 kB	—	🟢 -1.53 kB	🟢 -781 B	🟢 -672 B
assets/Media3DTop-DeVo_46E.js (new)	—	1.53 kB	🔴 +1.53 kB	🔴 +781 B	🔴 +667 B
assets/WidgetSelect-B81-XL5O.js (new)	—	772 B	🔴 +772 B	🔴 +372 B	🔴 +346 B
~~assets/WidgetSelect-DbyOI-1b.js~~ (removed)	772 B	—	🟢 -772 B	🟢 -379 B	🟢 -345 B
assets/WidgetInputNumber-tsUDjA3M.js (new)	—	712 B	🔴 +712 B	🔴 +360 B	🔴 +330 B
~~assets/WidgetInputNumber-VhTxGn0p.js~~ (removed)	712 B	—	🟢 -712 B	🟢 -362 B	🟢 -325 B
~~assets/Load3D-DR1vkzS3.js~~ (removed)	463 B	—	🟢 -463 B	🟢 -282 B	🟢 -238 B
assets/Load3D-RAKMYA6m.js (new)	—	463 B	🔴 +463 B	🔴 +282 B	🔴 +238 B
~~assets/WidgetLegacy-DpFRNz_P.js~~ (removed)	403 B	—	🟢 -403 B	🟢 -250 B	🟢 -212 B
assets/WidgetLegacy-hsD3OcAw.js (new)	—	403 B	🔴 +403 B	🔴 +252 B	🔴 +211 B
assets/commands-B32ZbeYu.js	16.5 kB	16.5 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-B7wQT83I.js	17 kB	17 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-BK3JVjMG.js	15.7 kB	15.7 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-C6twMpaZ.js	15.5 kB	15.5 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-CDUWpEwM.js	18.3 kB	18.3 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-CfZ6FPZ-.js	15.7 kB	15.7 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-COIPP_pv.js	17 kB	17 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-CoPn_77e.js	14.7 kB	14.7 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-CuRNS4XD.js	14.9 kB	14.9 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-DBHjCSPA.js	16.2 kB	16.2 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-DZJaRLKH.js	15.7 kB	15.7 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-8eC7XcBf.js	95 kB	95 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-BpcYE6Bq.js	109 kB	109 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-BRhbiQsB.js	129 kB	129 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-BrWdnTiG.js	113 kB	113 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-C-cUNbuc.js	123 kB	123 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-CGe0e9vH.js	106 kB	106 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-Cv9Dlj-b.js	107 kB	107 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-CzsdJqwO.js	94.3 kB	94.3 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-Dbu4m_fl.js	133 kB	133 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-DwAX_AEJ.js	149 kB	149 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-kiVYDd2_.js	110 kB	110 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/MediaAudioTop-DUiRGHAk.js	1.46 kB	1.46 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/MediaImageTop-bDoNEAep.js	1.75 kB	1.75 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/MediaVideoTop-BrNs2ijx.js	2.65 kB	2.65 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-B-XzzBeS.js	317 kB	317 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-BGwoeek4.js	329 kB	329 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-C6xl5-mL.js	358 kB	358 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-CRZGOJB7.js	310 kB	310 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-D8-Yzlzh.js	289 kB	289 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-Du8VrAwA.js	320 kB	320 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-jjlLVrIs.js	317 kB	317 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-JQwk1kgy.js	292 kB	292 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-JuuXdMpv.js	391 kB	391 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-l2Y20bod.js	314 kB	314 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-VLMdhOwo.js	357 kB	357 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/OBJLoader2WorkerModule-DTMpvldF.js	109 kB	109 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/WidgetChart-CTa5K4p_.js	2.48 kB	2.48 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/WidgetImageCompare-BAyqYPiH.js	3.21 kB	3.21 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/widgetPropFilter-BIbGSUAt.js	1.28 kB	1.28 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

Status: 16 added / 16 removed

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

jtydhr88 · 2026-02-10T02:11:41Z

use #8765 instead, close this

## Summary Add mesh_upload and upload_subfolder to combo input schema so WidgetSelect detects mesh uploads generically instead of hardcoding node type checks. Inject these flags in load3dLazy.ts so they are available before THREE.js loads. Also unify SUPPORTED_EXTENSIONS_ACCEPT across load3d and dropdown, pass uploadSubfolder prop through to WidgetSelectDropdown for correct upload path, and update error message to list all supported extensions. replacement for #7975 (We should include thumbnail but not yet, will do it later) ## Screenshots (if applicable) https://github.com/user-attachments/assets/2cb4b1da-af4f-439b-9786-3ac780c2480d ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-8765-Feat-3d-dropdown-3036d73d365081d8a10ee19d3ed7d295) by [Unito](https://www.unito.io) --------- Co-authored-by: Kelly Yang <124ykl@gmail.com>

feat/3d-dropdown

22aa15f

kaili-yang requested a review from a team as a code owner January 13, 2026 01:11

dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 13, 2026

coderabbitai bot reviewed Jan 13, 2026

View reviewed changes

src/composables/useLoad3d.ts Outdated Show resolved Hide resolved

src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue Show resolved Hide resolved

jtydhr88 self-requested a review January 13, 2026 13:23

Update src/composables/useLoad3d.ts

4912011

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

coderabbitai bot requested review from PabloWiedemann and christian-byrne January 14, 2026 21:06

christian-byrne assigned jtydhr88 Jan 15, 2026

jtydhr88 mentioned this pull request Feb 10, 2026

Feat/3d dropdown #8765

Merged

jtydhr88 closed this Feb 10, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat/3d-dropdown #7975

feat/3d-dropdown #7975

kaili-yang commented Jan 13, 2026 •

edited by sync-by-unito bot

Loading

Uh oh!

coderabbitai bot commented Jan 13, 2026 •

edited

Loading

Walkthrough

Changes

Possibly related PRs

Suggested reviewers

Uh oh!

github-actions bot commented Jan 13, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 13, 2026 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 13, 2026 •

edited

Loading

Uh oh!

jtydhr88 commented Feb 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

feat/3d-dropdown #7975

feat/3d-dropdown #7975

Conversation

kaili-yang commented Jan 13, 2026 • edited by sync-by-unito bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Screenshots

Uh oh!

coderabbitai bot commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Possibly related PRs

Suggested reviewers

Uh oh!

github-actions bot commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎨 Storybook Build Status

🚀 Building Storybook

Uh oh!

github-actions bot commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎭 Playwright Tests: ⚠️ Passed with flaky tests

❌ Failed Tests

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Size Report

Uh oh!

jtydhr88 commented Feb 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kaili-yang commented Jan 13, 2026 •

edited by sync-by-unito bot

Loading

coderabbitai bot commented Jan 13, 2026 •

edited

Loading

github-actions bot commented Jan 13, 2026 •

edited

Loading

github-actions bot commented Jan 13, 2026 •

edited

Loading

github-actions bot commented Jan 13, 2026 •

edited

Loading