Skip to content

Road to No Explicit Any Part 4: LiteGraph Cleanup #7970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Myestery merged 8 commits into from
Jan 14, 2026
Merged

Road to No Explicit Any Part 4: LiteGraph Cleanup #7970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3f61d89
fix(litegraph): remove unnecessary as any cast in SubgraphIONodeBase
Myestery Jan 12, 2026
41a5991
fix(litegraph): define Panel interface and type createPanel function
Myestery Jan 12, 2026
c618e96
fix(litegraph): type LGraphNode panel callbacks and onGetPropertyInfo
Myestery Jan 12, 2026
4069676
fix(litegraph): remove remaining any types from LGraphCanvas
Myestery Jan 12, 2026
71a78af
[automated] Apply ESLint and Prettier fixes
actions-user Jan 12, 2026
42b4fce
fix(litegraph): address PR review feedback
Myestery Jan 13, 2026
ffa8e3b
apply correct type to PanelWidgetOptions values
Myestery Jan 14, 2026
94aa490
fix interfaces
Myestery Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/lib/litegraph/src/LGraph.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -842,8 +842,13 @@ export class LGraph
if (!list_of_graphcanvas) return

for (const c of list_of_graphcanvas) {
// eslint-disable-next-line prefer-spread
c[action]?.apply(c, params)
const method = c[action]

if (typeof method === 'function') {
const args =
params == null ? [] : Array.isArray(params) ? params : [params]
;(method as (...args: unknown[]) => unknown).apply(c, args)
}
Comment on lines +845 to +851
Copy link
Collaborator

@AustinMroz AustinMroz Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const method = c[action]
if (typeof method === 'function') {
const args =
params == null ? [] : Array.isArray(params) ? params : [params]
;(method as (...args: unknown[]) => unknown).apply(c, args)
}
this.canvasAction((c) => c[action]?.(params))

From personal testing, the above seems to satisfy the compiler.

I would hope that there's a nicer way to do this given how well typed the inputs to this function are, but it's not anything I would consider blocking.

}
}

Expand Down
Loading