Skip to content

[backport cloud/1.36] feat: add HoneyToast component for persistent progress notifications#7918

Merged
luke-mino-altherr merged 1 commit intocloud/1.36from
backport-7902-to-cloud-1.36
Jan 9, 2026
Merged

[backport cloud/1.36] feat: add HoneyToast component for persistent progress notifications#7918
luke-mino-altherr merged 1 commit intocloud/1.36from
backport-7902-to-cloud-1.36

Conversation

@luke-mino-altherr
Copy link
Contributor

@luke-mino-altherr luke-mino-altherr commented Jan 9, 2026 •
edited by sync-by-unito bot
Loading

Backport of #7902 to cloud/1.36

Original PR: #7902

Cherry-picked merge commit e26e1f0.

Conflicts resolved

  • pnpm-lock.yaml: Regenerated with pnpm install
  • tests-ui/tests/components/dialog/footer/ManagerProgressFooter.test.ts: Removed (PR deletes this file along with the component it tested)

┆Issue is synchronized with this Notion page by Unito

@DrJKL @ampcode-com
@coderabbitai @snomiao @actions-user @luke-mino-altherr
feat: add HoneyToast component for persistent progress notifications (#…
bcbf27f 
…7902)

Add HoneyToast, a persistent bottom-anchored notification component for
long-running task progress, and migrate existing progress dialogs to use
it.

- **What**:
- New `HoneyToast` component with slot-based API, Teleport, transitions,
and accessibility
  - Migrated `ModelImportProgressDialog` to use HoneyToast
- Created `ManagerProgressToast` combining the old Header/Content/Footer
components
- Deleted deprecated `ManagerProgressDialogContent`,
`ManagerProgressHeader`, `ManagerProgressFooter`, and
`useManagerProgressDialogStore`
- Removed no-op
`showManagerProgressDialog`/`toggleManagerProgressDialog` functions
  - Added Storybook stories for HoneyToast and ProgressToastItem

- HoneyToast component design and slot API
- ManagerProgressToast self-contained state management (auto-shows when
`comfyManagerStore.taskLogs.length > 0`)
- Accessibility attributes on the toast component

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7902-feat-add-HoneyToast-component-for-persistent-progress-notifications-2e26d73d365081c78ae6edc5accb326e)
by [Unito](https://www.unito.io)

---------

Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: sno <snomiao@gmail.com>
Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: GitHub Action <action@github.com>
@luke-mino-altherr luke-mino-altherr added the backport Backporting a PR onto a release candidate label Jan 9, 2026
@luke-mino-altherr luke-mino-altherr added the backport Backporting a PR onto a release candidate label Jan 9, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 9, 2026 •
edited
Loading

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Comment @coderabbitai help to get the list of available commands and usage tips.

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Jan 9, 2026
@github-actions
Copy link

github-actions bot commented Jan 9, 2026 •
edited
Loading

🎨 Storybook Build Status

✅ Build completed successfully!

⏰ Completed at: 01/09/2026, 01:36:20 AM UTC

🔗 Links

🎉 Your Storybook is ready for review!

@github-actions
Copy link

github-actions bot commented Jan 9, 2026 •
edited
Loading

🎭 Playwright Test Results

⚠️ Tests passed with flaky tests

⏰ Completed at: 01/09/2026, 01:44:55 AM UTC

📈 Summary

  • Total Tests: 511
  • Passed: 500 ✅
  • Failed: 0
  • Flaky: 3 ⚠️
  • Skipped: 8 ⏭️

📊 Test Reports by Browser

  • ✅ chromium: View Report • ✅ 488 / ❌ 0 / ⚠️ 3 / ⏭️ 8
  • ✅ chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • ✅ chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • ✅ mobile-chrome: View Report • ✅ 9 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

@socket-security
Copy link

socket-security bot commented Jan 9, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Updated@​pinia/​testing@​0.1.5 ⏵ 0.1.7100 +110068 +383 +3100
Addedpicocolors@​1.1.11001007380100
Addedvite@​7.3.0921008299100
Addedsemver@​7.7.310010010087100
Updated@​sentry/​vue@​8.48.0 ⏵ 8.55.0100 +110090 +195 -5100
Addedtypescript@​5.9.31001009010090
Addedprettier@​3.7.4901009795100
Added@​storybook/​addon-mcp@​0.1.69810010099100

View full report

@socket-security
Copy link

socket-security bot commented Jan 9, 2026

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
Obfuscated code: npm safer-buffer is 94.0% likely obfuscated

Confidence: 0.94

Location: Package overview

From: pnpm-lock.yaml → npm/safer-buffer@2.1.2

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/safer-buffer@2.1.2. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
Obfuscated code: npm vite is 91.0% likely obfuscated

Confidence: 0.91

Location: Package overview

From: apps/desktop-ui/package.json → npm/vite@7.3.0

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/vite@7.3.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@luke-mino-altherr luke-mino-altherr merged commit b9e6f3d into cloud/1.36 Jan 9, 2026
38 checks passed
@luke-mino-altherr luke-mino-altherr deleted the backport-7902-to-cloud-1.36 branch January 9, 2026 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@viva-jinyi viva-jinyi Awaiting requested review from viva-jinyi viva-jinyi is a code owner

@christian-byrne christian-byrne Awaiting requested review from christian-byrne christian-byrne is a code owner

@ltdrdata ltdrdata Awaiting requested review from ltdrdata ltdrdata is a code owner

Assignees

No one assigned

Labels

backport Backporting a PR onto a release candidate size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@luke-mino-altherr @DrJKL