Conversation
dosubot
bot
added
the
size:XS
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 01/08/2026, 11:10:24 PM UTC 🔗 Links🎉 Your Storybook is ready for review! |
🎭 Playwright Test Results❌ Some tests failed ⏰ Completed at: 01/08/2026, 11:33:16 PM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
Contributor
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (3)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the 📝 WalkthroughWalkthroughThe button variants configuration was updated to prepend the Changes
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 3.25 MB (baseline 3.25 MB) • 🔴 +9 BMain entry bundles and manifests
Status: 3 added / 3 removed Graph Workspace — 1.03 MB (baseline 1.03 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 6.63 kB (baseline 6.63 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 1 added / 1 removed Panels & Settings — 300 kB (baseline 300 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 6 added / 6 removed UI Components — 197 kB (baseline 197 kB) • ⚪ 0 BReusable component library chunks
Status: 8 added / 8 removed Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 2 added / 2 removed Utilities & Hooks — 1.41 kB (baseline 1.41 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 1 added / 1 removed Vendor & Third-Party — 9.19 MB (baseline 9.19 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 3.6 MB (baseline 3.6 MB) • ⚪ 0 BBundles that do not match a named category
Status: 16 added / 16 removed |
christian-byrne
added
needs-backport
Contributor
Author
I cannot even see the error in the diff |
DrJKL
previously approved these changes
Jan 8, 2026
DrJKL
added
the
New Browser Test Expectations
|
Updating Playwright Expectations |
github-actions
bot
removed
the
New Browser Test Expectations
github-actions bot
pushed a commit
that referenced
this pull request
Jan 9, 2026
## Summary Restore the shared button's positioning context so the run-queue badge anchors to the correct spot. ## Changes - **What**: add `position: relative` back to `button.variants.ts` so badge overlays stay attached to their buttons ## Review Focus - Make sure no buttons rely on being `position: static` (should be unaffected) and that the run badge now sits beside the Run button instead of the window edge. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7912-Fix-run-badge-anchoring-2e26d73d365081aa8fefe5381f37cfa4) by [Unito](https://www.unito.io) --------- Co-authored-by: github-actions <github-actions@github.com>
github-actions bot
pushed a commit
that referenced
this pull request
Jan 9, 2026
## Summary Restore the shared button's positioning context so the run-queue badge anchors to the correct spot. ## Changes - **What**: add `position: relative` back to `button.variants.ts` so badge overlays stay attached to their buttons ## Review Focus - Make sure no buttons rely on being `position: static` (should be unaffected) and that the run badge now sits beside the Run button instead of the window edge. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7912-Fix-run-badge-anchoring-2e26d73d365081aa8fefe5381f37cfa4) by [Unito](https://www.unito.io) --------- Co-authored-by: github-actions <github-actions@github.com>
Member
|
@christian-byrne Successfully backported to #7914 |
Member
|
@christian-byrne Successfully backported to #7915 |
github-actions
bot
removed
the
needs-backport
christian-byrne
added a commit
that referenced
this pull request
Jan 9, 2026
Backport of #7912 to `core/1.36` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7914-backport-core-1-36-Fix-run-badge-anchoring-2e36d73d365081978397c495e29440ea) by [Unito](https://www.unito.io) Co-authored-by: Christian Byrne <cbyrne@comfy.org> Co-authored-by: github-actions <github-actions@github.com>
christian-byrne
added a commit
that referenced
this pull request
Jan 9, 2026
Backport of #7912 to `cloud/1.36` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7915-backport-cloud-1-36-Fix-run-badge-anchoring-2e36d73d36508160a874dea0a732a9af) by [Unito](https://www.unito.io) Co-authored-by: Christian Byrne <cbyrne@comfy.org> Co-authored-by: github-actions <github-actions@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore the shared button's positioning context so the run-queue badge anchors to the correct spot.
Changes
position: relativeback tobutton.variants.tsso badge overlays stay attached to their buttonsReview Focus
position: static(should be unaffected) and that the run badge now sits beside the Run button instead of the window edge.┆Issue is synchronized with this Notion page by Unito