Skip to content

[backport cloud/1.36] [feat] Filter out nlf model type from Upload Model flow#7886

Merged
luke-mino-altherr merged 1 commit intocloud/1.36from
backport-7793-to-cloud-1.36
Jan 8, 2026
Merged

[backport cloud/1.36] [feat] Filter out nlf model type from Upload Model flow#7886
luke-mino-altherr merged 1 commit intocloud/1.36from
backport-7793-to-cloud-1.36

Conversation

@comfy-pr-bot
Copy link
Member

Backport of #7793 to cloud/1.36

Automatically created by backport workflow.

## Summary
Filters out the "nlf" (no-license-file) model type from the Upload Model
wizard's model type dropdown, preventing users from selecting this
internal category.

## Changes
- **What**: Added DISALLOWED_MODEL_TYPES constant and filter in
useModelTypes composable
- **Scope**: Only affects Upload Model flow (used by UploadModelDialog
and UploadModelConfirmation)

## Test plan
- [ ] Open Upload Model dialog and verify "nlf" does not appear in model
type dropdown
- [ ] Verify other model types still appear correctly
- [ ] Verify dropdown still functions as expected

🤖 Generated with [Claude Code](https://claude.com/claude-code)

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7793-feat-Filter-out-nlf-model-type-from-Upload-Model-flow-2d86d73d3650811f88e1fcc8dd7040cd)
by [Unito](https://www.unito.io)

Co-authored-by: Claude <noreply@anthropic.com>
@comfy-pr-bot comfy-pr-bot requested a review from a team as a code owner January 8, 2026 00:14
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Jan 8, 2026
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 8, 2026
@github-actions
Copy link

github-actions bot commented Jan 8, 2026

🎨 Storybook Build Status

Build completed successfully!

⏰ Completed at: 01/08/2026, 12:16:07 AM UTC

🔗 Links


🎉 Your Storybook is ready for review!

@github-actions
Copy link

github-actions bot commented Jan 8, 2026

🎭 Playwright Test Results

All tests passed!

⏰ Completed at: 01/08/2026, 12:24:19 AM UTC

📈 Summary

  • Total Tests: 514
  • Passed: 506 ✅
  • Failed: 0
  • Flaky: 0
  • Skipped: 8 ⏭️

📊 Test Reports by Browser

  • chromium: View Report • ✅ 494 / ❌ 0 / ⚠️ 0 / ⏭️ 8
  • chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • mobile-chrome: View Report • ✅ 9 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

@luke-mino-altherr luke-mino-altherr merged commit 8eb2ba0 into cloud/1.36 Jan 8, 2026
20 checks passed
@luke-mino-altherr luke-mino-altherr deleted the backport-7793-to-cloud-1.36 branch January 8, 2026 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants