disable workflow validation warnings by default#7795
Merged
christian-byrne merged 1 commit intomainfrom Dec 30, 2025
Merged
Conversation
dosubot
bot
added
the
size:XS
Contributor
📝 WalkthroughWalkthroughThe default value for the workflow validation setting in core settings was changed from a cloud-dependent conditional expression to a constant false value, disabling workflow validation by default across all environments regardless of deployment context. Changes
✨ Finishing touches
📜 Recent review detailsConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (7)src/**/*.{vue,ts}📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
src/**/*.ts📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
src/**/*.{ts,tsx,vue}📄 CodeRabbit inference engine (src/CLAUDE.md)
Files:
src/**/*.{vue,ts,tsx}📄 CodeRabbit inference engine (src/CLAUDE.md)
Files:
**/*.{ts,tsx,vue}📄 CodeRabbit inference engine (AGENTS.md)
Files:
**/*.{ts,tsx,vue,js,jsx,json,css}📄 CodeRabbit inference engine (AGENTS.md)
Files:
**/*.{ts,tsx}📄 CodeRabbit inference engine (AGENTS.md)
Files:
🧠 Learnings (4)📚 Learning: 2025-12-09T03:39:54.501ZApplied to files:
📚 Learning: 2025-12-13T11:03:11.264ZApplied to files:
📚 Learning: 2025-12-17T00:40:09.635ZApplied to files:
📚 Learning: 2025-12-11T12:25:15.470ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎭 Playwright Test Results❌ Some tests failed ⏰ Completed at: 12/29/2025, 11:43:34 PM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 12/29/2025, 11:34:47 PM UTC 🔗 Links🎉 Your Storybook is ready for review! |
AustinMroz
approved these changes
Dec 29, 2025
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 3.2 MB (baseline 3.2 MB) • ⚪ 0 BMain entry bundles and manifests
Status: 3 added / 3 removed Graph Workspace — 1000 kB (baseline 1000 kB) • 🔴 +1 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 6.63 kB (baseline 6.63 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 1 added / 1 removed Panels & Settings — 300 kB (baseline 300 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 6 added / 6 removed UI Components — 199 kB (baseline 199 kB) • ⚪ 0 BReusable component library chunks
Status: 9 added / 9 removed Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 2 added / 2 removed Utilities & Hooks — 1.41 kB (baseline 1.41 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 1 added / 1 removed Vendor & Third-Party — 9.1 MB (baseline 9.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 3.47 MB (baseline 3.47 MB) • ⚪ 0 BBundles that do not match a named category
Status: 20 added / 20 removed |
DrJKL
approved these changes
Dec 30, 2025
christian-byrne
added
needs-backport
github-actions bot
pushed a commit
that referenced
this pull request
Jan 13, 2026
# Background Currently, validation warnings about zod schema violations are shown to all users when loading workflows. These warnings appear in a dialog that users must dismiss, and they reappear every time the workflow is reloaded. ## User Pain Points - Many users (especially from the Chinese community) are asking how to disable these alerts - The zod schema information is too technical for end users - Users don't understand what action they should take when seeing the warning - The warnings cannot be permanently dismissed - they reappear every time - The warnings don't actually prevent workflow execution ## Problem Statement The validation warning just means the serialized workflow doesn't conform to the official schema. Sometimes that makes the workflow unusable; sometimes it still runs fine. While these checks have historically surfaced real issues and are important for maintaining static types internally, the current UX isn't helpful to regular users. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7795-disable-workflow-validation-warnings-by-default-2d86d73d36508102a0f7c46d43189e38) by [Unito](https://www.unito.io)
github-actions bot
pushed a commit
that referenced
this pull request
Jan 13, 2026
# Background Currently, validation warnings about zod schema violations are shown to all users when loading workflows. These warnings appear in a dialog that users must dismiss, and they reappear every time the workflow is reloaded. ## User Pain Points - Many users (especially from the Chinese community) are asking how to disable these alerts - The zod schema information is too technical for end users - Users don't understand what action they should take when seeing the warning - The warnings cannot be permanently dismissed - they reappear every time - The warnings don't actually prevent workflow execution ## Problem Statement The validation warning just means the serialized workflow doesn't conform to the official schema. Sometimes that makes the workflow unusable; sometimes it still runs fine. While these checks have historically surfaced real issues and are important for maintaining static types internally, the current UX isn't helpful to regular users. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7795-disable-workflow-validation-warnings-by-default-2d86d73d36508102a0f7c46d43189e38) by [Unito](https://www.unito.io)
Member
|
@christian-byrne Successfully backported to #7977 |
Member
|
@christian-byrne Successfully backported to #7978 |
github-actions
bot
removed
the
needs-backport
christian-byrne
added a commit
that referenced
this pull request
Jan 13, 2026
…7977) Backport of #7795 to `core/1.36` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7977-backport-core-1-36-disable-workflow-validation-warnings-by-default-2e76d73d365081c2bef7f12abd0b614b) by [Unito](https://www.unito.io) Co-authored-by: Christian Byrne <cbyrne@comfy.org>
christian-byrne
added a commit
that referenced
this pull request
Jan 13, 2026
…#7978) Backport of #7795 to `cloud/1.36` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7978-backport-cloud-1-36-disable-workflow-validation-warnings-by-default-2e76d73d365081bb88e9ff3df97a2bf3) by [Unito](https://www.unito.io) Co-authored-by: Christian Byrne <cbyrne@comfy.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Currently, validation warnings about zod schema violations are shown to all users when loading workflows. These warnings appear in a dialog that users must dismiss, and they reappear every time the workflow is reloaded.
User Pain Points
Problem Statement
The validation warning just means the serialized workflow doesn't conform to the official schema. Sometimes that makes the workflow unusable; sometimes it still runs fine. While these checks have historically surfaced real issues and are important for maintaining static types internally, the current UX isn't helpful to regular users.
┆Issue is synchronized with this Notion page by Unito